| Message ID | 1597278668-339715-1-git-send-email-fnu.vikram@xilinx.com |
|---|---|
| Headers | show |
| Series | Introduce Xilinx ZynqMP CAN controller | expand |
On Thu, 13 Aug 2020 at 01:33, Vikram Garhwal <fnu.vikram@xilinx.com> wrote: > Vikram Garhwal (4): > hw/net/can: Introduce Xilinx ZynqMP CAN controller > xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers > tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller > MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller Applied to target-arm.next, thanks. (I had to make some minor fixups to convert the makefile changes to the new meson build system.) -- PMM
On Mon, 14 Sep 2020 at 14:16, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Thu, 13 Aug 2020 at 01:33, Vikram Garhwal <fnu.vikram@xilinx.com> wrote: > > Vikram Garhwal (4): > > hw/net/can: Introduce Xilinx ZynqMP CAN controller > > xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers > > tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller > > MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller > > Applied to target-arm.next, thanks. (I had to make some > minor fixups to convert the makefile changes to the new > meson build system.) I had to drop these patches because in the full merge build test configs they failed to link because nothing was pulling in the generic CONFIG_CAN_BUS files. Could you rebase this, make the necessary changes to get it to work with meson[*], and also make whatever Kconfig changes are necessary so that the ZynqMP CAN controller device declares its dependency on the generic CONFIG_CAN_BUS code, please? [*] you might want to look at the versions of the patches I just sent out in my v1 pullreq today, but basically instead of the Makefile.include changes you want some simple one-liner changes to meson.build files, and also tests/qtest/xlnx-can-test.c needs to #include "libqos/libqtest.h" rather than just "libqtest.h". thanks -- PMM
Hi Peter, Thanks for the help here. I had a look at the v1 pull. I will rebase the patches with latest changes and send next version with changes. Regards, Vikram > -----Original Message----- > From: Peter Maydell <peter.maydell@linaro.org> > Sent: Monday, September 14, 2020 8:06 AM > To: Vikram Garhwal <fnuv@xilinx.com> > Cc: QEMU Developers <qemu-devel@nongnu.org>; Francisco Eduardo > Iglesias <figlesia@xilinx.com> > Subject: Re: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller > > On Mon, 14 Sep 2020 at 14:16, Peter Maydell <peter.maydell@linaro.org> > wrote: > > > > On Thu, 13 Aug 2020 at 01:33, Vikram Garhwal <fnu.vikram@xilinx.com> > wrote: > > > Vikram Garhwal (4): > > > hw/net/can: Introduce Xilinx ZynqMP CAN controller > > > xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers > > > tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller > > > MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller > > > > Applied to target-arm.next, thanks. (I had to make some minor fixups > > to convert the makefile changes to the new meson build system.) > > I had to drop these patches because in the full merge build test configs they > failed to link because nothing was pulling in the generic CONFIG_CAN_BUS > files. > > Could you rebase this, make the necessary changes to get it to work with > meson[*], and also make whatever Kconfig changes are necessary so that > the ZynqMP CAN controller device declares its dependency on the generic > CONFIG_CAN_BUS code, please? > > [*] you might want to look at the versions of the patches I just sent out in > my v1 pullreq today, but basically instead of the Makefile.include changes > you want some simple one-liner changes to meson.build files, and also > tests/qtest/xlnx-can-test.c needs to #include "libqos/libqtest.h" > rather than just "libqtest.h". > > thanks > -- PMM
Hi Peter, I sent rebased V10 series three weeks back as there were some issues with meson build on v9. Would it possible for you to apply the patch series? Link for series: https://patchew.org/QEMU/1600121324-31337-1-git-send-email-fnu.vikram@xilinx.com/ Regards, Vikram > -----Original Message----- > From: Vikram Garhwal <fnu.vikram@xilinx.com> > Sent: Monday, September 14, 2020 3:29 PM > To: Peter Maydell <peter.maydell@linaro.org> > Subject: Re: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller > > Hi Peter, > I just sent the v10 series which is rebased with latest master branch > changes. > > Thanks again for the help. > > Regards, > Vikram > > On Mon, Sep 14, 2020 at 04:06:29PM +0100, Peter Maydell wrote: > > On Mon, 14 Sep 2020 at 14:16, Peter Maydell > <peter.maydell@linaro.org> wrote: > > > > > > On Thu, 13 Aug 2020 at 01:33, Vikram Garhwal > <fnu.vikram@xilinx.com> wrote: > > > > Vikram Garhwal (4): > > > > hw/net/can: Introduce Xilinx ZynqMP CAN controller > > > > xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers > > > > tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller > > > > MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN > > > > controller > > > > > > Applied to target-arm.next, thanks. (I had to make some minor fixups > > > to convert the makefile changes to the new meson build system.) > > > > I had to drop these patches because in the full merge build test > > configs they failed to link because nothing was pulling in the generic > > CONFIG_CAN_BUS files. > > > > Could you rebase this, make the necessary changes to get it to work > > with meson[*], and also make whatever Kconfig changes are necessary so > > that the ZynqMP CAN controller device declares its dependency on the > > generic CONFIG_CAN_BUS code, please? > > > > [*] you might want to look at the versions of the patches I just sent > > out in my v1 pullreq today, but basically instead of the > > Makefile.include changes you want some simple one-liner changes to > > meson.build files, and also tests/qtest/xlnx-can-test.c needs to > > #include "libqos/libqtest.h" > > rather than just "libqtest.h". > > > > thanks > > -- PMM
On Thu, 1 Oct 2020 at 18:57, Vikram Garhwal <fnuv@xilinx.com> wrote: > > Hi Peter, > I sent rebased V10 series three weeks back as there were some issues with meson build on v9. Would it possible for you to apply the patch series? Oops, sorry -- I didn't notice the resent series. I've put it on my list to handle. thanks -- PMM
Changelog: v8 -> v9: Use g_autofree to do automatic cleanup the object_get_canonical_path() used. v7 -> v8: Change CAN controller to keep one canbus per controller. Add canbus connections at machine level. Remove ctrl_idx from CAN controller. v6 -> v7: Remove '-m 4G' option from xlnx-can-test. This option causes the fail of docker-quick@centos7 build test. v5 -> v6: Add ptimer based counter for time stamping on RX messages. Fix reset issues. Rebase the patches with master latest changes. Added reference clock property for CAN ptimer. v4 -> v5: Add XlnxZynqMPCAN controller id to debug messages. Drop parameter errp of object_property_add(). Add formatting related suggestions. v3 -> v4: Correct formatting issues. v2 -> v3: Rectify the build issue. Rearrange the patch order. v1 -> v2: Rename the CAN device state and address code style issues. Connect the CAN device to Xlnx-ZCU102 board. Add maintainer entry. Add QTEST for the CAN device. Vikram Garhwal (4): hw/net/can: Introduce Xilinx ZynqMP CAN controller xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller MAINTAINERS | 8 + hw/arm/xlnx-zcu102.c | 20 + hw/arm/xlnx-zynqmp.c | 34 ++ hw/net/can/Makefile.objs | 1 + hw/net/can/xlnx-zynqmp-can.c | 1165 ++++++++++++++++++++++++++++++++++++++ include/hw/arm/xlnx-zynqmp.h | 8 + include/hw/net/xlnx-zynqmp-can.h | 78 +++ tests/qtest/Makefile.include | 2 + tests/qtest/xlnx-can-test.c | 359 ++++++++++++ 9 files changed, 1675 insertions(+) create mode 100644 hw/net/can/xlnx-zynqmp-can.c create mode 100644 include/hw/net/xlnx-zynqmp-can.h create mode 100644 tests/qtest/xlnx-can-test.c -- 2.7.4