Message ID | 20200909175707.10670-1-amir73il@gmail.com |
---|---|
Headers | show |
Series | Fanotify tests for v5.9 | expand |
Hi Amir, > Hi Petr, > Following are the tests that were used to develop the upcoming fanotify > features in v5.9. Thanks a lot for perfect update. There is LTP freeze soon (in 2 weeks [1]). I'd like to merge your patches although it'll be probably v5.9 release. Patches LGTM, but I'd like to give change the others to look into them. I tested all fanotify tests on 5.9.0-rc3 from openSUSE and on various old kernels from various distros. Kind regards, Petr [1] http://lists.linux.it/pipermail/ltp/2020-September/018860.html > The inotify/dnotify tests and fanotify09 test case are regression tests > for a mid series bug that has been fixed before the merge. > fanotify10 gets another set of test cases to catch yet another ignored > mask logic bug. The fix commit will be too hard to backport IMO, so > perhaps these test cases should go into a new test with .min_kver = "5.9". > Thanks, > Amir.
Hi Amir, > Patches LGTM, but I'd like to give change the others to look into them. Acked-by: Petr Vorel <pvorel@suse.cz> Kind regards, Petr
Hi Amir, > Following are the tests that were used to develop the upcoming fanotify > features in v5.9. > The inotify/dnotify tests and fanotify09 test case are regression tests > for a mid series bug that has been fixed before the merge. Patchset merged. > fanotify10 gets another set of test cases to catch yet another ignored > mask logic bug. The fix commit will be too hard to backport IMO, so > perhaps these test cases should go into a new test with .min_kver = "5.9". Can we just skip particular test with tst_parse_kver() or tst_kvcmp()? Because other tests are valid, thus why to skip them (which would be when using .min_kver). Kind regards, Petr
On Thu, Sep 10, 2020 at 2:27 PM Petr Vorel <pvorel@suse.cz> wrote: > > Hi Amir, > > > Following are the tests that were used to develop the upcoming fanotify > > features in v5.9. > > > The inotify/dnotify tests and fanotify09 test case are regression tests > > for a mid series bug that has been fixed before the merge. > Patchset merged. > > > fanotify10 gets another set of test cases to catch yet another ignored > > mask logic bug. The fix commit will be too hard to backport IMO, so > > perhaps these test cases should go into a new test with .min_kver = "5.9". > Can we just skip particular test with tst_parse_kver() or tst_kvcmp()? Because > other tests are valid, thus why to skip them (which would be when using > .min_kver). Sure I did not know about tst_parse_kver() I will send a patch. BTW, sorry for the wrong commit id in the test. Your fix missed removing the old commit from comment: * Test cases #17-#23 are regression tests for commit: * * 497b0c5a7c06 fsnotify: send event to parent and child with single... * eca4784cbb18 fsnotify: send event to parent and child with single... */ Thanks, Amir.
On Thu, Sep 10, 2020 at 4:36 PM Amir Goldstein <amir73il@gmail.com> wrote: > > On Thu, Sep 10, 2020 at 2:27 PM Petr Vorel <pvorel@suse.cz> wrote: > > > > Hi Amir, > > > > > Following are the tests that were used to develop the upcoming fanotify > > > features in v5.9. > > > > > The inotify/dnotify tests and fanotify09 test case are regression tests > > > for a mid series bug that has been fixed before the merge. > > Patchset merged. > > > > > fanotify10 gets another set of test cases to catch yet another ignored > > > mask logic bug. The fix commit will be too hard to backport IMO, so > > > perhaps these test cases should go into a new test with .min_kver = "5.9". > > Can we just skip particular test with tst_parse_kver() or tst_kvcmp()? Because > > other tests are valid, thus why to skip them (which would be when using > > .min_kver). > > Sure I did not know about tst_parse_kver() I will send a patch. > > BTW, sorry for the wrong commit id in the test. > Your fix missed removing the old commit from comment: > > * Test cases #17-#23 are regression tests for commit: > * > * 497b0c5a7c06 fsnotify: send event to parent and child with single... > * eca4784cbb18 fsnotify: send event to parent and child with single... > */ > Actually, I don't see any examples of tests that use tst_kvcmp() Do you mind making and testing this change? All the test cases in fanotify10 with non zero tc->ignored_onchild should be skipped for kver < 5.9 Thanks, Amir.
Hi! > > Sure I did not know about tst_parse_kver() I will send a patch. > > > > BTW, sorry for the wrong commit id in the test. > > Your fix missed removing the old commit from comment: > > > > * Test cases #17-#23 are regression tests for commit: > > * > > * 497b0c5a7c06 fsnotify: send event to parent and child with single... > > * eca4784cbb18 fsnotify: send event to parent and child with single... > > */ > > > > Actually, I don't see any examples of tests that use tst_kvcmp() It's tst_kvercmp() the tst_kvcmp() is internal library function that shouldn't be used in testcases.