| Message ID | 20200821111127.3771-1-geert+renesas@glider.be |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt-bindings: pinctrl: renesas,rza2-pinctrl: Fix pin controller node name | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
Hello! On 8/21/20 2:11 PM, Geert Uytterhoeven wrote: > According to Devicetree Specification v0.2 and later, Section "Generic > Names Recommendation", the node name for a pin controller device node > should be "pinctrl". Ugh, what a lame name! :-( And they say DT should be OS agnostic... > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> I think more DTs have "pin-controler". [...] MBR, Sergei
Hi Sergei, On Fri, Aug 21, 2020 at 5:27 PM Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote: > On 8/21/20 2:11 PM, Geert Uytterhoeven wrote: > > According to Devicetree Specification v0.2 and later, Section "Generic > > Names Recommendation", the node name for a pin controller device node > > should be "pinctrl". > > Ugh, what a lame name! :-( > And they say DT should be OS agnostic... > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > I think more DTs have "pin-controler". I was surprised to discover the opposite, too: $ git grep "\<pinctrl@" v5.9-rc1 | wc -l 335 $ git grep "\<pin-controller@" v5.9-rc1 | wc -l 102 Gr{oetje,eeting}s, Geert
On 21.08.2020 20:41, Geert Uytterhoeven wrote: >> On 8/21/20 2:11 PM, Geert Uytterhoeven wrote: >>> According to Devicetree Specification v0.2 and later, Section "Generic >>> Names Recommendation", the node name for a pin controller device node >>> should be "pinctrl". >> >> Ugh, what a lame name! :-( >> And they say DT should be OS agnostic... >> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> I think more DTs have "pin-controler". > > I was surprised to discover the opposite, too: > > $ git grep "\<pinctrl@" v5.9-rc1 | wc -l > 335 > $ git grep "\<pin-controller@" v5.9-rc1 | wc -l > 102 Sorry, I was probably thinking that I was replying to a DT patch, not the bindings patch, hence this comment (it only meant Renesas DTs). It doesn't really surprise me that more DTs overall have "pinctrl", sigh... > Gr{oetje,eeting}s, > > Geert MBR, Sergei
On Fri, Aug 21, 2020 at 5:27 PM Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote: > On 8/21/20 2:11 PM, Geert Uytterhoeven wrote: > > > According to Devicetree Specification v0.2 and later, Section "Generic > > Names Recommendation", the node name for a pin controller device node > > should be "pinctrl". > > Ugh, what a lame name! :-( > And they say DT should be OS agnostic... Ha ha. :D The device tree standardization is driven with the bureaucratic ambition to be generic, predictable and non-personal. Mimicing the characteristic of the impersonal objects in life, such as the planets, or the plants. This is just an ambition, in reality the people doing it are Linux-heads. We (the DT community) try to be better people, we just fail regularly. That is OK, the important thing is to know one can and should do better. Yours, Linus Walleij
On Fri, 21 Aug 2020 13:11:27 +0200, Geert Uytterhoeven wrote: > According to Devicetree Specification v0.2 and later, Section "Generic > Names Recommendation", the node name for a pin controller device node > should be "pinctrl". > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > To be queued in sh-pfc for v5.10. > > .../devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml index b7911a994f3a9f12..ce1f7343788faeff 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml @@ -84,7 +84,7 @@ additionalProperties: false examples: - | #include <dt-bindings/pinctrl/r7s9210-pinctrl.h> - pinctrl: pin-controller@fcffe000 { + pinctrl: pinctrl@fcffe000 { compatible = "renesas,r7s9210-pinctrl"; reg = <0xfcffe000 0x1000>;
According to Devicetree Specification v0.2 and later, Section "Generic Names Recommendation", the node name for a pin controller device node should be "pinctrl". Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- To be queued in sh-pfc for v5.10. .../devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)