| Message ID | 20200721144832.750728-1-abanoubsameh@protonmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: gpio-crystalcove.c: changed every 'unsigned' to 'unsigned int' | expand |
On Tue, Jul 21, 2020 at 5:49 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote: > > Changed 'unsigned' to 'unsigned int'. > This makes the code more uniform, and compliant with the kernel coding style. In all patches you wrongly added 'gpio-' and '.c' parts. Also you missed the version of the patches (I have told you about) and changelog. No need to resend, I fixed that this time for you. Be careful in the future.
On Tue, Jul 21, 2020 at 6:05 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Tue, Jul 21, 2020 at 5:49 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote: > > > > Changed 'unsigned' to 'unsigned int'. > > This makes the code more uniform, and compliant with the kernel coding style. > > In all patches you wrongly added 'gpio-' and '.c' parts. Also you > missed the version of the patches (I have told you about) and > changelog. > > No need to resend, I fixed that this time for you. Be careful in the future. > > -- > With Best Regards, > Andy Shevchenko Hi Andy, I was going through pending patches and noticed those from Abanoub: are you also the maintainer for gpio-crystalcove and gpio-msic? The MAINTAINERS entry for Intel GPIO drivers doesn't include those - do you want me to send a patch that adds them? Bartosz
On Wed, Aug 19, 2020 at 8:56 PM Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > > On Tue, Jul 21, 2020 at 6:05 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > > On Tue, Jul 21, 2020 at 5:49 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote: > > > > > > Changed 'unsigned' to 'unsigned int'. > > > This makes the code more uniform, and compliant with the kernel coding style. > > > > In all patches you wrongly added 'gpio-' and '.c' parts. Also you > > missed the version of the patches (I have told you about) and > > changelog. > > > > No need to resend, I fixed that this time for you. Be careful in the future. > I was going through pending patches and noticed those from Abanoub: > are you also the maintainer for gpio-crystalcove and gpio-msic? The > MAINTAINERS entry for Intel GPIO drivers doesn't include those - do > you want me to send a patch that adds them? Hmm... https://elixir.bootlin.com/linux/latest/source/MAINTAINERS#L8833
On Wed, Aug 19, 2020 at 8:50 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Aug 19, 2020 at 8:56 PM Bartosz Golaszewski > <bgolaszewski@baylibre.com> wrote: > > > > On Tue, Jul 21, 2020 at 6:05 PM Andy Shevchenko > > <andy.shevchenko@gmail.com> wrote: > > > > > > On Tue, Jul 21, 2020 at 5:49 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote: > > > > > > > > Changed 'unsigned' to 'unsigned int'. > > > > This makes the code more uniform, and compliant with the kernel coding style. > > > > > > In all patches you wrongly added 'gpio-' and '.c' parts. Also you > > > missed the version of the patches (I have told you about) and > > > changelog. > > > > > > No need to resend, I fixed that this time for you. Be careful in the future. > > > I was going through pending patches and noticed those from Abanoub: > > are you also the maintainer for gpio-crystalcove and gpio-msic? The > > MAINTAINERS entry for Intel GPIO drivers doesn't include those - do > > you want me to send a patch that adds them? > > Hmm... > https://elixir.bootlin.com/linux/latest/source/MAINTAINERS#L8833 > Ah, I was grepping with "crystalcove" and didn't find anything. Strange I missed msic too though. Anyway: nevermind my email. Bart
diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c index 14d1f4c933b6..9391722ec107 100644 --- a/drivers/gpio/gpio-crystalcove.c +++ b/drivers/gpio/gpio-crystalcove.c @@ -129,7 +129,7 @@ static void crystalcove_update_irq_ctrl(struct crystalcove_gpio *cg, int gpio) regmap_update_bits(cg->regmap, reg, CTLI_INTCNT_BE, cg->intcnt_value); } -static int crystalcove_gpio_dir_in(struct gpio_chip *chip, unsigned gpio) +static int crystalcove_gpio_dir_in(struct gpio_chip *chip, unsigned int gpio) { struct crystalcove_gpio *cg = gpiochip_get_data(chip); int reg = to_reg(gpio, CTRL_OUT); @@ -140,7 +140,7 @@ static int crystalcove_gpio_dir_in(struct gpio_chip *chip, unsigned gpio) return regmap_write(cg->regmap, reg, CTLO_INPUT_SET); } -static int crystalcove_gpio_dir_out(struct gpio_chip *chip, unsigned gpio, +static int crystalcove_gpio_dir_out(struct gpio_chip *chip, unsigned int gpio, int value) { struct crystalcove_gpio *cg = gpiochip_get_data(chip); @@ -152,7 +152,7 @@ static int crystalcove_gpio_dir_out(struct gpio_chip *chip, unsigned gpio, return regmap_write(cg->regmap, reg, CTLO_OUTPUT_SET | value); } -static int crystalcove_gpio_get(struct gpio_chip *chip, unsigned gpio) +static int crystalcove_gpio_get(struct gpio_chip *chip, unsigned int gpio) { struct crystalcove_gpio *cg = gpiochip_get_data(chip); unsigned int val; @@ -169,7 +169,7 @@ static int crystalcove_gpio_get(struct gpio_chip *chip, unsigned gpio) } static void crystalcove_gpio_set(struct gpio_chip *chip, - unsigned gpio, int value) + unsigned int gpio, int value) { struct crystalcove_gpio *cg = gpiochip_get_data(chip); int reg = to_reg(gpio, CTRL_OUT); @@ -183,7 +183,7 @@ static void crystalcove_gpio_set(struct gpio_chip *chip, regmap_update_bits(cg->regmap, reg, 1, 0); } -static int crystalcove_irq_type(struct irq_data *data, unsigned type) +static int crystalcove_irq_type(struct irq_data *data, unsigned int type) { struct crystalcove_gpio *cg = gpiochip_get_data(irq_data_get_irq_chip_data(data));
Changed 'unsigned' to 'unsigned int'. This makes the code more uniform, and compliant with the kernel coding style. Signed-off-by: Abanoub Sameh <abanoubsameh@protonmail.com> --- drivers/gpio/gpio-crystalcove.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)