| Message ID | 7690882a389d8172e484a22c737a29cf7afaa526.1597826658.git.michal.simek@xilinx.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | Incorrect Kconfig dependencies | expand |
On Wed, Aug 19, 2020 at 10:44:19AM +0200, Michal Simek wrote: > USB_FUNCTION_SDP depends on USB_GADGET_DOWNLOAD to be enabled which is not > reflect in Kconfig. Fix it by changing select to depends on for CMD_USB_SDP > command. > Kconfig is reporting it as: > WARNING: unmet direct dependencies detected for USB_FUNCTION_SDP > Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n] > Selected by [y]: > - CMD_USB_SDP [=y] > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > cmd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index bd3559ae6c12..f291c8cbf423 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1351,7 +1351,7 @@ config CMD_USB > > config CMD_USB_SDP > bool "sdp" > - select USB_FUNCTION_SDP > + depends on USB_FUNCTION_SDP > help > Enables the command "sdp" which is used to have U-Boot emulating the > Serial Download Protocol (SDP) via USB. Based on usage, USB_FUNCTION_SDP looks to really be a library type function. Adding some iMX folks as it's used there, and Lokesh since the K2G platforms enable the library side, but I don't think use it?
diff --git a/cmd/Kconfig b/cmd/Kconfig index bd3559ae6c12..f291c8cbf423 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1351,7 +1351,7 @@ config CMD_USB config CMD_USB_SDP bool "sdp" - select USB_FUNCTION_SDP + depends on USB_FUNCTION_SDP help Enables the command "sdp" which is used to have U-Boot emulating the Serial Download Protocol (SDP) via USB.
USB_FUNCTION_SDP depends on USB_GADGET_DOWNLOAD to be enabled which is not reflect in Kconfig. Fix it by changing select to depends on for CMD_USB_SDP command. Kconfig is reporting it as: WARNING: unmet direct dependencies detected for USB_FUNCTION_SDP Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n] Selected by [y]: - CMD_USB_SDP [=y] Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)