diff mbox series

[23/41] nubus: Delete unused NUBUS_BRIDGE macro

Message ID 20200813222625.243136-24-ehabkost@redhat.com
State New
Headers show
Series qom: Automated conversion of type checking boilerplate | expand

Commit Message

Eduardo Habkost Aug. 13, 2020, 10:26 p.m. UTC 
The macro never worked because the NubusBridge typedef doesn't
exist.  Delete it.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/hw/nubus/nubus.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Philippe Mathieu-Daudé Aug. 14, 2020, 6:03 p.m. UTC | #1 
On 8/14/20 12:26 AM, Eduardo Habkost wrote:
> The macro never worked because the NubusBridge typedef doesn't
> exist.  Delete it.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  include/hw/nubus/nubus.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/nubus/nubus.h b/include/hw/nubus/nubus.h
> index a8634e54c5..c350948262 100644
> --- a/include/hw/nubus/nubus.h
> +++ b/include/hw/nubus/nubus.h
> @@ -29,7 +29,6 @@
>  #define NUBUS_BUS(obj) OBJECT_CHECK(NubusBus, (obj), TYPE_NUBUS_BUS)
>  
>  #define TYPE_NUBUS_BRIDGE "nubus-bridge"
> -#define NUBUS_BRIDGE(obj) OBJECT_CHECK(NubusBridge, (obj), TYPE_NUBUS_BRIDGE)
>  
>  typedef struct NubusBus {
>      BusState qbus;
>
Daniel P. Berrangé Aug. 17, 2020, 4:03 p.m. UTC | #2 
On Thu, Aug 13, 2020 at 06:26:07PM -0400, Eduardo Habkost wrote:
> The macro never worked because the NubusBridge typedef doesn't
> exist.  Delete it.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  include/hw/nubus/nubus.h | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
diff mbox series

Patch

diff --git a/include/hw/nubus/nubus.h b/include/hw/nubus/nubus.h
index a8634e54c5..c350948262 100644
--- a/include/hw/nubus/nubus.h
+++ b/include/hw/nubus/nubus.h
@@ -29,7 +29,6 @@ 
 #define NUBUS_BUS(obj) OBJECT_CHECK(NubusBus, (obj), TYPE_NUBUS_BUS)
 
 #define TYPE_NUBUS_BRIDGE "nubus-bridge"
-#define NUBUS_BRIDGE(obj) OBJECT_CHECK(NubusBridge, (obj), TYPE_NUBUS_BRIDGE)
 
 typedef struct NubusBus {
     BusState qbus;