| Message ID | 20200813222625.243136-6-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qom: Automated conversion of type checking boilerplate | expand |
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > The macro definition had an extra semicolon. This was never > noticed because the macro was only being used where it didn't > make a difference. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > include/hw/timer/aspeed_timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/timer/aspeed_timer.h b/include/hw/timer/aspeed_timer.h > index 948329893c..d7c7d8ad28 100644 > --- a/include/hw/timer/aspeed_timer.h > +++ b/include/hw/timer/aspeed_timer.h > @@ -26,7 +26,7 @@ > #include "hw/misc/aspeed_scu.h" > > #define ASPEED_TIMER(obj) \ > - OBJECT_CHECK(AspeedTimerCtrlState, (obj), TYPE_ASPEED_TIMER); > + OBJECT_CHECK(AspeedTimerCtrlState, (obj), TYPE_ASPEED_TIMER) > #define TYPE_ASPEED_TIMER "aspeed.timer" > #define TYPE_ASPEED_2400_TIMER TYPE_ASPEED_TIMER "-ast2400" > #define TYPE_ASPEED_2500_TIMER TYPE_ASPEED_TIMER "-ast2500" > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On Thu, Aug 13, 2020 at 06:25:49PM -0400, Eduardo Habkost wrote: > The macro definition had an extra semicolon. This was never > noticed because the macro was only being used where it didn't > make a difference. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > include/hw/timer/aspeed_timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
diff --git a/include/hw/timer/aspeed_timer.h b/include/hw/timer/aspeed_timer.h index 948329893c..d7c7d8ad28 100644 --- a/include/hw/timer/aspeed_timer.h +++ b/include/hw/timer/aspeed_timer.h @@ -26,7 +26,7 @@ #include "hw/misc/aspeed_scu.h" #define ASPEED_TIMER(obj) \ - OBJECT_CHECK(AspeedTimerCtrlState, (obj), TYPE_ASPEED_TIMER); + OBJECT_CHECK(AspeedTimerCtrlState, (obj), TYPE_ASPEED_TIMER) #define TYPE_ASPEED_TIMER "aspeed.timer" #define TYPE_ASPEED_2400_TIMER TYPE_ASPEED_TIMER "-ast2400" #define TYPE_ASPEED_2500_TIMER TYPE_ASPEED_TIMER "-ast2500"
The macro definition had an extra semicolon. This was never noticed because the macro was only being used where it didn't make a difference. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- include/hw/timer/aspeed_timer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)