| Message ID | 1307348541-2466-7-git-send-email-holger.brunck@keymile.com |
|---|---|
| State | Accepted |
| Commit | ba8be32a8f653b117a3623c4c45b010a34fdf54d |
| Headers | show |
Dear Holger Brunck, In message <1307348541-2466-7-git-send-email-holger.brunck@keymile.com> you wrote: > This is unneeded here because we save the environment when > the board boots the first time. At this time we have set > the values already. > > Signed-off-by: Holger Brunck <holger.brunck@keymile.com> > Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com> > cc: Heiko Schocher <hs@denx.de> > cc: Wolfgang Denk <wd@denx.de> > --- > board/keymile/common/common.c | 7 +------ > 1 files changed, 1 insertions(+), 6 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c index fef6253..d8fcd39 100644 --- a/board/keymile/common/common.c +++ b/board/keymile/common/common.c @@ -831,11 +831,7 @@ int do_checkboardidhwk(cmd_tbl_t *cmdtp, int flag, int argc, * Compare the values of the found entry in the * list with the valid values which are stored * in the inventory eeprom. If they are equal - * store the values in environment variables - * and save the environment. - * This can only happen once for the lifetime - * of a board, because once saved the function - * will never reach the while loop. + * set the values in environment variables. */ if ((bid == ivmbid) && (hwkey == ivmhwkey)) { char buf[10]; @@ -847,7 +843,6 @@ int do_checkboardidhwk(cmd_tbl_t *cmdtp, int flag, int argc, setenv("boardid", buf); sprintf(buf, "%lx", hwkey); setenv("hwkey", buf); - saveenv(); } } /* end while( ! found ) */ }