| Message ID | 20200813222625.243136-23-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qom: Automated conversion of type checking boilerplate | expand |
On 8/14/20 12:26 AM, Eduardo Habkost wrote: > CanBusClass doesn't exist. This will break when we automatically > convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros > that reference the non-existing typedef. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > include/net/can_emu.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/net/can_emu.h b/include/net/can_emu.h > index fce9770928..7e90fd8a45 100644 > --- a/include/net/can_emu.h > +++ b/include/net/can_emu.h > @@ -100,10 +100,6 @@ struct CanBusClientState { > }; > > #define TYPE_CAN_BUS "can-bus" > -#define CAN_BUS_CLASS(klass) \ > - OBJECT_CLASS_CHECK(CanBusClass, (klass), TYPE_CAN_BUS) > -#define CAN_BUS_GET_CLASS(obj) \ > - OBJECT_GET_CLASS(CanBusClass, (obj), TYPE_CAN_BUS) > #define CAN_BUS(obj) \ > OBJECT_CHECK(CanBusState, (obj), TYPE_CAN_BUS) > >
On Thu, Aug 13, 2020 at 06:26:06PM -0400, Eduardo Habkost wrote: > CanBusClass doesn't exist. This will break when we automatically > convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros > that reference the non-existing typedef. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > include/net/can_emu.h | 4 ---- > 1 file changed, 4 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
diff --git a/include/net/can_emu.h b/include/net/can_emu.h index fce9770928..7e90fd8a45 100644 --- a/include/net/can_emu.h +++ b/include/net/can_emu.h @@ -100,10 +100,6 @@ struct CanBusClientState { }; #define TYPE_CAN_BUS "can-bus" -#define CAN_BUS_CLASS(klass) \ - OBJECT_CLASS_CHECK(CanBusClass, (klass), TYPE_CAN_BUS) -#define CAN_BUS_GET_CLASS(obj) \ - OBJECT_GET_CLASS(CanBusClass, (obj), TYPE_CAN_BUS) #define CAN_BUS(obj) \ OBJECT_CHECK(CanBusState, (obj), TYPE_CAN_BUS)
CanBusClass doesn't exist. This will break when we automatically convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros that reference the non-existing typedef. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- include/net/can_emu.h | 4 ---- 1 file changed, 4 deletions(-)