| Message ID | 20200813073712.4001404-1-kuhn.chenqun@huawei.com |
|---|---|
| Headers | show |
| Series | trivial patchs for static code analyzer fixes | expand |
Patchew URL: https://patchew.org/QEMU/20200813073712.4001404-1-kuhn.chenqun@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200813073712.4001404-1-kuhn.chenqun@huawei.com
Subject: [PATCH 00/11] trivial patchs for static code analyzer fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200813073712.4001404-1-kuhn.chenqun@huawei.com -> patchew/20200813073712.4001404-1-kuhn.chenqun@huawei.com
Switched to a new branch 'test'
4f73727 hw/display/vga:Remove redundant statement in vga_draw_graphic()
a501d39 hw/intc: Remove redundant statement in exynos4210_combiner_read()
084ebd8 usb/bus: Remove dead assignment in usb_get_fw_dev_path()
5b26d6a tcg/optimize: Remove redundant statement in tcg_optimize()
e628a22 vfio/platform: Remove dead assignment in vfio_intp_interrupt()
565efc1 hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check()
7b65ac4 hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions()
2dd718c target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16()
47833df target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli()
e1bb6c3 hw/arm/omap1:Remove redundant statement in omap_clkdsp_read()
39a7d8f hw/arm/virt-acpi-build:Remove dead assignment in build_madt()
=== OUTPUT BEGIN ===
1/11 Checking commit 39a7d8f2d62d (hw/arm/virt-acpi-build:Remove dead assignment in build_madt())
2/11 Checking commit e1bb6c3e178c (hw/arm/omap1:Remove redundant statement in omap_clkdsp_read())
3/11 Checking commit 47833df935a6 (target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli())
4/11 Checking commit 2dd718cc1926 (target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16())
5/11 Checking commit 7b65ac4ccb9d (hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions())
6/11 Checking commit 565efc12ec2a (hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check())
7/11 Checking commit e628a2236e95 (vfio/platform: Remove dead assignment in vfio_intp_interrupt())
8/11 Checking commit 5b26d6af75bd (tcg/optimize: Remove redundant statement in tcg_optimize())
9/11 Checking commit 084ebd878ce6 (usb/bus: Remove dead assignment in usb_get_fw_dev_path())
ERROR: space required after that ',' (ctx:VxV)
#25: FILE: hw/usb/bus.c:615:
+ snprintf(fw_path + pos, fw_len - pos, "%s@%lx",qdev_fw_name(qdev),
^
total: 1 errors, 0 warnings, 10 lines checked
Patch 9/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit a501d39c72e6 (hw/intc: Remove redundant statement in exynos4210_combiner_read())
11/11 Checking commit 4f73727eb19d (hw/display/vga:Remove redundant statement in vga_draw_graphic())
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200813073712.4001404-1-kuhn.chenqun@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200813073712.4001404-1-kuhn.chenqun@huawei.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
Unexpected error in object_property_try_add() at /tmp/qemu-test/src/qom/object.c:1181:
attempt to add duplicate property 'serial-id' to object (type 'container')
TEST iotest-qcow2: 024
ERROR test-char - too few tests run (expected 38, got 9)
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs....
qemu-system-aarch64: -accel kvm: invalid accelerator kvm
qemu-system-aarch64: falling back to tcg
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=fd298b6e40de496b90a85d10f907a880', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-xchonqx5/src/docker-src.2020-08-13-05.07.11.29699:/var/tmp/qemu:z,ro', 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=fd298b6e40de496b90a85d10f907a880
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-xchonqx5/src'
make: *** [docker-run-test-quick@centos7] Error 2
real 16m29.883s
user 0m8.672s
The full log is available at
http://patchew.org/logs/20200813073712.4001404-1-kuhn.chenqun@huawei.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hi All, This series fix trivial warnings reported by the Clang static code analyzer. Chen Qun (11): hw/arm/virt-acpi-build:Remove dead assignment in build_madt() hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16() hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions() hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check() vfio/platform: Remove dead assignment in vfio_intp_interrupt() tcg/optimize: Remove redundant statement in tcg_optimize() usb/bus: Remove dead assignment in usb_get_fw_dev_path() hw/intc: Remove redundant statement in exynos4210_combiner_read() hw/display/vga:Remove redundant statement in vga_draw_graphic() hw/arm/omap1.c | 1 - hw/arm/virt-acpi-build.c | 3 +-- hw/display/vga.c | 1 - hw/intc/exynos4210_combiner.c | 3 +-- hw/net/virtio-net.c | 1 - hw/usb/bus.c | 4 ++-- hw/vfio/platform.c | 2 +- hw/virtio/vhost-user.c | 2 +- target/arm/translate-a64.c | 7 ++----- tcg/optimize.c | 1 - 10 files changed, 8 insertions(+), 17 deletions(-)