| Message ID | 20200811124129.733043-1-mohammad.rasim96@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | kernel: add ar5523 driver | expand |
On 2020-08-11 14:41, mohammad rasim wrote: > The driver currently only support managed and monitor mode > > Signed-off-by: mohammad rasim <mohammad.rasim96@gmail.com> Are you planning on using this, or did you just add it because it's in the source tree? - Felix
On 8/11/20 3:53 PM, Felix Fietkau wrote: > On 2020-08-11 14:41, mohammad rasim wrote: >> The driver currently only support managed and monitor mode >> >> Signed-off-by: mohammad rasim <mohammad.rasim96@gmail.com> > Are you planning on using this, or did you just add it because it's in > the source tree? > > - Felix Yes I'm planning to use it. i know it's and old device but the one i have has a great sensitivity and is perfect for wifi penetrating and receiving very far APs.
Hi Mohammad, On Tue, Aug 11, 2020 at 03:41:29PM +0300, mohammad rasim wrote: > The driver currently only support managed and monitor mode > > Signed-off-by: mohammad rasim <mohammad.rasim96@gmail.com> > --- > package/kernel/mac80211/ath.mk | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/package/kernel/mac80211/ath.mk b/package/kernel/mac80211/ath.mk > index 352d192fa1..d63813d677 100644 > --- a/package/kernel/mac80211/ath.mk > +++ b/package/kernel/mac80211/ath.mk > @@ -1,6 +1,6 @@ > PKG_DRIVERS += \ > ath ath5k ath6kl ath6kl-sdio ath6kl-usb ath9k ath9k-common ath9k-htc ath10k \ > - carl9170 owl-loader > + carl9170 owl-loader ar5523 > > PKG_CONFIG_DEPENDS += \ > CONFIG_PACKAGE_ATH_DEBUG \ > @@ -67,6 +67,7 @@ config-$(call config_package,ath6kl-sdio) += ATH6KL_SDIO > config-$(call config_package,ath6kl-usb) += ATH6KL_USB > > config-$(call config_package,carl9170) += CARL9170 > +config-$(call config_package,ar5523) += AR5523 > > define KernelPackage/ath/config > if PACKAGE_kmod-ath > @@ -300,3 +301,11 @@ define KernelPackage/owl-loader/description > > This is necessary for devices like the Cisco Meraki Z1. > endef > + > +define KernelPackage/ar5523 > + $(call KernelPackage/mac80211/Default) > + TITLE:=Driver for Atheros AR5523 USB sticks > + DEPENDS:=@USB_SUPPORT +kmod-mac80211 +kmod-ath +kmod-usb-core +kmod-input-core +@DRIVER_11N_SUPPORT ^^^^^^^^^^^^^^^^^^^^^^ From what I understood ar5523 are 802.11a/b/g and hence do NOT support 11N. Correct me if I'm wrong...
Hi On 2020-08-11, Daniel Golle wrote: > Hi Mohammad, > > On Tue, Aug 11, 2020 at 03:41:29PM +0300, mohammad rasim wrote: > > The driver currently only support managed and monitor mode [...] > > +define KernelPackage/ar5523 > > + $(call KernelPackage/mac80211/Default) > > + TITLE:=Driver for Atheros AR5523 USB sticks > > + DEPENDS:=@USB_SUPPORT +kmod-mac80211 +kmod-ath +kmod-usb-core +kmod-input-core +@DRIVER_11N_SUPPORT > ^^^^^^^^^^^^^^^^^^^^^^ > From what I understood ar5523 are 802.11a/b/g and hence do NOT support > 11N. Correct me if I'm wrong... Correct, ar5523 is basically just a mips 4000 SOC with AR2112 (AR5005UG) or AR5112 (AR5005UX) wireless, it's a 802.11 a/b/g solution (technically Atheros Super-G/ Super-AG with up to 108 MBit/s) and doesn't support 802.11n, so +@DRIVER_11N_SUPPORT should be dropped. Regards Stefan Lippers-Hollmann
On 8/11/20 5:15 PM, Daniel Golle wrote: > Hi Mohammad, > > On Tue, Aug 11, 2020 at 03:41:29PM +0300, mohammad rasim wrote: >> The driver currently only support managed and monitor mode >> >> Signed-off-by: mohammad rasim <mohammad.rasim96@gmail.com> >> --- >> package/kernel/mac80211/ath.mk | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/package/kernel/mac80211/ath.mk b/package/kernel/mac80211/ath.mk >> index 352d192fa1..d63813d677 100644 >> --- a/package/kernel/mac80211/ath.mk >> +++ b/package/kernel/mac80211/ath.mk >> @@ -1,6 +1,6 @@ >> PKG_DRIVERS += \ >> ath ath5k ath6kl ath6kl-sdio ath6kl-usb ath9k ath9k-common ath9k-htc ath10k \ >> - carl9170 owl-loader >> + carl9170 owl-loader ar5523 >> >> PKG_CONFIG_DEPENDS += \ >> CONFIG_PACKAGE_ATH_DEBUG \ >> @@ -67,6 +67,7 @@ config-$(call config_package,ath6kl-sdio) += ATH6KL_SDIO >> config-$(call config_package,ath6kl-usb) += ATH6KL_USB >> >> config-$(call config_package,carl9170) += CARL9170 >> +config-$(call config_package,ar5523) += AR5523 >> >> define KernelPackage/ath/config >> if PACKAGE_kmod-ath >> @@ -300,3 +301,11 @@ define KernelPackage/owl-loader/description >> >> This is necessary for devices like the Cisco Meraki Z1. >> endef >> + >> +define KernelPackage/ar5523 >> + $(call KernelPackage/mac80211/Default) >> + TITLE:=Driver for Atheros AR5523 USB sticks >> + DEPENDS:=@USB_SUPPORT +kmod-mac80211 +kmod-ath +kmod-usb-core +kmod-input-core +@DRIVER_11N_SUPPORT > ^^^^^^^^^^^^^^^^^^^^^^ > From what I understood ar5523 are 802.11a/b/g and hence do NOT support > 11N. Correct me if I'm wrong... > You are right, that dependency was mistakenly left from where i copied the code (carl9170 driver) will remove it in v2. Regards
On 8/11/20 10:00 PM, Stefan Lippers-Hollmann wrote: > Hi > > On 2020-08-11, Daniel Golle wrote: >> Hi Mohammad, >> >> On Tue, Aug 11, 2020 at 03:41:29PM +0300, mohammad rasim wrote: >>> The driver currently only support managed and monitor mode > [...] >>> +define KernelPackage/ar5523 >>> + $(call KernelPackage/mac80211/Default) >>> + TITLE:=Driver for Atheros AR5523 USB sticks >>> + DEPENDS:=@USB_SUPPORT +kmod-mac80211 +kmod-ath +kmod-usb-core +kmod-input-core +@DRIVER_11N_SUPPORT >> ^^^^^^^^^^^^^^^^^^^^^^ >> From what I understood ar5523 are 802.11a/b/g and hence do NOT support >> 11N. Correct me if I'm wrong... > Correct, ar5523 is basically just a mips 4000 SOC with AR2112 (AR5005UG) > or AR5112 (AR5005UX) wireless, it's a 802.11 a/b/g solution (technically > Atheros Super-G/ Super-AG with up to 108 MBit/s) and doesn't support > 802.11n, so +@DRIVER_11N_SUPPORT should be dropped. > > Regards > Stefan Lippers-Hollmann Yes I will remove it in v2
diff --git a/package/kernel/mac80211/ath.mk b/package/kernel/mac80211/ath.mk index 352d192fa1..d63813d677 100644 --- a/package/kernel/mac80211/ath.mk +++ b/package/kernel/mac80211/ath.mk @@ -1,6 +1,6 @@ PKG_DRIVERS += \ ath ath5k ath6kl ath6kl-sdio ath6kl-usb ath9k ath9k-common ath9k-htc ath10k \ - carl9170 owl-loader + carl9170 owl-loader ar5523 PKG_CONFIG_DEPENDS += \ CONFIG_PACKAGE_ATH_DEBUG \ @@ -67,6 +67,7 @@ config-$(call config_package,ath6kl-sdio) += ATH6KL_SDIO config-$(call config_package,ath6kl-usb) += ATH6KL_USB config-$(call config_package,carl9170) += CARL9170 +config-$(call config_package,ar5523) += AR5523 define KernelPackage/ath/config if PACKAGE_kmod-ath @@ -300,3 +301,11 @@ define KernelPackage/owl-loader/description This is necessary for devices like the Cisco Meraki Z1. endef + +define KernelPackage/ar5523 + $(call KernelPackage/mac80211/Default) + TITLE:=Driver for Atheros AR5523 USB sticks + DEPENDS:=@USB_SUPPORT +kmod-mac80211 +kmod-ath +kmod-usb-core +kmod-input-core +@DRIVER_11N_SUPPORT + FILES:=$(PKG_BUILD_DIR)/drivers/net/wireless/ath/ar5523/ar5523.ko + AUTOLOAD:=$(call AutoProbe,ar5523) +endef
The driver currently only support managed and monitor mode Signed-off-by: mohammad rasim <mohammad.rasim96@gmail.com> --- package/kernel/mac80211/ath.mk | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)