| Message ID | 1306909447-19603-3-git-send-email-hs@denx.de |
|---|---|
| State | Accepted |
| Commit | f18714dd61331b48ab9dc0ef717d61f1441a0e17 |
| Headers | show |
Dear Heiko Schocher, In message <1306909447-19603-3-git-send-email-hs@denx.de> you wrote: > This include is needed, if this memory test is used "outside" > from post code, for example booting with nand_spl, and using > this memory test before copying u-boot code to RAM and jumping > to it. > > Signed-off-by: Heiko Schocher <hs@denx.de> > --- > include/post.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
Dear Heiko, In message <1306909447-19603-3-git-send-email-hs@denx.de> you wrote: > This include is needed, if this memory test is used "outside" > from post code, for example booting with nand_spl, and using > this memory test before copying u-boot code to RAM and jumping > to it. > > Signed-off-by: Heiko Schocher <hs@denx.de> > --- > include/post.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) This got applied as commit f18714d, but obviously this patch has not been tested before as it is breaking a ton of boards: ... Configuring for NETTA_ISDN - Board: NETTA, Options: NETTA_ISDN=1 include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2 make: *** [libpost.o] Error 2 ppc_6xx-size: 'u-boot': No such file Configuring for NETTA_ISDN_6412 - Board: NETTA, Options: NETTA_ISDN=1,NETTA_6412=1 include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2 make: *** [libpost.o] Error 2 ppc_6xx-size: 'u-boot': No such file Configuring for NETTA_ISDN_6412_SWAPHOOK - Board: NETTA, Options: NETTA_ISDN=1,NETTA_6412=1,NETTA_SWAPHOOK=1 include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2 make: *** [libpost.o] Error 2 ppc_6xx-size: 'u-boot': No such file Configuring for NETTA_ISDN_SWAPHOOK - Board: NETTA, Options: NETTA_ISDN=1,NETTA_SWAPHOOK=1 include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2 make: *** [libpost.o] Error 2 ppc_6xx-size: 'u-boot': No such file Configuring for NETTA_SWAPHOOK - Board: NETTA, Options: NETTA_SWAPHOOK=1 include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2 make: *** [libpost.o] Error 2 ppc_6xx-size: 'u-boot': No such file ... Configuring for KUP4X board... include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' make[2]: *** [lib_powerpc/asm.o] Error 1 make[2]: *** Waiting for unfinished jobs.... include/post.h: Assembler messages: include/post.h:190: Error: Unrecognized opcode: `int' ... Please fix!! Best regards, Wolfgang Denk
Dear Heiko, In message <20110726082651.F2CE3138EED4@gemini.denx.de> I wrote: > > In message <1306909447-19603-3-git-send-email-hs@denx.de> you wrote: > > This include is needed, if this memory test is used "outside" > > from post code, for example booting with nand_spl, and using > > this memory test before copying u-boot code to RAM and jumping > > to it. > > > > Signed-off-by: Heiko Schocher <hs@denx.de> > > --- > > include/post.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > This got applied as commit f18714d, but obviously this patch has not > been tested before as it is breaking a ton of boards: ... > Please fix!! To keep the number of non-compiling commits small and being able to apply more patches now I decided not to wait for your fix, but to revert the broken commit. Please resubmit the (fixed) patch. Best regards, Wolfgang Denk
Hello Wolfgang, Wolfgang Denk wrote: > Dear Heiko, > > In message <20110726082651.F2CE3138EED4@gemini.denx.de> I wrote: >> In message <1306909447-19603-3-git-send-email-hs@denx.de> you wrote: >>> This include is needed, if this memory test is used "outside" >>> from post code, for example booting with nand_spl, and using >>> this memory test before copying u-boot code to RAM and jumping >>> to it. >>> >>> Signed-off-by: Heiko Schocher <hs@denx.de> >>> --- >>> include/post.h | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >> This got applied as commit f18714d, but obviously this patch has not >> been tested before as it is breaking a ton of boards: > ... >> Please fix!! > > To keep the number of non-compiling commits small and being able to > apply more patches now I decided not to wait for your fix, but to > revert the broken commit. > > Please resubmit the (fixed) patch. Argh, did a "MAKEALL arm" only ... Sorry for the inconvinience! I look at this ASAP. bye, Heiko
diff --git a/include/post.h b/include/post.h index 519cef1..cda6e76 100644 --- a/include/post.h +++ b/include/post.h @@ -187,6 +187,7 @@ extern int post_hotkeys_pressed(void); #define CONFIG_SYS_POST_CODEC 0x00200000 #define CONFIG_SYS_POST_COPROC 0x00400000 +int memory_post_test(int flags); #endif /* CONFIG_POST */ #endif /* _POST_H */
This include is needed, if this memory test is used "outside" from post code, for example booting with nand_spl, and using this memory test before copying u-boot code to RAM and jumping to it. Signed-off-by: Heiko Schocher <hs@denx.de> --- include/post.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)