[v3,04/10] package/lua-messagepack: add support of Lua 5.4

Message ID	20200728132147.3155274-5-francois.perrad@gadz.org
State	Accepted
Headers	show Return-Path: <buildroot-bounces@busybox.net> From: Francois Perrad <fperrad@gmail.com> To: buildroot@busybox.net Date: Tue, 28 Jul 2020 15:21:41 +0200 Message-Id: <20200728132147.3155274-5-francois.perrad@gadz.org> In-Reply-To: <20200728132147.3155274-1-francois.perrad@gadz.org> References: <20200728132147.3155274-1-francois.perrad@gadz.org> MIME-Version: 1.0 Subject: [Buildroot] [PATCH v3 04/10] package/lua-messagepack: add support of Lua 5.4 Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net>
Series	Lua 5.4 \| expand [v3,00/10] Lua 5.4 [v3,01/10] package/luabitop: depends on lua 5.1 [v3,02/10] package/lua-compat53: depends on lua ABI 5.1 [v3,03/10] lua: add 5.4.0 version [v3,04/10] package/lua-messagepack: add support of Lua 5.4 [v3,05/10] package/easybus: temporarily disabled with Lua 5.4 [v3,06/10] package/lua-cqueues: temporarily disabled with Lua 5.4 [v3,07/10] package/lua-flu: temporarily disabled with Lua 5.4 [v3,08/10] package/lua-sdl2: temporarily disabled with Lua 5.4 [v3,09/10] package/luv: temporarily disabled with Lua 5.4 [v3,10/10] package/prosody: temporarily disabled with Lua 5.4

Message ID

20200728132147.3155274-5-francois.perrad@gadz.org

State

Accepted

Headers

From: Francois Perrad <fperrad@gmail.com>
To: buildroot@busybox.net
Date: Tue, 28 Jul 2020 15:21:41 +0200
Message-Id: <20200728132147.3155274-5-francois.perrad@gadz.org>
In-Reply-To: <20200728132147.3155274-1-francois.perrad@gadz.org>
References: <20200728132147.3155274-1-francois.perrad@gadz.org>
MIME-Version: 1.0
Subject: [Buildroot] [PATCH v3 04/10] package/lua-messagepack: add support
 of Lua 5.4
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: buildroot-bounces@busybox.net
Sender: "buildroot" <buildroot-bounces@busybox.net>

Series

Lua 5.4 | expand

Comments

James Hilliard July 29, 2020, 7:40 p.m. UTC | #1

On Wed, Jul 29, 2020 at 12:35 PM Francois Perrad <fperrad@gmail.com> wrote:
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/lua-messagepack/lua-messagepack.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/lua-messagepack/lua-messagepack.mk b/package/lua-messagepack/lua-messagepack.mk
> index f393a8d02..33d460b4f 100644
> --- a/package/lua-messagepack/lua-messagepack.mk
> +++ b/package/lua-messagepack/lua-messagepack.mk
> @@ -6,7 +6,7 @@
>
>  LUA_MESSAGEPACK_VERSION_UPSTREAM = 0.5.2
>  LUA_MESSAGEPACK_VERSION = $(LUA_MESSAGEPACK_VERSION_UPSTREAM)-1
> -ifeq ($(BR2_PACKAGE_LUA_5_3),y)
> +ifeq ($(BR2_PACKAGE_LUA_5_3)$(BR2_PACKAGE_LUA_5_4),y)
Might make sense to add/use some helpers for these use cases like:
BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION_AT_LEAST_5_3
>  LUA_MESSAGEPACK_NAME_UPSTREAM = lua-MessagePack-lua53
>  else
>  LUA_MESSAGEPACK_NAME_UPSTREAM = lua-MessagePack
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Francois Perrad July 30, 2020, 5:29 p.m. UTC | #2

Le mer. 29 juil. 2020 à 21:40, James Hilliard <james.hilliard1@gmail.com> a
écrit :

> On Wed, Jul 29, 2020 at 12:35 PM Francois Perrad <fperrad@gmail.com>
> wrote:
> >
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> > ---
> >  package/lua-messagepack/lua-messagepack.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/lua-messagepack/lua-messagepack.mk
> b/package/lua-messagepack/lua-messagepack.mk
> > index f393a8d02..33d460b4f 100644
> > --- a/package/lua-messagepack/lua-messagepack.mk
> > +++ b/package/lua-messagepack/lua-messagepack.mk
> > @@ -6,7 +6,7 @@
> >
> >  LUA_MESSAGEPACK_VERSION_UPSTREAM = 0.5.2
> >  LUA_MESSAGEPACK_VERSION = $(LUA_MESSAGEPACK_VERSION_UPSTREAM)-1
> > -ifeq ($(BR2_PACKAGE_LUA_5_3),y)
> > +ifeq ($(BR2_PACKAGE_LUA_5_3)$(BR2_PACKAGE_LUA_5_4),y)
> Might make sense to add/use some helpers for these use cases like:
> BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION_AT_LEAST_5_3
>

There is only one use case, so overkill.
Lua is not gcc or Linux.

François


> >  LUA_MESSAGEPACK_NAME_UPSTREAM = lua-MessagePack-lua53
> >  else
> >  LUA_MESSAGEPACK_NAME_UPSTREAM = lua-MessagePack
> > --
> > 2.25.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>

diff --git a/package/lua-messagepack/lua-messagepack.mk b/package/lua-messagepack/lua-messagepack.mk
index f393a8d02..33d460b4f 100644
--- a/package/lua-messagepack/lua-messagepack.mk
+++ b/package/lua-messagepack/lua-messagepack.mk
@@ -6,7 +6,7 @@ 
 
 LUA_MESSAGEPACK_VERSION_UPSTREAM = 0.5.2
 LUA_MESSAGEPACK_VERSION = $(LUA_MESSAGEPACK_VERSION_UPSTREAM)-1
-ifeq ($(BR2_PACKAGE_LUA_5_3),y)
+ifeq ($(BR2_PACKAGE_LUA_5_3)$(BR2_PACKAGE_LUA_5_4),y)
 LUA_MESSAGEPACK_NAME_UPSTREAM = lua-MessagePack-lua53
 else
 LUA_MESSAGEPACK_NAME_UPSTREAM = lua-MessagePack

[v3,04/10] package/lua-messagepack: add support of Lua 5.4

Commit Message

Comments

Patch