| Message ID | 20200726022901.295552-2-aduskett@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | libwebsockets fixup | expand |
On Sat, 25 Jul 2020 19:28:57 -0700 aduskett@gmail.com wrote: > From: Adam Duskett <Aduskett@gmail.com> > > Six years ago, commit b6b5bb518d28850e024b90db1129b7f86e9d416c added the MMU > dependency for the libwebsockets package. However, according to the git > history of the CMakeLists.txt file, libwebsockets has supported the vfork > function for at least the last five years. > > After testing with the qemu_arm_versatile_nommu_defconfig and the > br-arm-cortex-m4-full.config file, no errors occurred when building > libwebsockets without MMU support. > > Remove the dependency; it is no longer necessary. > > Signed-off-by: Adam Duskett <Aduskett@gmail.com> > --- > package/libwebsockets/Config.in | 1 - > 1 file changed, 1 deletion(-) You forgot to have a look at the reverse dependencies of libwebsockets, so I did that and updated the places where BR2_USE_MMU could be dropped, in ttyd and janus-gateway. Applied with those changes. Thanks! Thomas
>>>>> "aduskett" == aduskett <aduskett@gmail.com> writes: > From: Adam Duskett <Aduskett@gmail.com> > Six years ago, commit b6b5bb518d28850e024b90db1129b7f86e9d416c added the MMU > dependency for the libwebsockets package. However, according to the git > history of the CMakeLists.txt file, libwebsockets has supported the vfork > function for at least the last five years. > After testing with the qemu_arm_versatile_nommu_defconfig and the > br-arm-cortex-m4-full.config file, no errors occurred when building > libwebsockets without MMU support. > Remove the dependency; it is no longer necessary. > Signed-off-by: Adam Duskett <Aduskett@gmail.com> Committed to 2020.02.x and 2020.05.x, thanks.
diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in index 2b350bf389..1d927bb4ea 100644 --- a/package/libwebsockets/Config.in +++ b/package/libwebsockets/Config.in @@ -1,6 +1,5 @@ config BR2_PACKAGE_LIBWEBSOCKETS bool "libwebsockets" - depends on BR2_USE_MMU # fork() select BR2_PACKAGE_ZLIB help Libwebsockets is a lightweight pure C library built to use