| Message ID | 1595254921-26050-1-git-send-email-Anson.Huang@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [V3,1/3] reset: imx7: Support module build | expand |
On Mon, 2020-07-20 at 22:21 +0800, Anson Huang wrote: > Use module_platform_driver(), add module device table, author, > description and license to support module build, and > CONFIG_RESET_IMX7 is changed to default 'y' ONLY for i.MX7D, > other platforms need to select it in defconfig. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V2: > - use module_platform_driver() instead of builtin_platform_driver(). Thank you, applied to reset/next. regards Philipp
On Fri, Jul 24, 2020 at 10:03:11AM +0200, Philipp Zabel wrote: > On Mon, 2020-07-20 at 22:21 +0800, Anson Huang wrote: > > Use module_platform_driver(), add module device table, author, > > description and license to support module build, and > > CONFIG_RESET_IMX7 is changed to default 'y' ONLY for i.MX7D, > > other platforms need to select it in defconfig. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > Changes since V2: > > - use module_platform_driver() instead of builtin_platform_driver(). > > Thank you, applied to reset/next. I think you should pick up patch (3) as well please if PCI_IMX6 maintainers ACK it - merging just patch(1) will trigger regressions AFAICS. Lorenzo
On Tue, 2020-07-28 at 11:53 +0100, Lorenzo Pieralisi wrote: > On Fri, Jul 24, 2020 at 10:03:11AM +0200, Philipp Zabel wrote: > > On Mon, 2020-07-20 at 22:21 +0800, Anson Huang wrote: > > > Use module_platform_driver(), add module device table, author, > > > description and license to support module build, and > > > CONFIG_RESET_IMX7 is changed to default 'y' ONLY for i.MX7D, > > > other platforms need to select it in defconfig. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > --- > > > Changes since V2: > > > - use module_platform_driver() instead of builtin_platform_driver(). > > > > Thank you, applied to reset/next. > > I think you should pick up patch (3) as well please if PCI_IMX6 > maintainers ACK it - merging just patch(1) will trigger regressions > AFAICS. Thank you for raising this, I'll put these patches on hold until the PCI_IMX6 issue is resolved. regards Philipp
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index d9efbfd..19f9773 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -65,9 +65,10 @@ config RESET_HSDK This enables the reset controller driver for HSDK board. config RESET_IMX7 - bool "i.MX7/8 Reset Driver" if COMPILE_TEST + tristate "i.MX7/8 Reset Driver" depends on HAS_IOMEM - default SOC_IMX7D || (ARM64 && ARCH_MXC) + depends on SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST + default y if SOC_IMX7D select MFD_SYSCON help This enables the reset controller driver for i.MX7 SoCs. diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c index d170fe6..9832033 100644 --- a/drivers/reset/reset-imx7.c +++ b/drivers/reset/reset-imx7.c @@ -8,7 +8,7 @@ */ #include <linux/mfd/syscon.h> -#include <linux/mod_devicetable.h> +#include <linux/module.h> #include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/reset-controller.h> @@ -386,6 +386,7 @@ static const struct of_device_id imx7_reset_dt_ids[] = { { .compatible = "fsl,imx8mp-src", .data = &variant_imx8mp }, { /* sentinel */ }, }; +MODULE_DEVICE_TABLE(of, imx7_reset_dt_ids); static struct platform_driver imx7_reset_driver = { .probe = imx7_reset_probe, @@ -394,4 +395,8 @@ static struct platform_driver imx7_reset_driver = { .of_match_table = imx7_reset_dt_ids, }, }; -builtin_platform_driver(imx7_reset_driver); +module_platform_driver(imx7_reset_driver); + +MODULE_AUTHOR("Andrey Smirnov <andrew.smirnov@gmail.com>"); +MODULE_DESCRIPTION("NXP i.MX7 reset driver"); +MODULE_LICENSE("GPL v2");
Use module_platform_driver(), add module device table, author, description and license to support module build, and CONFIG_RESET_IMX7 is changed to default 'y' ONLY for i.MX7D, other platforms need to select it in defconfig. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V2: - use module_platform_driver() instead of builtin_platform_driver(). --- drivers/reset/Kconfig | 5 +++-- drivers/reset/reset-imx7.c | 9 +++++++-- 2 files changed, 10 insertions(+), 4 deletions(-)