| Message ID | 20200716211517.GA17174@embeddedor |
|---|---|
| State | New |
| Headers | show |
| Series | [next] PCI: rcar-gen2: Use fallthrough pseudo-keyword | expand |
Hi Gustavo, Thanks for your patch! On Thu, Jul 16, 2020 at 11:11 PM Gustavo A. R. Silva <gustavoars@kernel.org> wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. Which unnecessary marking is being removed? I don't see any. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> For the actual patch contents: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Geert, On 7/17/20 02:18, Geert Uytterhoeven wrote: > Hi Gustavo, > > Thanks for your patch! > > On Thu, Jul 16, 2020 at 11:11 PM Gustavo A. R. Silva > <gustavoars@kernel.org> wrote: >> Replace the existing /* fall through */ comments and its variants with >> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary >> fall-through markings when it is the case. > > Which unnecessary marking is being removed? > I don't see any. > There is none. I will remove those lines and send v2 with a URL to the proper documentation for Linux v5.7 instead of 'lastest', see: https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through I'll add your Reviewed-by tag. :) >> >> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through >> >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > For the actual patch contents: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Thanks! -- Gustavo
diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c index 326171cb1a97..2ec7093a7588 100644 --- a/drivers/pci/controller/pci-rcar-gen2.c +++ b/drivers/pci/controller/pci-rcar-gen2.c @@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys) pr_warn("unknown window size %ld - defaulting to 256M\n", priv->window_size); priv->window_size = SZ_256M; - /* fall-through */ + fallthrough; case SZ_256M: val |= RCAR_USBCTR_PCIAHB_WIN1_256M; break;
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/pci/controller/pci-rcar-gen2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)