diff mbox series

hostapd: Fix error message for radius_accept_attr config option

Message ID 20200622110558.12068-1-pali@kernel.org
State Changes Requested
Headers show
Series hostapd: Fix error message for radius_accept_attr config option | expand

Commit Message

Pali Rohár June 22, 2020, 11:05 a.m. UTC 
Error message contained wrong config option.
---
 hostapd/config_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pali Rohár July 20, 2020, 7:40 a.m. UTC | #1 
Hello! I would like to remind this simple patch.

On Monday 22 June 2020 13:05:58 Pali Rohár wrote:
> Error message contained wrong config option.
> ---
>  hostapd/config_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hostapd/config_file.c b/hostapd/config_file.c
> index 1861b5203..06925de89 100644
> --- a/hostapd/config_file.c
> +++ b/hostapd/config_file.c
> @@ -340,9 +340,9 @@ static int hostapd_config_read_eap_user(const char *fname,
>  		if (user && os_strncmp(buf, "radius_accept_attr=", 19) == 0) {
>  			struct hostapd_radius_attr *attr, *a;
>  			attr = hostapd_parse_radius_attr(buf + 19);
>  			if (attr == NULL) {
> -				wpa_printf(MSG_ERROR, "Invalid radius_auth_req_attr: %s",
> +				wpa_printf(MSG_ERROR, "Invalid radius_accept_attr: %s",
>  					   buf + 19);
>  				user = NULL; /* already in the BSS list */
>  				goto failed;
>  			}
> -- 
> 2.20.1
>
Pali Rohár Aug. 11, 2020, 8:34 a.m. UTC | #2 
Hello! I would like to remind this patch.

On Monday 22 June 2020 13:05:58 Pali Rohár wrote:
> Error message contained wrong config option.
> ---
>  hostapd/config_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hostapd/config_file.c b/hostapd/config_file.c
> index 1861b5203..06925de89 100644
> --- a/hostapd/config_file.c
> +++ b/hostapd/config_file.c
> @@ -340,9 +340,9 @@ static int hostapd_config_read_eap_user(const char *fname,
>  		if (user && os_strncmp(buf, "radius_accept_attr=", 19) == 0) {
>  			struct hostapd_radius_attr *attr, *a;
>  			attr = hostapd_parse_radius_attr(buf + 19);
>  			if (attr == NULL) {
> -				wpa_printf(MSG_ERROR, "Invalid radius_auth_req_attr: %s",
> +				wpa_printf(MSG_ERROR, "Invalid radius_accept_attr: %s",
>  					   buf + 19);
>  				user = NULL; /* already in the BSS list */
>  				goto failed;
>  			}
> -- 
> 2.20.1
>
Pali Rohár Oct. 7, 2020, 8:26 a.m. UTC | #3 
Hello! Could you please review this patch?

On Monday 22 June 2020 13:05:58 Pali Rohár wrote:
> Error message contained wrong config option.
> ---
>  hostapd/config_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hostapd/config_file.c b/hostapd/config_file.c
> index 1861b5203..06925de89 100644
> --- a/hostapd/config_file.c
> +++ b/hostapd/config_file.c
> @@ -340,9 +340,9 @@ static int hostapd_config_read_eap_user(const char *fname,
>  		if (user && os_strncmp(buf, "radius_accept_attr=", 19) == 0) {
>  			struct hostapd_radius_attr *attr, *a;
>  			attr = hostapd_parse_radius_attr(buf + 19);
>  			if (attr == NULL) {
> -				wpa_printf(MSG_ERROR, "Invalid radius_auth_req_attr: %s",
> +				wpa_printf(MSG_ERROR, "Invalid radius_accept_attr: %s",
>  					   buf + 19);
>  				user = NULL; /* already in the BSS list */
>  				goto failed;
>  			}
> -- 
> 2.20.1
>
Jouni Malinen Oct. 10, 2020, 5:29 p.m. UTC | #4 
On Mon, Jun 22, 2020 at 01:05:58PM +0200, Pali Rohár wrote:
> Error message contained wrong config option.
> ---
>  hostapd/config_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This is missing the needed Signed-off-by: line in the commit message.
Could you please resubmit this with that line added as described in the
top level CONTRIBUTIONS file?
diff mbox series

Patch

diff --git a/hostapd/config_file.c b/hostapd/config_file.c
index 1861b5203..06925de89 100644
--- a/hostapd/config_file.c
+++ b/hostapd/config_file.c
@@ -340,9 +340,9 @@  static int hostapd_config_read_eap_user(const char *fname,
 		if (user && os_strncmp(buf, "radius_accept_attr=", 19) == 0) {
 			struct hostapd_radius_attr *attr, *a;
 			attr = hostapd_parse_radius_attr(buf + 19);
 			if (attr == NULL) {
-				wpa_printf(MSG_ERROR, "Invalid radius_auth_req_attr: %s",
+				wpa_printf(MSG_ERROR, "Invalid radius_accept_attr: %s",
 					   buf + 19);
 				user = NULL; /* already in the BSS list */
 				goto failed;
 			}