mbox series

[v1,0/4] Add Nvidia Tegra GPC-DMA driver

Message ID 1595226856-19241-1-git-send-email-rgumasta@nvidia.com
Headers show
Series Add Nvidia Tegra GPC-DMA driver | expand

Message

Rajesh Gumasta July 20, 2020, 6:34 a.m. UTC
Add support for Nvida Tegra general purpose DMA driver for
Tegra186 and Tegra194 platform.

Patch 1: Add dt-binding document for Tegra GPCDMA driver
Patch 2: Add Tegra GPCDMA driver
Patch 3: Enable Tegra GPCDMA as module
Patch 4: Add GPCDMA DT node for Tegra186 and Tegra194

Rajesh Gumasta (4):
  dt-bindings: dma: Add DT binding document
  dma: tegra: Adding Tegra GPC DMA controller driver
  arm64: configs: enable tegra gpc dma
  arm64: tegra: Add GPCDMA node in dt

 .../bindings/dma/nvidia,tegra-gpc-dma.yaml         |   99 ++
 arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi     |    4 +
 arch/arm64/boot/dts/nvidia/tegra186.dtsi           |   46 +
 arch/arm64/boot/dts/nvidia/tegra194.dtsi           |   44 +
 arch/arm64/configs/defconfig                       |    1 +
 drivers/dma/Kconfig                                |   12 +
 drivers/dma/Makefile                               |    1 +
 drivers/dma/tegra-gpc-dma.c                        | 1512 ++++++++++++++++++++
 8 files changed, 1719 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dma/nvidia,tegra-gpc-dma.yaml
 create mode 100644 drivers/dma/tegra-gpc-dma.c

Comments

Thierry Reding July 20, 2020, 9:25 a.m. UTC | #1
On Mon, Jul 20, 2020 at 12:04:12PM +0530, Rajesh Gumasta wrote:
> Add support for Nvida Tegra general purpose DMA driver for
> Tegra186 and Tegra194 platform.
> 
> Patch 1: Add dt-binding document for Tegra GPCDMA driver
> Patch 2: Add Tegra GPCDMA driver
> Patch 3: Enable Tegra GPCDMA as module
> Patch 4: Add GPCDMA DT node for Tegra186 and Tegra194
> 
> Rajesh Gumasta (4):
>   dt-bindings: dma: Add DT binding document
>   dma: tegra: Adding Tegra GPC DMA controller driver
>   arm64: configs: enable tegra gpc dma
>   arm64: tegra: Add GPCDMA node in dt
> 
>  .../bindings/dma/nvidia,tegra-gpc-dma.yaml         |   99 ++
>  arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi     |    4 +
>  arch/arm64/boot/dts/nvidia/tegra186.dtsi           |   46 +
>  arch/arm64/boot/dts/nvidia/tegra194.dtsi           |   44 +
>  arch/arm64/configs/defconfig                       |    1 +
>  drivers/dma/Kconfig                                |   12 +
>  drivers/dma/Makefile                               |    1 +
>  drivers/dma/tegra-gpc-dma.c                        | 1512 ++++++++++++++++++++
>  8 files changed, 1719 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/nvidia,tegra-gpc-dma.yaml
>  create mode 100644 drivers/dma/tegra-gpc-dma.c

Hi Rajesh,

can you provide instructions on how to test that this driver does what
it's supposed to? I could probably figure out how to run this with the
kernel's built-in dmatest module, but if you could provide a set of
parameters that you've used or other instructions on how to validate
this it would greatly help.

Thanks,
Thierry

> 
> -- 
> 2.7.4
>
Rajesh Gumasta July 20, 2020, 10 a.m. UTC | #2
> -----Original Message-----
> From: Thierry Reding <thierry.reding@gmail.com>
> Sent: Monday, July 20, 2020 2:56 PM
> To: Rajesh Gumasta <rgumasta@nvidia.com>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>; Jonathan Hunter
> <jonathanh@nvidia.com>; vkoul@kernel.org; dan.j.williams@intel.com;
> p.zabel@pengutronix.de; dmaengine@vger.kernel.org; linux-
> tegra@vger.kernel.org; linux-kernel@vger.kernel.org; Krishna Yarlagadda
> <kyarlagadda@nvidia.com>
> Subject: Re: [Patch v1 0/4] Add Nvidia Tegra GPC-DMA driver
> 
> On Mon, Jul 20, 2020 at 12:04:12PM +0530, Rajesh Gumasta wrote:
> > Add support for Nvida Tegra general purpose DMA driver for
> > Tegra186 and Tegra194 platform.
> >
> > Patch 1: Add dt-binding document for Tegra GPCDMA driver Patch 2: Add
> > Tegra GPCDMA driver Patch 3: Enable Tegra GPCDMA as module Patch 4:
> > Add GPCDMA DT node for Tegra186 and Tegra194
> >
> > Rajesh Gumasta (4):
> >   dt-bindings: dma: Add DT binding document
> >   dma: tegra: Adding Tegra GPC DMA controller driver
> >   arm64: configs: enable tegra gpc dma
> >   arm64: tegra: Add GPCDMA node in dt
> >
> >  .../bindings/dma/nvidia,tegra-gpc-dma.yaml         |   99 ++
> >  arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi     |    4 +
> >  arch/arm64/boot/dts/nvidia/tegra186.dtsi           |   46 +
> >  arch/arm64/boot/dts/nvidia/tegra194.dtsi           |   44 +
> >  arch/arm64/configs/defconfig                       |    1 +
> >  drivers/dma/Kconfig                                |   12 +
> >  drivers/dma/Makefile                               |    1 +
> >  drivers/dma/tegra-gpc-dma.c                        | 1512 ++++++++++++++++++++
> >  8 files changed, 1719 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/dma/nvidia,tegra-gpc-dma.yaml
> >  create mode 100644 drivers/dma/tegra-gpc-dma.c
> 
> Hi Rajesh,
> 
> can you provide instructions on how to test that this driver does what it's
> supposed to? I could probably figure out how to run this with the kernel's built-in
> dmatest module, but if you could provide a set of parameters that you've used
> or other instructions on how to validate this it would greatly help.
> 

I have used below parameter setting with kernel's built-in dmatest module to test mem to mem copy  
cd /sys/module/dmatest/parameters 
echo 50000 > iterations
echo dma0chan20 > channel
echo 1 > run

> Thanks,
> Thierry
> 
> >
> > --
> > 2.7.4
> >

Thanks
Rajesh Gumasta