| Message ID | 20200706175353.16404-13-michael@walle.cc |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add support for Kontron sl28cpld | expand |
Hi! > Now that we have support for GPIO lines of the SMARC connector, enable > LED support on the KBox A-230-LS. There are two LEDs without fixed > functions, one is yellow and one is green. Unfortunately, it is just one > multi-color LED, thus while it is possible to enable both at the same > time it is hard to tell the difference between "yellow only" and "yellow > and green". > + user_yellow { > + label = "s1914:yellow:user"; > + gpios = <&sl28cpld_gpio0 0 0>; > + }; > + > + user_green { > + label = "s1914:green:user"; > + gpios = <&sl28cpld_gpio1 3 0>; > + }; This is not suitable label for such LEDs... there's zero chance userland will know what to do with these. Do they have some kind of "usual" function? Best regards, Pavel
Hi Pavel, Am 2020-07-17 10:36, schrieb Pavel Machek: > Hi! > >> Now that we have support for GPIO lines of the SMARC connector, enable >> LED support on the KBox A-230-LS. There are two LEDs without fixed >> functions, one is yellow and one is green. Unfortunately, it is just >> one >> multi-color LED, thus while it is possible to enable both at the same >> time it is hard to tell the difference between "yellow only" and >> "yellow >> and green". > >> + user_yellow { >> + label = "s1914:yellow:user"; >> + gpios = <&sl28cpld_gpio0 0 0>; >> + }; >> + >> + user_green { >> + label = "s1914:green:user"; >> + gpios = <&sl28cpld_gpio1 3 0>; >> + }; > > This is not suitable label for such LEDs... there's zero chance > userland will > know what to do with these. > > Do they have some kind of "usual" function? Unfortunately, they do not. I guess the green one could be something like "application ready" and the yellow one could be an indication that some fault occurred. Do you have any suggestions? -michael
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts index 4b4cc6a1573d..49cf4fe05c80 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts @@ -16,6 +16,20 @@ model = "Kontron KBox A-230-LS"; compatible = "kontron,kbox-a-230-ls", "kontron,sl28-var4", "kontron,sl28", "fsl,ls1028a"; + + leds { + compatible = "gpio-leds"; + + user_yellow { + label = "s1914:yellow:user"; + gpios = <&sl28cpld_gpio0 0 0>; + }; + + user_green { + label = "s1914:green:user"; + gpios = <&sl28cpld_gpio1 3 0>; + }; + }; }; &enetc_mdio_pf3 {
Now that we have support for GPIO lines of the SMARC connector, enable LED support on the KBox A-230-LS. There are two LEDs without fixed functions, one is yellow and one is green. Unfortunately, it is just one multi-color LED, thus while it is possible to enable both at the same time it is hard to tell the difference between "yellow only" and "yellow and green". Signed-off-by: Michael Walle <michael@walle.cc> --- Changes since v4: - none Changes since v3: - see cover letter .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)