| Message ID | 20200712163422.1162187-4-romain.naour@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] package/edk2-aarch64-bin: new package | expand |
On Sun, 12 Jul 2020 18:34:22 +0200 Romain Naour <romain.naour@gmail.com> wrote: > To test memory hotplug [1], add -m 1G,slots=3,maxmem=4G to the qemu command > line, boot the system and enter the following command in the Qemu monitor > to add another 1GB to the guest: > (use ctrl+a c to switch from the serial port and Qemu monitor): > > (qemu) object_add memory-backend-ram,id=mem1,size=1G > (qemu) device_add pc-dimm,id=dimm1,memdev=mem1 > > [1] https://git.qemu.org/?p=qemu.git;a=blob;f=docs/memory-hotplug.txt;h=6aa5e17e26090f619787de7b71888093fb9d0117;hb=fdd76fecdde1ad444ff4deb7f1c4f7e4a1ef97d6#l9 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> Is this really something we want to enable in a defconfig ? It feels like a very advanced/specific feature, not really relevant for a demo/test defconfig IMO. Thomas
Hi Thomas, Le 12/07/2020 à 21:27, Thomas Petazzoni a écrit : > On Sun, 12 Jul 2020 18:34:22 +0200 > Romain Naour <romain.naour@gmail.com> wrote: > >> To test memory hotplug [1], add -m 1G,slots=3,maxmem=4G to the qemu command >> line, boot the system and enter the following command in the Qemu monitor >> to add another 1GB to the guest: >> (use ctrl+a c to switch from the serial port and Qemu monitor): >> >> (qemu) object_add memory-backend-ram,id=mem1,size=1G >> (qemu) device_add pc-dimm,id=dimm1,memdev=mem1 >> >> [1] https://git.qemu.org/?p=qemu.git;a=blob;f=docs/memory-hotplug.txt;h=6aa5e17e26090f619787de7b71888093fb9d0117;hb=fdd76fecdde1ad444ff4deb7f1c4f7e4a1ef97d6#l9 >> >> Signed-off-by: Romain Naour <romain.naour@gmail.com> > > Is this really something we want to enable in a defconfig ? It feels > like a very advanced/specific feature, not really relevant for a > demo/test defconfig IMO. We just the required kernel options need for memory hot-plug, the Qemu command line in the readme.txt is keep as is. Best regards, Romain > > Thomas >
diff --git a/board/qemu/aarch64-virt/linux.config b/board/qemu/aarch64-virt/linux.config index 657acaf04f..b81d78349b 100644 --- a/board/qemu/aarch64-virt/linux.config +++ b/board/qemu/aarch64-virt/linux.config @@ -10,10 +10,13 @@ CONFIG_COMPAT=y CONFIG_FW_CFG_SYSFS=y CONFIG_FW_CFG_SYSFS_CMDLINE=y CONFIG_ACPI=y +CONFIG_ACPI_HOTPLUG_MEMORY=y CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y CONFIG_BLK_DEV_BSGLIB=y CONFIG_BINFMT_MISC=y +CONFIG_MEMORY_HOTPLUG=y +CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=y CONFIG_TRANSPARENT_HUGEPAGE=y CONFIG_NET=y CONFIG_PACKET=y @@ -27,6 +30,8 @@ CONFIG_BRIDGE=m CONFIG_NET_SCHED=y CONFIG_VSOCKETS=y CONFIG_PCI=y +CONFIG_HOTPLUG_PCI=y +CONFIG_HOTPLUG_PCI_ACPI=y CONFIG_PCI_HOST_GENERIC=y CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y
To test memory hotplug [1], add -m 1G,slots=3,maxmem=4G to the qemu command line, boot the system and enter the following command in the Qemu monitor to add another 1GB to the guest: (use ctrl+a c to switch from the serial port and Qemu monitor): (qemu) object_add memory-backend-ram,id=mem1,size=1G (qemu) device_add pc-dimm,id=dimm1,memdev=mem1 [1] https://git.qemu.org/?p=qemu.git;a=blob;f=docs/memory-hotplug.txt;h=6aa5e17e26090f619787de7b71888093fb9d0117;hb=fdd76fecdde1ad444ff4deb7f1c4f7e4a1ef97d6#l9 Signed-off-by: Romain Naour <romain.naour@gmail.com> --- board/qemu/aarch64-virt/linux.config | 5 +++++ 1 file changed, 5 insertions(+)