| Message ID | 20200703181719.3747072-1-songliubraving@fb.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf-next] selftests/bpf: fix compilation error of bpf_iter_task_stack.c | expand |
On 7/3/20 8:17 PM, Song Liu wrote: > selftests/bpf shows compilation error as > > libbpf: invalid relo for 'entries' in special section 0xfff2; forgot to > initialize global var?.. > > Fix it by initializing 'entries' to zeros. > > Fixes: c7568114bc56 ("selftests/bpf: Add bpf_iter test with bpf_get_task_stack()") > Reported-by: Jesper Dangaard Brouer <brouer@redhat.com> > Signed-off-by: Song Liu <songliubraving@fb.com> Applied, thanks!
diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_task_stack.c b/tools/testing/selftests/bpf/progs/bpf_iter_task_stack.c index e40d32a2ed93d..65899cc71d535 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter_task_stack.c +++ b/tools/testing/selftests/bpf/progs/bpf_iter_task_stack.c @@ -7,7 +7,7 @@ char _license[] SEC("license") = "GPL"; #define MAX_STACK_TRACE_DEPTH 64 -unsigned long entries[MAX_STACK_TRACE_DEPTH]; +unsigned long entries[MAX_STACK_TRACE_DEPTH] = {0}; #define SIZE_OF_ULONG (sizeof(unsigned long)) SEC("iter/task")
selftests/bpf shows compilation error as libbpf: invalid relo for 'entries' in special section 0xfff2; forgot to initialize global var?.. Fix it by initializing 'entries' to zeros. Fixes: c7568114bc56 ("selftests/bpf: Add bpf_iter test with bpf_get_task_stack()") Reported-by: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: Song Liu <songliubraving@fb.com> --- tools/testing/selftests/bpf/progs/bpf_iter_task_stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)