| Message ID | 20200626051650.495-1-Takahiro.Kuwano@cypress.com |
|---|---|
| State | Accepted |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | mtd: spi-nor: spansion: Remove s70fl01gs from flash_info | expand |
On 6/26/20 8:16 AM, kuwano.takahiro@gmail.com wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > From: Takahiro Kuwano <Takahiro.Kuwano@cypress.com> > > The s70fl01gs is a dual die stack of two s25fl512s die with dedicated chip > select pins to each. Tested with the device and confirmed that is working > as two s25fl512s devices. The current device ID in the flash_info table Right, the datasheet specifies too that the S70FS01GS device is a dual die stack of two FS512S die. > matches with s70fs01gs which does not work with current MTD. s70fs01gs is not correctly supported indeed, but the lower half of it (first s25fl512s die) should work. Can't you correctly read/erase/write on the lower half of the s70fs01gs flash with the current code? Cheers, ta
On 7/3/20 9:20 PM, Tudor.Ambarus@microchip.com wrote: > On 6/26/20 8:16 AM, kuwano.takahiro@gmail.com wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> From: Takahiro Kuwano <Takahiro.Kuwano@cypress.com> >> >> The s70fl01gs is a dual die stack of two s25fl512s die with dedicated chip >> select pins to each. Tested with the device and confirmed that is working >> as two s25fl512s devices. The current device ID in the flash_info table > > Right, the datasheet specifies too that the S70FS01GS device is a dual die > stack of two FS512S die. > >> matches with s70fs01gs which does not work with current MTD. > > s70fs01gs is not correctly supported indeed, but the lower half of it > (first s25fl512s die) should work. Can't you correctly read/erase/write > on the lower half of the s70fs01gs flash with the current code? No, because the S70FS01GS does not support RDSR(05h) which is critical for erase/write. The S70FS01GS is a dual die stack with one chip select. Accessing to the registers requires RDAR(65h)/WRAR(71h) designating die and register address. Best Regards, Takahiro
On Fri, 26 Jun 2020 14:16:50 +0900, kuwano.takahiro@gmail.com wrote: > The s70fl01gs is a dual die stack of two s25fl512s die with dedicated chip > select pins to each. Tested with the device and confirmed that is working > as two s25fl512s devices. The current device ID in the flash_info table > matches with s70fs01gs which does not work with current MTD. Applied to spi-nor/next, thanks! [1/1] mtd: spi-nor: spansion: Remove s70fl01gs from flash_info https://git.kernel.org/mtd/c/8c8f97573eb3 Best regards,
diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c index e550cd5c9d3a..953df1c488ec 100644 --- a/drivers/mtd/spi-nor/spansion.c +++ b/drivers/mtd/spi-nor/spansion.c @@ -64,7 +64,6 @@ static const struct flash_info spansion_parts[] = { { "s25fs512s", INFO6(0x010220, 0x4d0081, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) .fixups = &s25fs_s_fixups, }, - { "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) }, { "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) }, { "s25sl12801", INFO(0x012018, 0x0301, 64 * 1024, 256, 0) }, { "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024, 64,