mbox series

[v2,00/11] xive/p9: various small cleanups

Message ID 20200612113732.374240-1-clg@kaod.org
Headers show
Series xive/p9: various small cleanups | expand

Message

Cédric Le Goater June 12, 2020, 11:37 a.m. UTC 
Hello,

Here are cleanups which try to deobfuscate some magic values used in
the driver and add documentation in the commit logs. The only
significant change is on the size of the VP space which now depends on
the number of EQ descriptors. We have 1M of these and we use 8
priorities per VP. Therefore, our VP space should be limited to 128k.

Tested on a witherspoon with 2048 KVM guests each with 4 vCPUS.

Thanks,

C.

Changes since v1:

 - rephrased comment on the GIRQ
 - used sizeof() in more places

Cédric Le Goater (11):
  xive/p9: Introduce XIVE_INT_ORDER
  xive/p9: Clarify the global IRQ number encoding
  xive/p9: Introduce XIVE_ESB_SHIFT
  xive/p9: Introduce XIVE_EQ_ORDER
  xive/p9: Clarify the escalation IRQ encoding
  xive/p9: Introduce XIVE_EQ_SHIFT
  xive/p9: Use sizeof() instead of hardcoded values
  xive/p9: Clarify indirect table allocation
  xive/p9: Force 64K page size on the IC and TM BARs
  xive/p9: Modify the size of the VP space
  xive/p9: Introduce definitions for VP ids of HW threads

 hw/xive.c | 208 ++++++++++++++++++++++++++++++------------------------
 1 file changed, 117 insertions(+), 91 deletions(-)

Comments

Oliver O'Halloran July 3, 2020, 5:27 a.m. UTC | #1 
On Fri, Jun 12, 2020 at 9:37 PM Cédric Le Goater <clg@kaod.org> wrote:
>
> Hello,
>
> Here are cleanups which try to deobfuscate some magic values used in
> the driver and add documentation in the commit logs. The only
> significant change is on the size of the VP space which now depends on
> the number of EQ descriptors. We have 1M of these and we use 8
> priorities per VP. Therefore, our VP space should be limited to 128k.
>
> Tested on a witherspoon with 2048 KVM guests each with 4 vCPUS.

Thanks, series merged as of 65cd7f293b743c6fef336186f6e69332e5f4d1f9.