| Message ID | 20200626135631.827697-1-amorenoz@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev] dpif-netdev-unixctl.man: document bond-show command | expand |
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has trailing whitespace #25 FILE: lib/dpif-netdev-unixctl.man:223: handles the load balancing of bonds directly instead of depending on flow Lines checked: 33, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
> . > .IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]" > Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current > usage. > +. > +.IP "\fBdpif-netdev/bond-show\fR [\fIdp\fR]" > +When "other_config:lb-output-action" is set to "true", the userspace > datapath > +handles the load balancing of bonds directly instead of depending on flow > +recirculation (only in balance-tcp mode). > + > +When this is the case, the above command prints the load-balancing > information > +of the bonds configured in datapath \fIdp\fR showing the slave associated > with > +each bucket (hash). Hi Adrian, Thanks for the patch. It looks ok to me. Warm Regards, Vishal Ajmera
On Fri, Jun 26, 2020 at 03:56:31PM +0200, Adrian Moreno wrote: > Document recently added ovs-appctl command Could you add a Fixes tag to indicate the commit? Thanks fbl > > Cc: Vishal Deep Ajmera <vishal.deep.ajmera@ericsson.com> > Signed-off-by: Adrian Moreno <amorenoz@redhat.com> > --- > lib/dpif-netdev-unixctl.man | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man > index 6c54f6f9c..d1cf7c669 100644 > --- a/lib/dpif-netdev-unixctl.man > +++ b/lib/dpif-netdev-unixctl.man > @@ -217,3 +217,12 @@ with port names, which this thread polls. > . > .IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]" > Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current usage. > +. > +.IP "\fBdpif-netdev/bond-show\fR [\fIdp\fR]" > +When "other_config:lb-output-action" is set to "true", the userspace datapath > +handles the load balancing of bonds directly instead of depending on flow > +recirculation (only in balance-tcp mode). > + > +When this is the case, the above command prints the load-balancing information > +of the bonds configured in datapath \fIdp\fR showing the slave associated with > +each bucket (hash). > -- > 2.26.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 7/2/20 10:37 PM, Flavio Leitner wrote: > On Fri, Jun 26, 2020 at 03:56:31PM +0200, Adrian Moreno wrote: >> Document recently added ovs-appctl command > > Could you add a Fixes tag to indicate the commit? Sure, will do > Thanks > fbl > >> >> Cc: Vishal Deep Ajmera <vishal.deep.ajmera@ericsson.com> >> Signed-off-by: Adrian Moreno <amorenoz@redhat.com> >> --- >> lib/dpif-netdev-unixctl.man | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man >> index 6c54f6f9c..d1cf7c669 100644 >> --- a/lib/dpif-netdev-unixctl.man >> +++ b/lib/dpif-netdev-unixctl.man >> @@ -217,3 +217,12 @@ with port names, which this thread polls. >> . >> .IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]" >> Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current usage. >> +. >> +.IP "\fBdpif-netdev/bond-show\fR [\fIdp\fR]" >> +When "other_config:lb-output-action" is set to "true", the userspace datapath >> +handles the load balancing of bonds directly instead of depending on flow >> +recirculation (only in balance-tcp mode). >> + >> +When this is the case, the above command prints the load-balancing information >> +of the bonds configured in datapath \fIdp\fR showing the slave associated with >> +each bucket (hash). >> -- >> 2.26.2 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man index 6c54f6f9c..d1cf7c669 100644 --- a/lib/dpif-netdev-unixctl.man +++ b/lib/dpif-netdev-unixctl.man @@ -217,3 +217,12 @@ with port names, which this thread polls. . .IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]" Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current usage. +. +.IP "\fBdpif-netdev/bond-show\fR [\fIdp\fR]" +When "other_config:lb-output-action" is set to "true", the userspace datapath +handles the load balancing of bonds directly instead of depending on flow +recirculation (only in balance-tcp mode). + +When this is the case, the above command prints the load-balancing information +of the bonds configured in datapath \fIdp\fR showing the slave associated with +each bucket (hash).
Document recently added ovs-appctl command Cc: Vishal Deep Ajmera <vishal.deep.ajmera@ericsson.com> Signed-off-by: Adrian Moreno <amorenoz@redhat.com> --- lib/dpif-netdev-unixctl.man | 9 +++++++++ 1 file changed, 9 insertions(+)