Message ID | CAOMZO5B0DNuFfgYsiMLRg3eTvt7NsrvyznidwQzgQc=L_ThAxQ@mail.gmail.com |
---|---|
State | Superseded, archived |
Headers | show |
Series | Warning coming from raspberrypi,bcm2835-firmware.yaml | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 2 errors, 1 warnings, 15 lines checked |
Hi Fabio, On Thu, Jul 02, 2020 at 11:00:25AM -0300, Fabio Estevam wrote: > Hi Rob, > > I am getting the following warning on > Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml: > > Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.example.dt.yaml: > bus@30000000: compatible:0: 'raspberrypi,bcm2835-firmware' was > expected > Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.example.dt.yaml: > bus@30000000: 'mboxes' is a required property > > If I change raspberrypi,bcm2835-firmware.yaml like this the fsl,aips > warnings is gone: > > --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > @@ -14,7 +14,6 @@ properties: > compatible: > items: > - const: raspberrypi,bcm2835-firmware > - - const: simple-bus > > mboxes: > $ref: '/schemas/types.yaml#/definitions/phandle' > @@ -48,7 +47,7 @@ required: > examples: > - | > firmware { > - compatible = "raspberrypi,bcm2835-firmware", "simple-bus"; > + compatible = "raspberrypi,bcm2835-firmware"; > mboxes = <&mailbox>; > > firmware_clocks: clocks { > > What is the proper way to fix this issue? I've sent a patch for it https://lore.kernel.org/linux-devicetree/20200626115433.125735-1-maxime@cerno.tech/ The faulty commit is in the clk-next branch, so the fix should go through there but hasn't been picked up yet. Maxime
Hi Maxime, On Thu, Jul 2, 2020 at 11:32 AM Maxime Ripard <maxime@cerno.tech> wrote: > I've sent a patch for it > > https://lore.kernel.org/linux-devicetree/20200626115433.125735-1-maxime@cerno.tech/ Thanks. Yes, this fixes the warning in Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml BTW, there are still warnings coming from bcm2835-firmware.example.yaml: $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml CHKDT Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml SCHEMA Documentation/devicetree/bindings/processed-schema-examples.yaml DTC Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or empty reg/ranges property CHECK Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml /home/fabio/linux-next/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' /home/fabio/linux-next/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property /home/fabio/linux-next/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property /home/fabio/linux-next/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property
On Thu, Jul 02, 2020 at 01:20:28PM -0300, Fabio Estevam wrote: > Hi Maxime, > > On Thu, Jul 2, 2020 at 11:32 AM Maxime Ripard <maxime@cerno.tech> wrote: > > > I've sent a patch for it > > > > https://lore.kernel.org/linux-devicetree/20200626115433.125735-1-maxime@cerno.tech/ > > Thanks. Yes, this fixes the warning in > Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml > > BTW, there are still warnings coming from bcm2835-firmware.example.yaml: > > $ make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > CHKDT Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.yaml > DTC Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: > Warning (simple_bus_reg): /example-0/firmware/clocks: missing or empty > reg/ranges property > CHECK Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml > /home/fabio/linux-next/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: > firmware: $nodename:0: 'firmware' does not match > '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > /home/fabio/linux-next/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: > firmware: '#address-cells' is a required property > /home/fabio/linux-next/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: > firmware: '#size-cells' is a required property > /home/fabio/linux-next/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: > firmware: 'ranges' is a required property Yes, as mentionned in the patch above, we can't fix that without changing the binding. Maxime
--- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml @@ -14,7 +14,6 @@ properties: compatible: items: - const: raspberrypi,bcm2835-firmware - - const: simple-bus mboxes: $ref: '/schemas/types.yaml#/definitions/phandle' @@ -48,7 +47,7 @@ required: examples: - | firmware { - compatible = "raspberrypi,bcm2835-firmware", "simple-bus"; + compatible = "raspberrypi,bcm2835-firmware"; mboxes = <&mailbox>; firmware_clocks: clocks {