| Message ID | 20200609131404.17523-16-digetx@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v4,01/37] clk: Export clk_hw_reparent() | expand |
On 6/9/20 10:13 PM, Dmitry Osipenko wrote: > It's useful to now when something goes wrong instead of failing silently, > so let's add error messages to tegra_devfreq_target() to prevent situation > where it fails silently. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra30-devfreq.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 13f93c6038ab..a03fb16c5c4c 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -641,12 +641,16 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq, > dev_pm_opp_put(opp); > > err = clk_set_min_rate(tegra->emc_clock, rate * KHZ); > - if (err) > + if (err) { > + dev_err(dev, "Failed to set min rate: %d\n", err); > return err; > + } > > err = clk_set_rate(tegra->emc_clock, 0); > - if (err) > + if (err) { > + dev_err(dev, "Failed to set rate: %d\n", err); > goto restore_min_rate; > + } > > return 0; > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 13f93c6038ab..a03fb16c5c4c 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -641,12 +641,16 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq, dev_pm_opp_put(opp); err = clk_set_min_rate(tegra->emc_clock, rate * KHZ); - if (err) + if (err) { + dev_err(dev, "Failed to set min rate: %d\n", err); return err; + } err = clk_set_rate(tegra->emc_clock, 0); - if (err) + if (err) { + dev_err(dev, "Failed to set rate: %d\n", err); goto restore_min_rate; + } return 0;
It's useful to now when something goes wrong instead of failing silently, so let's add error messages to tegra_devfreq_target() to prevent situation where it fails silently. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra30-devfreq.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)