| Message ID | 20200616135238.3001888-53-thierry.reding@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ARM: tegra: Various fixes for DT schema validation | expand |
On 16/06/2020 14:52, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The standard way to do this is to list out the clocks at the top-level. > Adopt the standard way to fix validation. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 15 ++++----------- > arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 15 ++++----------- > arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi | 15 ++++----------- > arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 15 ++++----------- > .../arm64/boot/dts/nvidia/tegra210-p3450-0000.dts | 15 ++++----------- > arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 15 ++++----------- > 6 files changed, 24 insertions(+), 66 deletions(-) After applying this patch I see the following build breakage ... DTC arch/arm64/boot/dts/nvidia/tegra132-norrin.dtb arch/arm64/boot/dts/nvidia/tegra132.dtsi:649.15-682.4: ERROR (phandle_references): /usb@70090000: Reference to non-existent node or label "vdd_3v3_lp0" also defined at arch/arm64/boot/dts/nvidia/tegra132-norrin.dts:895.15-909.4 arch/arm64/boot/dts/nvidia/tegra132.dtsi:649.15-682.4: ERROR (phandle_references): /usb@70090000: Reference to non-existent node or label "vdd_3v3_lp0" also defined at arch/arm64/boot/dts/nvidia/tegra132-norrin.dts:895.15-909.4 arch/arm64/boot/dts/nvidia/tegra132.dtsi:684.26-812.4: ERROR (phandle_references): /padctl@7009f000: Reference to non-existent node or label "vdd_3v3_lp0" Jon
On 30/06/2020 12:13, Jon Hunter wrote: > > On 16/06/2020 14:52, Thierry Reding wrote: >> From: Thierry Reding <treding@nvidia.com> >> >> The standard way to do this is to list out the clocks at the top-level. >> Adopt the standard way to fix validation. >> >> Signed-off-by: Thierry Reding <treding@nvidia.com> >> --- >> arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 15 ++++----------- >> arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 15 ++++----------- >> arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi | 15 ++++----------- >> arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 15 ++++----------- >> .../arm64/boot/dts/nvidia/tegra210-p3450-0000.dts | 15 ++++----------- >> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 15 ++++----------- >> 6 files changed, 24 insertions(+), 66 deletions(-) > > After applying this patch I see the following build breakage ... > > DTC arch/arm64/boot/dts/nvidia/tegra132-norrin.dtb > arch/arm64/boot/dts/nvidia/tegra132.dtsi:649.15-682.4: ERROR > (phandle_references): /usb@70090000: Reference to non-existent node or > label "vdd_3v3_lp0" > > also defined at > arch/arm64/boot/dts/nvidia/tegra132-norrin.dts:895.15-909.4 > arch/arm64/boot/dts/nvidia/tegra132.dtsi:649.15-682.4: ERROR > (phandle_references): /usb@70090000: Reference to non-existent node or > label "vdd_3v3_lp0" > > also defined at > arch/arm64/boot/dts/nvidia/tegra132-norrin.dts:895.15-909.4 > arch/arm64/boot/dts/nvidia/tegra132.dtsi:684.26-812.4: ERROR > (phandle_references): /padctl@7009f000: Reference to non-existent node > or label "vdd_3v3_lp0" Same here is might not be this patch, but somewhere during this series I see a few build breakages. Jon
diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts index bb45ca6a5cf2..278bef2d8810 100644 --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts @@ -1022,17 +1022,10 @@ backlight: backlight { backlight-boot-off; }; - clocks { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - clk32k_in: clock@0 { - compatible = "fixed-clock"; - reg=<0>; - #clock-cells = <0>; - clock-frequency = <32768>; - }; + clk32k_in: clock@0 { + compatible = "fixed-clock"; + clock-frequency = <32768>; + #clock-cells = <0>; }; gpio-keys { diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi index 251c6099482a..8a4ba371ff92 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi @@ -300,17 +300,10 @@ mmc@700b0600 { vqmmc-supply = <&vdd_1v8>; }; - clocks { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - clk32k_in: clock@0 { - compatible = "fixed-clock"; - reg = <0>; - #clock-cells = <0>; - clock-frequency = <32768>; - }; + clk32k_in: clock@0 { + compatible = "fixed-clock"; + clock-frequency = <32768>; + #clock-cells = <0>; }; cpus { diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi index f9158dc943f9..58aa0518965e 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi @@ -40,17 +40,10 @@ mmc@700b0600 { non-removable; }; - clocks { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - clk32k_in: clock@0 { - compatible = "fixed-clock"; - reg = <0>; - #clock-cells = <0>; - clock-frequency = <32768>; - }; + clk32k_in: clock@0 { + compatible = "fixed-clock"; + clock-frequency = <32768>; + #clock-cells = <0>; }; cpus { diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi index 579d5b8a757d..9f81cabdcbb6 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi @@ -1586,17 +1586,10 @@ mmc@700b0600 { status = "okay"; }; - clocks { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - clk32k_in: clock@0 { - compatible = "fixed-clock"; - reg = <0>; - #clock-cells = <0>; - clock-frequency = <32768>; - }; + clk32k_in: clock@0 { + compatible = "fixed-clock"; + clock-frequency = <32768>; + #clock-cells = <0>; }; gpio-keys { diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts b/arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts index 4a354f5293fc..b888efcea86f 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts +++ b/arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts @@ -566,17 +566,10 @@ mmc@700b0400 { wakeup-source; }; - clocks { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - clk32k_in: clock@0 { - compatible = "fixed-clock"; - reg = <0>; - #clock-cells = <0>; - clock-frequency = <32768>; - }; + clk32k_in: clock@0 { + compatible = "fixed-clock"; + clock-frequency = <32768>; + #clock-cells = <0>; }; cpus { diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts index 9f630ecc06bc..a28ca6620b86 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts @@ -1722,17 +1722,10 @@ agic@702f9000 { }; }; - clocks { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - clk32k_in: clock@0 { - compatible = "fixed-clock"; - reg = <0>; - #clock-cells = <0>; - clock-frequency = <32768>; - }; + clk32k_in: clock@0 { + compatible = "fixed-clock"; + clock-frequency = <32768>; + #clock-cells = <0>; }; cpus {