| Message ID | 20200616135724.24514-3-eajames@linux.ibm.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | ARM: dts: Aspeed: Enable EHCI controllers | expand |
On Tue, 16 Jun 2020 at 13:57, Eddie James <eajames@linux.ibm.com> wrote: > > Enable the second EHCI controller on the AST2600. Also add a line-name > for the GPIO that controls power to the USB port. What's the idea behind the power control? Is there any reason not to add a hog, so power is always applied? > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > --- > arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > index 96a45014b7e5..fcaff4023240 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > @@ -95,6 +95,10 @@ > }; > }; > > +&ehci1 { > + status = "okay"; > +}; > + > &gpio0 { > gpio-line-names = > /*A0-A7*/ "","","","","","","","", > @@ -111,7 +115,7 @@ > /*L0-L7*/ "","","","","","","","", > /*M0-M7*/ "","","","","","","","", > /*N0-N7*/ "","","","","","","","", > - /*O0-O7*/ "led-rear-power","led-rear-id","","","","","","", > + /*O0-O7*/ "led-rear-power","led-rear-id","","usb-power","","","","", > /*P0-P7*/ "","","","","","","","", > /*Q0-Q7*/ "cfam-reset","","","","","","","fsi-routing", > /*R0-R7*/ "","","","","","","","", > -- > 2.24.0 >
On Tue, 2020-06-30 at 03:02 +0000, Joel Stanley wrote: > On Tue, 16 Jun 2020 at 13:57, Eddie James <eajames@linux.ibm.com> > wrote: > > Enable the second EHCI controller on the AST2600. Also add a line- > > name > > for the GPIO that controls power to the USB port. > > What's the idea behind the power control? > > Is there any reason not to add a hog, so power is always applied? There is a desire to allow the port to be disabled, for those that are worried about rogue USB sticks.
On Tue, 30 Jun 2020 at 12:58, Brad Bishop <bradleyb@fuzziesquirrel.com> wrote: > > On Tue, 2020-06-30 at 03:02 +0000, Joel Stanley wrote: > > On Tue, 16 Jun 2020 at 13:57, Eddie James <eajames@linux.ibm.com> > > wrote: > > > Enable the second EHCI controller on the AST2600. Also add a line- > > > name > > > for the GPIO that controls power to the USB port. > > > > What's the idea behind the power control? > > > > Is there any reason not to add a hog, so power is always applied? > > There is a desire to allow the port to be disabled, for those that are > worried about rogue USB sticks. Ok. Do we have userspace that enables the power? I propose we hog them on for now, so we can test the USB function. When someone has time to implement the enable/disable function we can remove the hog. Cheers, Joel
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts index 96a45014b7e5..fcaff4023240 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts @@ -95,6 +95,10 @@ }; }; +&ehci1 { + status = "okay"; +}; + &gpio0 { gpio-line-names = /*A0-A7*/ "","","","","","","","", @@ -111,7 +115,7 @@ /*L0-L7*/ "","","","","","","","", /*M0-M7*/ "","","","","","","","", /*N0-N7*/ "","","","","","","","", - /*O0-O7*/ "led-rear-power","led-rear-id","","","","","","", + /*O0-O7*/ "led-rear-power","led-rear-id","","usb-power","","","","", /*P0-P7*/ "","","","","","","","", /*Q0-Q7*/ "cfam-reset","","","","","","","fsi-routing", /*R0-R7*/ "","","","","","","","",
Enable the second EHCI controller on the AST2600. Also add a line-name for the GPIO that controls power to the USB port. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)