| Message ID | 20200626211900.10473-1-JPEWhacker@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | Kconfig: Ensure CONFIG_CURL is kept | expand |
Hi Joshua, On 26.06.20 23:19, Joshua Watt wrote: > CONFIG_CURL will only be kept when running `make oldconfig` ??? > if it has a > description. CONFIG_CURL is just set automatically. That means if a selectable option requires CURL, CONFIG_CURL is set. Example: if DOWNLOAD is set, it requires CHANNEL_CURL and this sets CONFIG_CURL on. CURL itself cannot be directly selected. > This config is required for swupdate-sysrestart to do > anything. But swupdate-sysrestart is foreseen together with the FORWARDER handler, and if the handler is set, CURL is set as well. If the FORWARDER is not set, swupdate-sysrestart is just a dummy. You are now forcing to expose CONFIG_CURL, but this then conflicts with the automatic selection done by other options like DOWNLOAD, SURICATTA or FORWARDER. What do you try to do here ? Best regards, Stefano Babic > > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> > --- > Kconfig | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Kconfig b/Kconfig > index 444eb1f..02e0f06 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -98,12 +98,16 @@ menu "Swupdate Settings" > menu "General Configuration" > > config CURL > - bool > + bool "enable curl support" > default n > + help > + Enables support for cURL > > config CURL_SSL > - bool > + bool "enable curl SSL support" > default n > + help > + Enables support for SSL in cURL > > config SYSTEMD > bool "enable systemd support" >
On Sun, Jun 28, 2020, 7:50 AM Stefano Babic <sbabic@denx.de> wrote: > Hi Joshua, > > On 26.06.20 23:19, Joshua Watt wrote: > > CONFIG_CURL will only be kept when running `make oldconfig` > > ??? > > > if it has a > > description. > > CONFIG_CURL is just set automatically. That means if a selectable option > requires CURL, CONFIG_CURL is set. > > Example: if DOWNLOAD is set, it requires CHANNEL_CURL and this sets > CONFIG_CURL on. CURL itself cannot be directly selected. > > > This config is required for swupdate-sysrestart to do > > anything. > > But swupdate-sysrestart is foreseen together with the FORWARDER handler, > and if the handler is set, CURL is set as well. If the FORWARDER is not > set, swupdate-sysrestart is just a dummy. > > You are now forcing to expose CONFIG_CURL, but this then conflicts with > the automatic selection done by other options like DOWNLOAD, SURICATTA > or FORWARDER. What do you try to do here ? > Ah I was unaware that swupdate-sysrestart was only for use with the forwarder handler. I have been testing restart support with it since the webpage support for rebooting appears to be broken currently (but swupdate-sysrestart works for some weird reason). If that's the case, this patch can be dropped, but perhaps some documentation updates would be in order, unless I just missed it somewhere > Best regards, > Stefano Babic > > > > > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> > > --- > > Kconfig | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Kconfig b/Kconfig > > index 444eb1f..02e0f06 100644 > > --- a/Kconfig > > +++ b/Kconfig > > @@ -98,12 +98,16 @@ menu "Swupdate Settings" > > menu "General Configuration" > > > > config CURL > > - bool > > + bool "enable curl support" > > default n > > + help > > + Enables support for cURL > > > > config CURL_SSL > > - bool > > + bool "enable curl SSL support" > > default n > > + help > > + Enables support for SSL in cURL > > > > config SYSTEMD > > bool "enable systemd support" > > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de > ===================================================================== >
Hi Joshua, On 28.06.20 17:30, Joshua Watt wrote: > > > On Sun, Jun 28, 2020, 7:50 AM Stefano Babic <sbabic@denx.de > <mailto:sbabic@denx.de>> wrote: > > Hi Joshua, > > On 26.06.20 23:19, Joshua Watt wrote: > > CONFIG_CURL will only be kept when running `make oldconfig` > > ??? > > > if it has a > > description. > > CONFIG_CURL is just set automatically. That means if a selectable > option > requires CURL, CONFIG_CURL is set. > > Example: if DOWNLOAD is set, it requires CHANNEL_CURL and this sets > CONFIG_CURL on. CURL itself cannot be directly selected. > > > This config is required for swupdate-sysrestart to do > > anything. > > But swupdate-sysrestart is foreseen together with the FORWARDER > handler, > and if the handler is set, CURL is set as well. If the FORWARDER is not > set, swupdate-sysrestart is just a dummy. > > You are now forcing to expose CONFIG_CURL, but this then conflicts with > the automatic selection done by other options like DOWNLOAD, SURICATTA > or FORWARDER. What do you try to do here ? > > > Ah I was unaware that swupdate-sysrestart was only for use with the > forwarder handler. Yes, it is thought to be run on target to reboot all clients upgraded by the forward handler. > I have been testing restart support with it since the > webpage support for rebooting appears to be broken currently (but > swupdate-sysrestart works for some weird reason). > > If that's the case, this patch can be dropped, but perhaps some > documentation updates would be in order, unless I just missed it somewhere Feel free to send a patch to fix documentation too. Best regards, Stefano Babic > > > Best regards, > Stefano Babic > > > > > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com > <mailto:JPEWhacker@gmail.com>> > > --- > > Kconfig | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Kconfig b/Kconfig > > index 444eb1f..02e0f06 100644 > > --- a/Kconfig > > +++ b/Kconfig > > @@ -98,12 +98,16 @@ menu "Swupdate Settings" > > menu "General Configuration" > > > > config CURL > > - bool > > + bool "enable curl support" > > default n > > + help > > + Enables support for cURL > > > > config CURL_SSL > > - bool > > + bool "enable curl SSL support" > > default n > > + help > > + Enables support for SSL in cURL > > > > config SYSTEMD > > bool "enable systemd support" > > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: > sbabic@denx.de <mailto:sbabic@denx.de> > ===================================================================== > > -- > You received this message because you are subscribed to the Google > Groups "swupdate" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to swupdate+unsubscribe@googlegroups.com > <mailto:swupdate+unsubscribe@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/swupdate/CAJdd5GYE4u3GtDMZ46YLGn6JHxALryvV3EeASJToAH3ZPoQ%3D6A%40mail.gmail.com > <https://groups.google.com/d/msgid/swupdate/CAJdd5GYE4u3GtDMZ46YLGn6JHxALryvV3EeASJToAH3ZPoQ%3D6A%40mail.gmail.com?utm_medium=email&utm_source=footer>.
diff --git a/Kconfig b/Kconfig index 444eb1f..02e0f06 100644 --- a/Kconfig +++ b/Kconfig @@ -98,12 +98,16 @@ menu "Swupdate Settings" menu "General Configuration" config CURL - bool + bool "enable curl support" default n + help + Enables support for cURL config CURL_SSL - bool + bool "enable curl SSL support" default n + help + Enables support for SSL in cURL config SYSTEMD bool "enable systemd support"
CONFIG_CURL will only be kept when running `make oldconfig` if it has a description. This config is required for swupdate-sysrestart to do anything. Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> --- Kconfig | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)