diff mbox series

[1/3] haiku build fix second batch

Message ID CA+XhMqwDLw2BJ9Cf0kEyUW+J+rTPOOvebRPPkBSiWdD50wct5Q@mail.gmail.com
State New
Headers show
Series [1/3] haiku build fix second batch | expand

Commit Message

David CARLIER June 26, 2020, 1 p.m. UTC 
From 95ef79ddff73eebd1f1bec6673c2c68209fab107 Mon Sep 17 00:00:00 2001
From: David Carlier <devnexen@gmail.com>
Date: Fri, 26 Jun 2020 13:56:14 +0000
Subject: [PATCH 1/3] Include endian.h for Haiku to solve bswap* macros build
 failure.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 include/qemu/bswap.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Peter Maydell June 26, 2020, 1:38 p.m. UTC | #1 
On Fri, 26 Jun 2020 at 14:02, David CARLIER <devnexen@gmail.com> wrote:
>
> From 95ef79ddff73eebd1f1bec6673c2c68209fab107 Mon Sep 17 00:00:00 2001
> From: David Carlier <devnexen@gmail.com>
> Date: Fri, 26 Jun 2020 13:56:14 +0000
> Subject: [PATCH 1/3] Include endian.h for Haiku to solve bswap* macros build
>  failure.
>
> Signed-off-by: David Carlier <devnexen@gmail.com>

I'm afraid I'm now confused about which is the right version
of the various patches you've sent to the list. Our
https://wiki.qemu.org/Contribute/SubmitAPatch
documentation asks:
 * Include a meaningful cover letter
 * When resending patches add a version tag
 * even if you only change one patch, you resend the entire series
   and mark it as "v2"

Please could you send the whole set of patches you'd like
applied, with the subject header including "[PATCH v2]" and
with a cover letter email that describes the whole series?

thanks
-- PMM
David CARLIER June 26, 2020, 2:10 p.m. UTC | #2 
I sent again minux the ones already approved.

On Fri, 26 Jun 2020 at 14:39, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 26 Jun 2020 at 14:02, David CARLIER <devnexen@gmail.com> wrote:
> >
> > From 95ef79ddff73eebd1f1bec6673c2c68209fab107 Mon Sep 17 00:00:00 2001
> > From: David Carlier <devnexen@gmail.com>
> > Date: Fri, 26 Jun 2020 13:56:14 +0000
> > Subject: [PATCH 1/3] Include endian.h for Haiku to solve bswap* macros build
> >  failure.
> >
> > Signed-off-by: David Carlier <devnexen@gmail.com>
>
> I'm afraid I'm now confused about which is the right version
> of the various patches you've sent to the list. Our
> https://wiki.qemu.org/Contribute/SubmitAPatch
> documentation asks:
>  * Include a meaningful cover letter
>  * When resending patches add a version tag
>  * even if you only change one patch, you resend the entire series
>    and mark it as "v2"
>
> Please could you send the whole set of patches you'd like
> applied, with the subject header including "[PATCH v2]" and
> with a cover letter email that describes the whole series?
>
> thanks
> -- PMM
Peter Maydell June 26, 2020, 2:32 p.m. UTC | #3 
On Fri, 26 Jun 2020 at 15:10, David CARLIER <devnexen@gmail.com> wrote:
>
> I sent again minux the ones already approved.

Sorry, I intended that you should send the whole
series, including the ones which I've reviewed.
(Where I gave a reviewed-by tag, include that
tag in the commit message when you resend the patch.)

thanks
-- PMM
David CARLIER June 26, 2020, 2:36 p.m. UTC | #4 
No idea if I ll have energy to redo all over again I lost previous
patches. Fine no problems...

On Fri, 26 Jun 2020 at 15:33, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 26 Jun 2020 at 15:10, David CARLIER <devnexen@gmail.com> wrote:
> >
> > I sent again minux the ones already approved.
>
> Sorry, I intended that you should send the whole
> series, including the ones which I've reviewed.
> (Where I gave a reviewed-by tag, include that
> tag in the commit message when you resend the patch.)
>
> thanks
> -- PMM
diff mbox series

Patch

diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index 2a9f3fe783..1d3e4c24e4 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -8,6 +8,8 @@ 
 # include <machine/bswap.h>
 #elif defined(__FreeBSD__)
 # include <sys/endian.h>
+#elif defined(__HAIKU__)
+# include <endian.h>
 #elif defined(CONFIG_BYTESWAP_H)
 # include <byteswap.h>