| Message ID | 20200625234516.31406-11-atish.patra@wdc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add UEFI support for RISC-V | expand |
On 6/26/20 1:45 AM, Atish Patra wrote: > arm-init is responsible for setting up efi runtime and doesn't actually > do any ARM specific stuff. RISC-V can use the same source code as it is. > > Rename it to efi-init so that RISC-V can use it. > > Signed-off-by: Atish Patra <atish.patra@wdc.com> > --- > drivers/firmware/efi/{arm-init.c => efi-init.c} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename drivers/firmware/efi/{arm-init.c => efi-init.c} (100%) > > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/efi-init.c > similarity index 100% > rename from drivers/firmware/efi/arm-init.c > rename to drivers/firmware/efi/efi-init.c > After each patch we should have code that builds. This helps when bisecting. Therefore I would have expected an adjustment of drivers/firmware/efi/Makefile in this patch and not in patch 11/11: -arm-obj-$(CONFIG_EFI) := arm-init.o arm-runtime.o +arm-obj-$(CONFIG_EFI) := efi-init.o arm-runtime.o Best regards Heinrich
On Thu, Jun 25, 2020 at 8:00 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > On 6/26/20 1:45 AM, Atish Patra wrote: > > arm-init is responsible for setting up efi runtime and doesn't actually > > do any ARM specific stuff. RISC-V can use the same source code as it is. > > > > Rename it to efi-init so that RISC-V can use it. > > > > Signed-off-by: Atish Patra <atish.patra@wdc.com> > > --- > > drivers/firmware/efi/{arm-init.c => efi-init.c} | 0 > > 1 file changed, 0 insertions(+), 0 deletions(-) > > rename drivers/firmware/efi/{arm-init.c => efi-init.c} (100%) > > > > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/efi-init.c > > similarity index 100% > > rename from drivers/firmware/efi/arm-init.c > > rename to drivers/firmware/efi/efi-init.c > > > > After each patch we should have code that builds. This helps when Absolutely. > bisecting. Therefore I would have expected an adjustment of > drivers/firmware/efi/Makefile in this patch and not in patch 11/11: > > -arm-obj-$(CONFIG_EFI) := arm-init.o arm-runtime.o > +arm-obj-$(CONFIG_EFI) := efi-init.o arm-runtime.o > I think I messed it up while rebasing. My bad. I will fix it in the next version. > Best regards > > Heinrich >
diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/efi-init.c
similarity index 100%
rename from drivers/firmware/efi/arm-init.c
rename to drivers/firmware/efi/efi-init.c
arm-init is responsible for setting up efi runtime and doesn't actually do any ARM specific stuff. RISC-V can use the same source code as it is. Rename it to efi-init so that RISC-V can use it. Signed-off-by: Atish Patra <atish.patra@wdc.com> --- drivers/firmware/efi/{arm-init.c => efi-init.c} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename drivers/firmware/efi/{arm-init.c => efi-init.c} (100%)