| Message ID | 08ef61ed4e24485d8c01385f6396222d7c4044fd.1592930918.git.tredaelli@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev] acinclude: Remove libmnl for MLX5 PMD | expand |
On Tue, Jun 23, 2020 at 10:19 PM Timothy Redaelli <tredaelli@redhat.com> wrote: > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > Acked-by: Numan Siddique <numans@ovn.org> This patch is needed to build OVS on Fedora rawhide successfully and the commit [1] is required in OVS for OVN openstack kolla-ansible bug - https://bugs.launchpad.net/kolla-ansible/+bug/1884734 [1] - https://github.com/openvswitch/ovs/commit/db5a066c17bdeaa Thanks Numan > --- > acinclude.m4 | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 8847b8145..5be2a2f1c 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -368,7 +368,6 @@ AC_DEFUN([OVS_CHECK_DPDK], [ > ], [], [[#include <rte_config.h>]]) > > AC_CHECK_DECL([RTE_LIBRTE_MLX5_PMD], [dnl found > - OVS_FIND_DEPENDENCY([mnl_attr_put], [mnl], [libmnl]) > AC_CHECK_DECL([RTE_IBVERBS_LINK_DLOPEN], [], [dnl not found > OVS_FIND_DEPENDENCY([mlx5dv_create_wq], [mlx5], [libmlx5]) > OVS_FIND_DEPENDENCY([verbs_init_cq], [ibverbs], [libibverbs]) > -- > 2.26.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli <tredaelli@redhat.com> wrote: > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > --- > acinclude.m4 | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 8847b8145..5be2a2f1c 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -368,7 +368,6 @@ AC_DEFUN([OVS_CHECK_DPDK], [ > ], [], [[#include <rte_config.h>]]) > > AC_CHECK_DECL([RTE_LIBRTE_MLX5_PMD], [dnl found > - OVS_FIND_DEPENDENCY([mnl_attr_put], [mnl], [libmnl]) > AC_CHECK_DECL([RTE_IBVERBS_LINK_DLOPEN], [], [dnl not found > OVS_FIND_DEPENDENCY([mlx5dv_create_wq], [mlx5], [libmlx5]) > OVS_FIND_DEPENDENCY([verbs_init_cq], [ibverbs], [libibverbs]) > -- > 2.26.2 Looks good to me. (I copied mlx guys for info.) Reviewed-by: David Marchand <david.marchand@redhat.com> -- David Marchand
On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli <tredaelli@redhat.com> wrote: > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. Why don't you use pkg-config? All these kind of dependencies are managed through libdpdk.pc which is generated with meson.
On Thu, 25 Jun 2020 09:32:23 +0200 Thomas Monjalon <thomas@monjalon.net> wrote: > On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli <tredaelli@redhat.com> wrote: > > > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > Why don't you use pkg-config? > All these kind of dependencies are managed through libdpdk.pc > which is generated with meson. Because on Fedora/RHEL we don't use meson (yet) since it's not possible to choose the list of PMDs to build and testpmd links to some of the PMDs we don't ship
25/06/2020 13:28, Timothy Redaelli: > On Thu, 25 Jun 2020 09:32:23 +0200 > Thomas Monjalon <thomas@monjalon.net> wrote: > > > On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli <tredaelli@redhat.com> wrote: > > > > > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > > > Why don't you use pkg-config? > > All these kind of dependencies are managed through libdpdk.pc > > which is generated with meson. > > Because on Fedora/RHEL we don't use meson (yet) since it's not possible > to choose the list of PMDs to build and testpmd links to some of the > PMDs we don't ship Wrong: there is the option disable_drivers accepting a list. Anyway, makefiles won't be part of DPDK 20.11. You must switch to meson for DPDK compilation.
On 6/25/20 2:13 PM, Thomas Monjalon wrote: > 25/06/2020 13:28, Timothy Redaelli: >> On Thu, 25 Jun 2020 09:32:23 +0200 >> Thomas Monjalon <thomas@monjalon.net> wrote: >> >>> On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli <tredaelli@redhat.com> wrote: >>>> >>>> libmnl is not used anymore for MLX5 PMD since DPDK 19.08. >>> >>> Why don't you use pkg-config? >>> All these kind of dependencies are managed through libdpdk.pc >>> which is generated with meson. >> >> Because on Fedora/RHEL we don't use meson (yet) since it's not possible >> to choose the list of PMDs to build and testpmd links to some of the >> PMDs we don't ship > > Wrong: there is the option disable_drivers accepting a list. > Anyway, makefiles won't be part of DPDK 20.11. > You must switch to meson for DPDK compilation. Since OVS uses DPDK 19.11 and supports linking with 'make'-style DPDK builds on master branch, branch-2.13 and will continue to use it on upcoming branch-2.14, this change makes sense anyway. Applied to master and branch-2.13. Best regards, Ilya Maximets.
diff --git a/acinclude.m4 b/acinclude.m4 index 8847b8145..5be2a2f1c 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -368,7 +368,6 @@ AC_DEFUN([OVS_CHECK_DPDK], [ ], [], [[#include <rte_config.h>]]) AC_CHECK_DECL([RTE_LIBRTE_MLX5_PMD], [dnl found - OVS_FIND_DEPENDENCY([mnl_attr_put], [mnl], [libmnl]) AC_CHECK_DECL([RTE_IBVERBS_LINK_DLOPEN], [], [dnl not found OVS_FIND_DEPENDENCY([mlx5dv_create_wq], [mlx5], [libmlx5]) OVS_FIND_DEPENDENCY([verbs_init_cq], [ibverbs], [libibverbs])
libmnl is not used anymore for MLX5 PMD since DPDK 19.08. Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> --- acinclude.m4 | 1 - 1 file changed, 1 deletion(-)