diff mbox

[U-Boot,v2] am3517evm: change console device from ttyS2 to ttyO2

Message ID 4E23F370.2010800@visionsystems.de
State Accepted
Commit 49473adabff703d0784f1f7457f29bde0a4893d1
Headers show

Commit Message

Yegor Yefremov July 18, 2011, 8:48 a.m. UTC 
From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
From: Yegor Yefremov <yegorslists@googlemail.com>
Date: Mon, 18 Jul 2011 10:37:35 +0200
Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2

the serial device names have been changed from ttySx to ttyOx, so the
console device name should be also changed to support the latest kernel
versions.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 include/configs/am3517_evm.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Albert ARIBAUD July 18, 2011, 9:41 a.m. UTC | #1 
Le 18/07/2011 10:48, Yegor Yefremov a écrit :
>> From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
> From: Yegor Yefremov<yegorslists@googlemail.com>
> Date: Mon, 18 Jul 2011 10:37:35 +0200
> Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
>
> the serial device names have been changed from ttySx to ttyOx, so the
> console device name should be also changed to support the latest kernel
> versions.
>
> Signed-off-by: Yegor Yefremov<yegorslists@googlemail.com>
> ---
>   include/configs/am3517_evm.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
> index 80ad342..18aaadf 100644
> --- a/include/configs/am3517_evm.h
> +++ b/include/configs/am3517_evm.h
> @@ -190,7 +190,7 @@
>
>   #define CONFIG_EXTRA_ENV_SETTINGS \
>   	"loadaddr=0x82000000\0" \
> -	"console=ttyS2,115200n8\0" \
> +	"console=ttyO2,115200n8\0" \
>   	"mmcargs=setenv bootargs console=${console} " \
>   		"root=/dev/mmcblk0p2 rw " \
>   		"rootfstype=ext3 rootwait\0" \

Cc:ing board maintainer, Vaibhav Hiremath <hvaibhav@ti.com> according to 
MAINTAINERS, for ACK.NAK.

(apologies: I should have done this already in reply to patch V1).

Amicalement,
Yegor Yefremov July 18, 2011, 10:18 a.m. UTC | #2 
Am 18.07.2011 11:41, schrieb Albert ARIBAUD:
> Le 18/07/2011 10:48, Yegor Yefremov a écrit :
>>> From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
>> From: Yegor Yefremov<yegorslists@googlemail.com>
>> Date: Mon, 18 Jul 2011 10:37:35 +0200
>> Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
>>
>> the serial device names have been changed from ttySx to ttyOx, so the
>> console device name should be also changed to support the latest kernel
>> versions.
>>
>> Signed-off-by: Yegor Yefremov<yegorslists@googlemail.com>
>> ---
>>   include/configs/am3517_evm.h |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
>> index 80ad342..18aaadf 100644
>> --- a/include/configs/am3517_evm.h
>> +++ b/include/configs/am3517_evm.h
>> @@ -190,7 +190,7 @@
>>
>>   #define CONFIG_EXTRA_ENV_SETTINGS \
>>       "loadaddr=0x82000000\0" \
>> -    "console=ttyS2,115200n8\0" \
>> +    "console=ttyO2,115200n8\0" \
>>       "mmcargs=setenv bootargs console=${console} " \
>>           "root=/dev/mmcblk0p2 rw " \
>>           "rootfstype=ext3 rootwait\0" \
>
> Cc:ing board maintainer, Vaibhav Hiremath <hvaibhav@ti.com> according to MAINTAINERS, for ACK.NAK.
>
> (apologies: I should have done this already in reply to patch V1).

Could you apply the patch (v2) now?

Yegor
hvaibhav@ti.com July 18, 2011, 10:23 a.m. UTC | #3 
> -----Original Message-----
> From: Yegor Yefremov [mailto:yegor_sub1@visionsystems.de]
> Sent: Monday, July 18, 2011 3:48 PM
> To: Albert ARIBAUD
> Cc: u-boot@lists.denx.de; Hiremath, Vaibhav
> Subject: Re: [PATCH v2] am3517evm: change console device from ttyS2 to
> ttyO2
> 
> Am 18.07.2011 11:41, schrieb Albert ARIBAUD:
> > Le 18/07/2011 10:48, Yegor Yefremov a écrit :
> >>> From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
> >> From: Yegor Yefremov<yegorslists@googlemail.com>
> >> Date: Mon, 18 Jul 2011 10:37:35 +0200
> >> Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
> >>
> >> the serial device names have been changed from ttySx to ttyOx, so the
> >> console device name should be also changed to support the latest kernel
> >> versions.
> >>
> >> Signed-off-by: Yegor Yefremov<yegorslists@googlemail.com>
> >> ---
> >>   include/configs/am3517_evm.h |    2 +-
> >>   1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/include/configs/am3517_evm.h
> b/include/configs/am3517_evm.h
> >> index 80ad342..18aaadf 100644
> >> --- a/include/configs/am3517_evm.h
> >> +++ b/include/configs/am3517_evm.h
> >> @@ -190,7 +190,7 @@
> >>
> >>   #define CONFIG_EXTRA_ENV_SETTINGS \
> >>       "loadaddr=0x82000000\0" \
> >> -    "console=ttyS2,115200n8\0" \
> >> +    "console=ttyO2,115200n8\0" \
> >>       "mmcargs=setenv bootargs console=${console} " \
> >>           "root=/dev/mmcblk0p2 rw " \
> >>           "rootfstype=ext3 rootwait\0" \
> >
> > Cc:ing board maintainer, Vaibhav Hiremath <hvaibhav@ti.com> according to
> MAINTAINERS, for ACK.NAK.
> >
> > (apologies: I should have done this already in reply to patch V1).
> 
> Could you apply the patch (v2) now?
> 
[Hiremath, Vaibhav] Acked-by: Vaibhav Hiremath <hvaibhav@ti.com>

Thanks,
Vaibhav

> Yegor
Albert ARIBAUD July 18, 2011, 10:37 a.m. UTC | #4 
Hi Yegor,

Le 18/07/2011 10:48, Yegor Yefremov a écrit :
>> From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
> From: Yegor Yefremov<yegorslists@googlemail.com>
> Date: Mon, 18 Jul 2011 10:37:35 +0200
> Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
>
> the serial device names have been changed from ttySx to ttyOx, so the
> console device name should be also changed to support the latest kernel
> versions.
>
> Signed-off-by: Yegor Yefremov<yegorslists@googlemail.com>
> ---
>   include/configs/am3517_evm.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
> index 80ad342..18aaadf 100644
> --- a/include/configs/am3517_evm.h
> +++ b/include/configs/am3517_evm.h
> @@ -190,7 +190,7 @@
>
>   #define CONFIG_EXTRA_ENV_SETTINGS \
>   	"loadaddr=0x82000000\0" \
> -	"console=ttyS2,115200n8\0" \
> +	"console=ttyO2,115200n8\0" \
>   	"mmcargs=setenv bootargs console=${console} " \
>   		"root=/dev/mmcblk0p2 rw " \
>   		"rootfstype=ext3 rootwait\0" \

Applied, with Vaibhav's Ack, to u-boot-arm/master, thanks!

Amicalement,
Albert ARIBAUD July 18, 2011, 10:37 a.m. UTC | #5 
Le 18/07/2011 12:23, Hiremath, Vaibhav a écrit :
>
>> -----Original Message-----
>> From: Yegor Yefremov [mailto:yegor_sub1@visionsystems.de]
>> Sent: Monday, July 18, 2011 3:48 PM
>> To: Albert ARIBAUD
>> Cc: u-boot@lists.denx.de; Hiremath, Vaibhav
>> Subject: Re: [PATCH v2] am3517evm: change console device from ttyS2 to
>> ttyO2
>>
>> Am 18.07.2011 11:41, schrieb Albert ARIBAUD:
>>> Le 18/07/2011 10:48, Yegor Yefremov a écrit :
>>>>>  From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
>>>> From: Yegor Yefremov<yegorslists@googlemail.com>
>>>> Date: Mon, 18 Jul 2011 10:37:35 +0200
>>>> Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
>>>>
>>>> the serial device names have been changed from ttySx to ttyOx, so the
>>>> console device name should be also changed to support the latest kernel
>>>> versions.
>>>>
>>>> Signed-off-by: Yegor Yefremov<yegorslists@googlemail.com>
>>>> ---
>>>>    include/configs/am3517_evm.h |    2 +-
>>>>    1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/include/configs/am3517_evm.h
>> b/include/configs/am3517_evm.h
>>>> index 80ad342..18aaadf 100644
>>>> --- a/include/configs/am3517_evm.h
>>>> +++ b/include/configs/am3517_evm.h
>>>> @@ -190,7 +190,7 @@
>>>>
>>>>    #define CONFIG_EXTRA_ENV_SETTINGS \
>>>>        "loadaddr=0x82000000\0" \
>>>> -    "console=ttyS2,115200n8\0" \
>>>> +    "console=ttyO2,115200n8\0" \
>>>>        "mmcargs=setenv bootargs console=${console} " \
>>>>            "root=/dev/mmcblk0p2 rw " \
>>>>            "rootfstype=ext3 rootwait\0" \
>>>
>>> Cc:ing board maintainer, Vaibhav Hiremath<hvaibhav@ti.com>  according to
>> MAINTAINERS, for ACK.NAK.
>>>
>>> (apologies: I should have done this already in reply to patch V1).
>>
>> Could you apply the patch (v2) now?
>>
> [Hiremath, Vaibhav] Acked-by: Vaibhav Hiremath<hvaibhav@ti.com>
>
> Thanks,
> Vaibhav

Now, I can :)

(I did insert Vaibhav's Acked-by manually in the commit message, though)

>> Yegor

Amicalement,
diff mbox

Patch

diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
index 80ad342..18aaadf 100644
--- a/include/configs/am3517_evm.h
+++ b/include/configs/am3517_evm.h
@@ -190,7 +190,7 @@ 
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"loadaddr=0x82000000\0" \
-	"console=ttyS2,115200n8\0" \
+	"console=ttyO2,115200n8\0" \
 	"mmcargs=setenv bootargs console=${console} " \
 		"root=/dev/mmcblk0p2 rw " \
 		"rootfstype=ext3 rootwait\0" \