| Message ID | 20200619165154.GA20461@cnn |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v4] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN | expand |
On : 06/19/2020 abiout 12:46PM in some timezone, Manikandan Elumalai wrote: >The adm1278 temp attribute need it for openbmc platform . >This feature not enabled by default, so PMON_CONFIG needs to enable >it. > >Signed-off-by: Manikandan Elumalai <manikandan.hcl.ers.epl@gmail.com> >--- >--- v4 -Reported-by: kernel test robot <lkp@intel.com> Thie above tag should be Adjacent to the Signed-off-by. >--- v3 -fix invalid signed-off. >--- -removed checkpath warnings. >--- -write ADM1278_TEMP1_EN and ADM1278_VOUT_EN conf in single >line operation. >--- v2 -add Signed-off-by. >--- -removed ADM1278_TEMP1_EN check. >--- The canonical format is to have a line of 3 dashes then the trailing changelog Please read the documentation at https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format milton
On 6/19/20 9:51 AM, Manikandan Elumalai wrote: > The adm1278 temp attribute need it for openbmc platform . > This feature not enabled by default, so PMON_CONFIG needs to enable it. > > Signed-off-by: Manikandan Elumalai <manikandan.hcl.ers.epl@gmail.com> In addition to the other comment - please never send a new version of a patch with the same sequence number. There are now two different versions of this patch, both tagged "v4". Guenter > --- > --- v4 -Reported-by: kernel test robot <lkp@intel.com> > --- v3 -fix invalid signed-off. > --- -removed checkpath warnings. > --- -write ADM1278_TEMP1_EN and ADM1278_VOUT_EN conf in single line operation. > --- v2 -add Signed-off-by. > --- -removed ADM1278_TEMP1_EN check. > --- > --- > drivers/hwmon/pmbus/adm1275.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c > index 5caa37fb..d4e1925 100644 > --- a/drivers/hwmon/pmbus/adm1275.c > +++ b/drivers/hwmon/pmbus/adm1275.c > @@ -666,11 +666,12 @@ static int adm1275_probe(struct i2c_client *client, > tindex = 3; > > info->func[0] |= PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT | > - PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT; > + PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | > + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP; > > - /* Enable VOUT if not enabled (it is disabled by default) */ > - if (!(config & ADM1278_VOUT_EN)) { > - config |= ADM1278_VOUT_EN; > + /* Enable VOUT & TEMP1 if not enabled (disabled by default) */ > + if ((config & (ADM1278_VOUT_EN | ADM1278_TEMP1_EN)) != (ADM1278_VOUT_EN | ADM1278_TEMP1_EN)) { > + config |= ADM1278_VOUT_EN | ADM1278_TEMP1_EN; > ret = i2c_smbus_write_byte_data(client, > ADM1275_PMON_CONFIG, > config); > @@ -681,9 +682,6 @@ static int adm1275_probe(struct i2c_client *client, > } > } > > - if (config & ADM1278_TEMP1_EN) > - info->func[0] |= > - PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP; > if (config & ADM1278_VIN_EN) > info->func[0] |= PMBUS_HAVE_VIN; > break; >
diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c index 5caa37fb..d4e1925 100644 --- a/drivers/hwmon/pmbus/adm1275.c +++ b/drivers/hwmon/pmbus/adm1275.c @@ -666,11 +666,12 @@ static int adm1275_probe(struct i2c_client *client, tindex = 3; info->func[0] |= PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT | - PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT; + PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP; - /* Enable VOUT if not enabled (it is disabled by default) */ - if (!(config & ADM1278_VOUT_EN)) { - config |= ADM1278_VOUT_EN; + /* Enable VOUT & TEMP1 if not enabled (disabled by default) */ + if ((config & (ADM1278_VOUT_EN | ADM1278_TEMP1_EN)) != (ADM1278_VOUT_EN | ADM1278_TEMP1_EN)) { + config |= ADM1278_VOUT_EN | ADM1278_TEMP1_EN; ret = i2c_smbus_write_byte_data(client, ADM1275_PMON_CONFIG, config); @@ -681,9 +682,6 @@ static int adm1275_probe(struct i2c_client *client, } } - if (config & ADM1278_TEMP1_EN) - info->func[0] |= - PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP; if (config & ADM1278_VIN_EN) info->func[0] |= PMBUS_HAVE_VIN; break;
The adm1278 temp attribute need it for openbmc platform . This feature not enabled by default, so PMON_CONFIG needs to enable it. Signed-off-by: Manikandan Elumalai <manikandan.hcl.ers.epl@gmail.com> --- --- v4 -Reported-by: kernel test robot <lkp@intel.com> --- v3 -fix invalid signed-off. --- -removed checkpath warnings. --- -write ADM1278_TEMP1_EN and ADM1278_VOUT_EN conf in single line operation. --- v2 -add Signed-off-by. --- -removed ADM1278_TEMP1_EN check. --- --- drivers/hwmon/pmbus/adm1275.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)