diff mbox series

[2/2] package/open-plc-utils: install packages to /usr/bin

Message ID 20200617222159.176141-2-aduskett@gmail.com
State Accepted
Headers show
Series [1/2] package/open-plc-utils: bump to version 32408520fcebe785983a68e39ec83830a3005779 | expand

Commit Message

Adam Duskett June 17, 2020, 10:21 p.m. UTC 
From: Adam Duskett <Aduskett@gmail.com>

By default, open-plc-utils installs all of the compiled binaries to
/usr/local/bin which is not in the default path provided by Buildroot.

Passing BIN="$(TARGET_DIR)/usr/bin" to make install forces open-plc-utils to
install the compiled binaries to /usr/bin.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/open-plc-utils/open-plc-utils.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni June 18, 2020, 7:25 a.m. UTC | #1 
On Wed, 17 Jun 2020 15:21:59 -0700
aduskett@gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> By default, open-plc-utils installs all of the compiled binaries to
> /usr/local/bin which is not in the default path provided by Buildroot.
> 
> Passing BIN="$(TARGET_DIR)/usr/bin" to make install forces open-plc-utils to
> install the compiled binaries to /usr/bin.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

Is this something related to the version bump, or independent, i.e
something that already happens with the open-plc-utils currently in
Buildroot?

In the latter case, then this fix should have come as a first patch in
the series, so that it's clear it's a fix for something that is broken
today, so that we know it needs to be backported to 2020.02.x and
2020.05.x.

Thanks!

Thomas
Peter Korsgaard July 15, 2020, 8:48 p.m. UTC | #2 
>>>>> "aduskett" == aduskett  <aduskett@gmail.com> writes:

 > From: Adam Duskett <Aduskett@gmail.com>
 > By default, open-plc-utils installs all of the compiled binaries to
 > /usr/local/bin which is not in the default path provided by Buildroot.

 > Passing BIN="$(TARGET_DIR)/usr/bin" to make install forces open-plc-utils to
 > install the compiled binaries to /usr/bin.

 > Signed-off-by: Adam Duskett <Aduskett@gmail.com>

Committed to 2020.02.x and 2020.05.x, thanks.
diff mbox series

Patch

diff --git a/package/open-plc-utils/open-plc-utils.mk b/package/open-plc-utils/open-plc-utils.mk
index bb40432697..d2ac39aca4 100644
--- a/package/open-plc-utils/open-plc-utils.mk
+++ b/package/open-plc-utils/open-plc-utils.mk
@@ -26,7 +26,8 @@  define OPEN_PLC_UTILS_BUILD_CMDS
 endef
 
 define OPEN_PLC_UTILS_INSTALL_TARGET_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) ROOTFS=$(TARGET_DIR) -C $(@D) install
+	$(TARGET_MAKE_ENV) $(MAKE) ROOTFS=$(TARGET_DIR) \
+		BIN="$(TARGET_DIR)/usr/bin" -C $(@D) install
 endef
 
 $(eval $(generic-package))