diff mbox series

[v2] platform/mihawk: Fix IPMI double-free

Message ID 20200616012324.12256-1-Nichole_Wang@wistron.com
State Accepted
Headers show
Series [v2] platform/mihawk: Fix IPMI double-free | expand

Commit Message

Nichole Wang June 16, 2020, 1:23 a.m. UTC 
From: nichole <Nichole_Wang@wistron.com>

The commit 6826095 ("platform/mihawk: support dynamic PCIe slot table")
added the IPMI OEM command to communicate with BMC. We do the
ipmi_free_msg(msg) twice that caused the Fast-reboot fail.

This patch fixes it by removing the IPMI double-free bug to restore
Fast-reboot.

Signed-off-by: Nichole Wang <Nichole_Wang@wistron.com>
Cc: skiboot-stable@lists.ozlabs.org # skiboot-6.6.x
Cc: skiboot-stable@lists.ozlabs.org # skiboot-op940.x
Fixes: commit 6826095 ("platform/mihawk: support dynamic PCIe slot table")
---
 platforms/astbmc/mihawk.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Vasant Hegde June 16, 2020, 2:16 p.m. UTC | #1 
On 6/16/20 6:53 AM, Nichole Wang wrote:
> From: nichole <Nichole_Wang@wistron.com>
> 
> The commit 6826095 ("platform/mihawk: support dynamic PCIe slot table")
> added the IPMI OEM command to communicate with BMC. We do the
> ipmi_free_msg(msg) twice that caused the Fast-reboot fail.
> 
> This patch fixes it by removing the IPMI double-free bug to restore
> Fast-reboot.
> 
> Signed-off-by: Nichole Wang <Nichole_Wang@wistron.com>
> Cc: skiboot-stable@lists.ozlabs.org # skiboot-6.6.x
> Cc: skiboot-stable@lists.ozlabs.org # skiboot-op940.x
> Fixes: commit 6826095 ("platform/mihawk: support dynamic PCIe slot table")


Looks good to me.

Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

-Vasant
Oliver O'Halloran June 24, 2020, 3:18 a.m. UTC | #2 
On Tue, Jun 16, 2020 at 11:24 AM Nichole Wang <Nichole_Wang@wistron.com> wrote:
>
> From: nichole <Nichole_Wang@wistron.com>
>
> The commit 6826095 ("platform/mihawk: support dynamic PCIe slot table")
> added the IPMI OEM command to communicate with BMC. We do the
> ipmi_free_msg(msg) twice that caused the Fast-reboot fail.
>
> This patch fixes it by removing the IPMI double-free bug to restore
> Fast-reboot.
>
> Signed-off-by: Nichole Wang <Nichole_Wang@wistron.com>
> Cc: skiboot-stable@lists.ozlabs.org # skiboot-6.6.x
> Cc: skiboot-stable@lists.ozlabs.org # skiboot-op940.x
> Fixes: commit 6826095 ("platform/mihawk: support dynamic PCIe slot table")

Thanks, merged as 68dc040a6540c218d20517764ff5d740a3626c55
diff mbox series

Patch

diff --git a/platforms/astbmc/mihawk.c b/platforms/astbmc/mihawk.c
index f3669ff..54c2884 100644
--- a/platforms/astbmc/mihawk.c
+++ b/platforms/astbmc/mihawk.c
@@ -533,8 +533,6 @@  static void mihawk_init(void)
 			if (timeout_ms == 0)
 				break;
 		}
-
-		ipmi_free_msg(ipmi_msg);
 	}
 
 	prlog(PR_DEBUG, "Mihawk: IPMI_RISERF_QUERY finish. riser_state: %02x"