| Message ID | 20200528091736.40634-3-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 10a428ed1540c255bf52ee5b6df4a575913885d2 |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [v2,1/4] x86: tangier: acpi: Create buffers outside of the methods | expand |
On Thu, May 28, 2020 at 5:17 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > ACPICA complains that either _HID() or _ADR() should be used. > Drop _ADR() where _HID() is present. > > Reported-by: Bin Meng <bmeng.cn@gmail.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v2: no changes > arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Tested-by: Bin Meng <bmeng.cn@gmail.com>
On Mon, Jun 1, 2020 at 10:57 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Thu, May 28, 2020 at 5:17 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > ACPICA complains that either _HID() or _ADR() should be used. > > Drop _ADR() where _HID() is present. > > > > Reported-by: Bin Meng <bmeng.cn@gmail.com> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > v2: no changes > > arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 - > > 1 file changed, 1 deletion(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > Tested-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl index 11b06e5fe94f..f9da188b38f6 100644 --- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl @@ -441,7 +441,6 @@ Device (PCI0) Device (PMIC) { - Name (_ADR, Zero) Name (_HID, "INTC100E") Name (_CID, "INTC100E") Name (_DDN, "Basin Cove PMIC")
ACPICA complains that either _HID() or _ADR() should be used. Drop _ADR() where _HID() is present. Reported-by: Bin Meng <bmeng.cn@gmail.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: no changes arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 - 1 file changed, 1 deletion(-)