diff mbox series

[v2,2/4] x86: tangier: acpi: Replace _ADR() by _UID() in description of PCI host bridge

Message ID 20200528091736.40634-2-andriy.shevchenko@linux.intel.com
State Accepted
Commit 55f54538f8b45963724d69b481ee624478582321
Delegated to: Bin Meng
Headers show
Series [v2,1/4] x86: tangier: acpi: Create buffers outside of the methods | expand

Commit Message

Andy Shevchenko May 28, 2020, 9:17 a.m. UTC 
PCI Firmware specification requires _UID() and doesn't require _ADR()
to be set. Replace latter by former.

Reported-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: no changes
 arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng June 1, 2020, 2:57 a.m. UTC | #1 
On Thu, May 28, 2020 at 5:17 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> PCI Firmware specification requires _UID() and doesn't require _ADR()
> to be set. Replace latter by former.
>
> Reported-by: Bin Meng <bmeng.cn@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: no changes
>  arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng June 1, 2020, 4:16 a.m. UTC | #2 
On Mon, Jun 1, 2020 at 10:57 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Thu, May 28, 2020 at 5:17 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > PCI Firmware specification requires _UID() and doesn't require _ADR()
> > to be set. Replace latter by former.
> >
> > Reported-by: Bin Meng <bmeng.cn@gmail.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v2: no changes
> >  arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Tested-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
index 9d81abbdb674..11b06e5fe94f 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
@@ -10,7 +10,7 @@  Device (PCI0)
     Name (_HID, EISAID("PNP0A08"))    /* PCIe */
     Name (_CID, EISAID("PNP0A03"))    /* PCI */
 
-    Name (_ADR, Zero)
+    Name (_UID, Zero)
     Name (_BBN, Zero)
 
     Name (MCRS, ResourceTemplate()