Message ID | 20200528134035.32025-1-kraxel@redhat.com |
---|---|
Headers | show |
Series | microvm: memory config tweaks | expand |
On 5/28/20 3:40 PM, Gerd Hoffmann wrote: > Not useful for microvm and allows users to shoot themself > into the foot (make ram + mmio overlap). > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > Reviewed-by: Igor Mammedov <imammedo@redhat.com> > Acked-by: Paolo Bonzini <pbonzini@redhat.com> > --- > hw/i386/microvm.c | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c > index 44f940813b07..5e931975a06d 100644 > --- a/hw/i386/microvm.c > +++ b/hw/i386/microvm.c > @@ -173,25 +173,6 @@ static void microvm_memory_init(MicrovmMachineState *mms) > ram_addr_t lowmem = 0xc0000000; /* 3G */ > int i; > > - /* > - * Handle the machine opt max-ram-below-4g. It is basically doing > - * min(qemu limit, user limit). > - */ > - if (!x86ms->max_ram_below_4g) { > - x86ms->max_ram_below_4g = 4 * GiB; > - } > - if (lowmem > x86ms->max_ram_below_4g) { > - lowmem = x86ms->max_ram_below_4g; > - if (machine->ram_size - lowmem > lowmem && > - lowmem & (1 * GiB - 1)) { > - warn_report("There is possibly poor performance as the ram size " > - " (0x%" PRIx64 ") is more then twice the size of" > - " max-ram-below-4g (%"PRIu64") and" > - " max-ram-below-4g is not a multiple of 1G.", > - (uint64_t)machine->ram_size, x86ms->max_ram_below_4g); > - } > - } > - > if (machine->ram_size > lowmem) { > x86ms->above_4g_mem_size = machine->ram_size - lowmem; > x86ms->below_4g_mem_size = lowmem; > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Patchew URL: https://patchew.org/QEMU/20200528134035.32025-1-kraxel@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === CC x86_64-softmmu/target/i386/translate.o CC aarch64-softmmu/hw/arm/omap1.o /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c: In function 'xen_ram_init': /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:206:34: error: 'X86_MACHINE_MAX_RAM_BELOW_4G' undeclared (first use in this function) X86_MACHINE_MAX_RAM_BELOW_4G, ^ /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:206:34: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [hw/i386/xen/xen-hvm.o] Error 1 CC aarch64-softmmu/hw/arm/omap2.o make[1]: *** Waiting for unfinished jobs.... CC aarch64-softmmu/hw/arm/strongarm.o --- CC aarch64-softmmu/target/arm/gdbstub64.o CC aarch64-softmmu/target/arm/machine.o CC aarch64-softmmu/target/arm/arch_dump.o make: *** [x86_64-softmmu/all] Error 2 make: *** Waiting for unfinished jobs.... CC aarch64-softmmu/target/arm/monitor.o CC aarch64-softmmu/target/arm/arm-powerctl.o --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=74ab42ef34594fdb988f724e8efaa96d', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-fky5lt0a/src/docker-src.2020-05-28-16.55.24.5056:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=74ab42ef34594fdb988f724e8efaa96d make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-fky5lt0a/src' make: *** [docker-run-test-quick@centos7] Error 2 real 3m8.799s user 0m4.488s The full log is available at http://patchew.org/logs/20200528134035.32025-1-kraxel@redhat.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200528134035.32025-1-kraxel@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === CC x86_64-softmmu/softmmu/main.o CC x86_64-softmmu/gdbstub-xml.o CC x86_64-softmmu/trace/generated-helpers.o /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:206:34: error: use of undeclared identifier 'X86_MACHINE_MAX_RAM_BELOW_4G' X86_MACHINE_MAX_RAM_BELOW_4G, ^ 1 error generated. make[1]: *** [/tmp/qemu-test/src/rules.mak:69: hw/i386/xen/xen-hvm.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:527: x86_64-softmmu/all] Error 2 Traceback (most recent call last): File "./tests/docker/docker.py", line 664, in <module> sys.exit(main()) --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=0bac4918513149f2a4717d0ab9d331ee', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=x86_64-softmmu', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-sdwodinx/src/docker-src.2020-05-28-16.59.46.14444:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-debug']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=0bac4918513149f2a4717d0ab9d331ee make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-sdwodinx/src' make: *** [docker-run-test-debug@fedora] Error 2 real 4m15.596s user 0m7.249s The full log is available at http://patchew.org/logs/20200528134035.32025-1-kraxel@redhat.com/testing.asan/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Thu, 28 May 2020 13:58:35 -0700 (PDT) no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200528134035.32025-1-kraxel@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce it > locally. > > === TEST SCRIPT BEGIN === > #!/bin/bash > make docker-image-centos7 V=1 NETWORK=1 > time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 > === TEST SCRIPT END === > > CC x86_64-softmmu/target/i386/translate.o > CC aarch64-softmmu/hw/arm/omap1.o > /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c: In function 'xen_ram_init': > /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:206:34: error: 'X86_MACHINE_MAX_RAM_BELOW_4G' undeclared (first use in this function) > X86_MACHINE_MAX_RAM_BELOW_4G, it seems the build is still broken > ^ > /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:206:34: note: each undeclared identifier is reported only once for each function it appears in > make[1]: *** [hw/i386/xen/xen-hvm.o] Error 1 > CC aarch64-softmmu/hw/arm/omap2.o > make[1]: *** Waiting for unfinished jobs.... > CC aarch64-softmmu/hw/arm/strongarm.o > --- > CC aarch64-softmmu/target/arm/gdbstub64.o > CC aarch64-softmmu/target/arm/machine.o > CC aarch64-softmmu/target/arm/arch_dump.o > make: *** [x86_64-softmmu/all] Error 2 > make: *** Waiting for unfinished jobs.... > CC aarch64-softmmu/target/arm/monitor.o > CC aarch64-softmmu/target/arm/arm-powerctl.o > --- > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=74ab42ef34594fdb988f724e8efaa96d', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-fky5lt0a/src/docker-src.2020-05-28-16.55.24.5056:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. > filter=--filter=label=com.qemu.instance.uuid=74ab42ef34594fdb988f724e8efaa96d > make[1]: *** [docker-run] Error 1 > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-fky5lt0a/src' > make: *** [docker-run-test-quick@centos7] Error 2 > > real 3m8.799s > user 0m4.488s > > > The full log is available at > http://patchew.org/logs/20200528134035.32025-1-kraxel@redhat.com/testing.docker-quick@centos7/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com