| Message ID | 20200528110554.10179-2-pvorel@suse.cz |
|---|---|
| State | Rejected |
| Headers | show |
| Series | LVM: Drop legacy scripts and runtest files | expand |
On 28. 05. 20 13:05, Petr Vorel wrote: > LTPROOT can be in user writable directory. Having rights for make > install is user responsibility, it does not have to be guarded by > TST_NEEDS_ROOT=1. TST_NEEDS_ROOT=1 is there for tst_supported_fs. It won't find any mkfs programs if it's not running as root.
> On 28. 05. 20 13:05, Petr Vorel wrote: > > LTPROOT can be in user writable directory. Having rights for make > > install is user responsibility, it does not have to be guarded by > > TST_NEEDS_ROOT=1. > TST_NEEDS_ROOT=1 is there for tst_supported_fs. It won't find any mkfs > programs if it's not running as root. Right, thanks for info. Hm, there can be some tests which just want to know supported filesystems without running them and we have to require root for them. There could be a solutions (tst_get_supported_fs_types() could have warning about PATH when user is not root and no mkfs.* found or just changing in has_mkfs() "mkfs.%s does not exist" to "mkfs.%s does not found" to give more obvious hint). But it's just a corner case issue, no need to bother with it. Kind regards, Petr
diff --git a/testcases/misc/lvm/generate_lvm_runfile.sh b/testcases/misc/lvm/generate_lvm_runfile.sh index 5ca035f22..b3366cb99 100755 --- a/testcases/misc/lvm/generate_lvm_runfile.sh +++ b/testcases/misc/lvm/generate_lvm_runfile.sh @@ -5,7 +5,6 @@ # Generate LTP runfile for LVM tests (runtest/lvm.local) TST_TESTFUNC=generate_runfile -TST_NEEDS_ROOT=1 TST_NEEDS_CMDS="sed" . tst_test.sh
LTPROOT can be in user writable directory. Having rights for make install is user responsibility, it does not have to be guarded by TST_NEEDS_ROOT=1. Fixes: 45289e498 ("Add LVM support scripts") Signed-off-by: Petr Vorel <pvorel@suse.cz> --- testcases/misc/lvm/generate_lvm_runfile.sh | 1 - 1 file changed, 1 deletion(-)