| Message ID | 20200526181949.48060-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [v1] x86: acpi: Drop _HID() where enumerated by _ADR() | expand |
On Tue, May 26, 2020 at 09:19:49PM +0300, Andy Shevchenko wrote: > ACPICA complains that either _HID() or _ADR() should be used. > For General Purpose DMA we may not drop the _ADR() because > the device is enumerated by PCI. Thus, simple drop _HID(). Bin, since now all issues you found, being addressed, care to apply before v2020.07 release?
Hi Andy, On Wed, May 27, 2020 at 10:16 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, May 26, 2020 at 09:19:49PM +0300, Andy Shevchenko wrote: > > ACPICA complains that either _HID() or _ADR() should be used. > > For General Purpose DMA we may not drop the _ADR() because > > the device is enumerated by PCI. Thus, simple drop _HID(). > > Bin, since now all issues you found, being addressed, care to apply before > v2020.07 release? > Yes, this is planned in the next PR. Regards, Bin
diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl index eaf75c8c673d..01077293bb91 100644 --- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl @@ -531,7 +531,6 @@ Device (PCI0) Device (GDMA) { Name (_ADR, 0x00150000) - Name (_HID, "808611A2") Name (_UID, Zero) Method (_STA, 0, NotSerialized)
ACPICA complains that either _HID() or _ADR() should be used. For General Purpose DMA we may not drop the _ADR() because the device is enumerated by PCI. Thus, simple drop _HID(). Reported-by: Bin Meng <bmeng.cn@gmail.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 - 1 file changed, 1 deletion(-)