| Message ID | 1310410158-21273-1-git-send-email-dirk.behme@gmail.com |
|---|---|
| State | Accepted |
| Commit | 34d34b88b6b3d947de86dae81574bdde85b8d01e |
| Delegated to: | Minkyu Kang |
| Headers | show |
On 12 July 2011 00:19, Dirk Behme <dirk.behme@googlemail.com> wrote: > From: Dirk Behme <dirk.behme@googlemail.com> > > Fix compilation of mkv310_image host tool > > tools/mkv310_image.c: In function 'main': > tools/mkv310_image.c:67: error: 'S_IRUSR' undeclared (first use in this function) > tools/mkv310_image.c:67: error: (Each undeclared identifier is reported only once > tools/mkv310_image.c:67: error: for each function it appears in.) > tools/mkv310_image.c:67: error: 'S_IWUSR' undeclared (first use in this function) > tools/mkv310_image.c:67: error: 'S_IRGRP' undeclared (first use in this function) > tools/mkv310_image.c:67: error: 'S_IWGRP' undeclared (first use in this function) > tools/mkv310_image.c:67: error: 'S_IROTH' undeclared (first use in this function) > tools/mkv310_image.c:67: error: 'S_IWOTH' undeclared (first use in this function) > > resulting from a 'make smdkv310_config'. > > Signed-off-by: Dirk Behme <dirk.behme@googlemail.com> > > --- > Changes in v2: Use sys/stat.h instead of linux/stat.h > > Note: mkv310_image is compiled for the host by the host's gcc: > > cd mmc_spl/board/samsung/smdkv310 > gcc tools/mkv310_image.c -o tools/mkv310_mmc_spl_exec > > mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c | 1 + > 1 file changed, 1 insertion(+) > > Index: u-boot.git/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c > =================================================================== > --- u-boot.git.orig/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c > +++ u-boot.git/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c > @@ -26,6 +26,7 @@ > #include <fcntl.h> > #include <errno.h> > #include <string.h> > +#include <sys/stat.h> > > #define CHECKSUM_OFFSET (14*1024-4) > #define BUFSIZE (16*1024) > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > Ok. Dear Minkyu, Please apply
Dear Dirk Behme, On 12 July 2011 16:20, Chander Kashyap <chander.kashyap@linaro.org> wrote: > On 12 July 2011 00:19, Dirk Behme <dirk.behme@googlemail.com> wrote: >> From: Dirk Behme <dirk.behme@googlemail.com> >> >> Fix compilation of mkv310_image host tool >> >> tools/mkv310_image.c: In function 'main': >> tools/mkv310_image.c:67: error: 'S_IRUSR' undeclared (first use in this function) >> tools/mkv310_image.c:67: error: (Each undeclared identifier is reported only once >> tools/mkv310_image.c:67: error: for each function it appears in.) >> tools/mkv310_image.c:67: error: 'S_IWUSR' undeclared (first use in this function) >> tools/mkv310_image.c:67: error: 'S_IRGRP' undeclared (first use in this function) >> tools/mkv310_image.c:67: error: 'S_IWGRP' undeclared (first use in this function) >> tools/mkv310_image.c:67: error: 'S_IROTH' undeclared (first use in this function) >> tools/mkv310_image.c:67: error: 'S_IWOTH' undeclared (first use in this function) >> >> resulting from a 'make smdkv310_config'. >> >> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com> >> >> --- >> Changes in v2: Use sys/stat.h instead of linux/stat.h >> >> Note: mkv310_image is compiled for the host by the host's gcc: >> >> cd mmc_spl/board/samsung/smdkv310 >> gcc tools/mkv310_image.c -o tools/mkv310_mmc_spl_exec >> >> mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c | 1 + >> 1 file changed, 1 insertion(+) >> applied to u-boot-samsung. Please use "git format-patch" to make patches. Thanks Minkyu Kang
On 13.07.2011 10:53, Minkyu Kang wrote: > Dear Dirk Behme, > > On 12 July 2011 16:20, Chander Kashyap<chander.kashyap@linaro.org> wrote: >> On 12 July 2011 00:19, Dirk Behme<dirk.behme@googlemail.com> wrote: >>> From: Dirk Behme<dirk.behme@googlemail.com> >>> >>> Fix compilation of mkv310_image host tool >>> >>> tools/mkv310_image.c: In function 'main': >>> tools/mkv310_image.c:67: error: 'S_IRUSR' undeclared (first use in this function) >>> tools/mkv310_image.c:67: error: (Each undeclared identifier is reported only once >>> tools/mkv310_image.c:67: error: for each function it appears in.) >>> tools/mkv310_image.c:67: error: 'S_IWUSR' undeclared (first use in this function) >>> tools/mkv310_image.c:67: error: 'S_IRGRP' undeclared (first use in this function) >>> tools/mkv310_image.c:67: error: 'S_IWGRP' undeclared (first use in this function) >>> tools/mkv310_image.c:67: error: 'S_IROTH' undeclared (first use in this function) >>> tools/mkv310_image.c:67: error: 'S_IWOTH' undeclared (first use in this function) >>> >>> resulting from a 'make smdkv310_config'. >>> >>> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com> >>> >>> --- >>> Changes in v2: Use sys/stat.h instead of linux/stat.h >>> >>> Note: mkv310_image is compiled for the host by the host's gcc: >>> >>> cd mmc_spl/board/samsung/smdkv310 >>> gcc tools/mkv310_image.c -o tools/mkv310_mmc_spl_exec >>> >>> mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c | 1 + >>> 1 file changed, 1 insertion(+) >>> > > applied to u-boot-samsung. Could we get a pull request for u-boot-samsung to get this fixed in mainline? Many thanks Dirk
Index: u-boot.git/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c =================================================================== --- u-boot.git.orig/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c +++ u-boot.git/mmc_spl/board/samsung/smdkv310/tools/mkv310_image.c @@ -26,6 +26,7 @@ #include <fcntl.h> #include <errno.h> #include <string.h> +#include <sys/stat.h> #define CHECKSUM_OFFSET (14*1024-4) #define BUFSIZE (16*1024)