| Message ID | 20200522135246.10134-13-tzimmermann@suse.de |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drm: Convert most CMA-based drivers to GEM object functions | expand |
On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > The mcde driver uses the default implementation for CMA functions. The > DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. > All remaining operations are provided by CMA GEM object functions. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Hi Am 25.05.20 um 13:36 schrieb Linus Walleij: > On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > >> The mcde driver uses the default implementation for CMA functions. The >> DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. >> All remaining operations are provided by CMA GEM object functions. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Could you boot-test with the patchset applied? Best regards Thomas > > Yours, > Linus Walleij >
On Mon, May 25, 2020 at 2:51 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > Am 25.05.20 um 13:36 schrieb Linus Walleij: > > On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > > >> The mcde driver uses the default implementation for CMA functions. The > >> DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. > >> All remaining operations are provided by CMA GEM object functions. > >> > >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Could you boot-test with the patchset applied? Yes, if you have a git branch I can just build and boot I can do it quickly! I have no idea what this patch set is based on so it could be hard to figure out the dependencies otherwise. Also many patches. Yours, Linus Walleij
Hi Am 25.05.20 um 15:08 schrieb Linus Walleij: > On Mon, May 25, 2020 at 2:51 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: >> Am 25.05.20 um 13:36 schrieb Linus Walleij: >>> On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: >>> >>>> The mcde driver uses the default implementation for CMA functions. The >>>> DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. >>>> All remaining operations are provided by CMA GEM object functions. >>>> >>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >>> >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> >> Could you boot-test with the patchset applied? > > Yes, if you have a git branch I can just build and boot I can > do it quickly! Fantastic! It's the cma-objfuncs branch of https://gitlab.freedesktop.org/tzimmermann/linux.git Here's the gitlab page: https://gitlab.freedesktop.org/tzimmermann/linux/-/tree/cma-objfuncs Best regards Thomas > > I have no idea what this patch set is based on so it could be > hard to figure out the dependencies otherwise. Also many > patches. > > Yours, > Linus Walleij > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 84f3e2dbd77bd..d300be5ee463d 100644 --- a/drivers/gpu/drm/mcde/mcde_drv.c +++ b/drivers/gpu/drm/mcde/mcde_drv.c @@ -228,17 +228,7 @@ static struct drm_driver mcde_drm_driver = { .major = 1, .minor = 0, .patchlevel = 0, - .dumb_create = drm_gem_cma_dumb_create, - .gem_free_object_unlocked = drm_gem_cma_free_object, - .gem_vm_ops = &drm_gem_cma_vm_ops, - - .prime_handle_to_fd = drm_gem_prime_handle_to_fd, - .prime_fd_to_handle = drm_gem_prime_fd_to_handle, - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table, - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table, - .gem_prime_vmap = drm_gem_cma_prime_vmap, - .gem_prime_vunmap = drm_gem_cma_prime_vunmap, - .gem_prime_mmap = drm_gem_cma_prime_mmap, + DRM_GEM_CMA_DRIVER_OPS, }; static int mcde_drm_bind(struct device *dev)
The mcde driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/mcde/mcde_drv.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)