diff mbox series

[v1,4/5] gpio: pca935x: Allow IRQ support for driver built as a module

Message ID 20200520211916.25727-4-andriy.shevchenko@linux.intel.com
State New
Headers show
Series [v1,1/5] gpiolib: acpi: Introduce opaque data field for quirks | expand

Commit Message

Andy Shevchenko May 20, 2020, 9:19 p.m. UTC
Perhaps by some historical reasons the IRQ support has been allowed
only for built-in driver. However, there is nothing prevents us
to build it as module an use as IRQ chip.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bartosz Golaszewski May 25, 2020, 9:38 a.m. UTC | #1
śr., 20 maj 2020 o 23:19 Andy Shevchenko
<andriy.shevchenko@linux.intel.com> napisał(a):
>
> Perhaps by some historical reasons the IRQ support has been allowed
> only for built-in driver. However, there is nothing prevents us
> to build it as module an use as IRQ chip.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

This may have been a stand-alone patch as well, so I went ahead and
applied it for next.

Bart
Andy Shevchenko May 25, 2020, 10:09 a.m. UTC | #2
On Mon, May 25, 2020 at 11:38:32AM +0200, Bartosz Golaszewski wrote:
> śr., 20 maj 2020 o 23:19 Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> napisał(a):
> >
> > Perhaps by some historical reasons the IRQ support has been allowed
> > only for built-in driver. However, there is nothing prevents us
> > to build it as module an use as IRQ chip.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> This may have been a stand-alone patch as well,

Yes.

>	so I went ahead and applied it for next.

Thanks!
diff mbox series

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 03c01f4aa316..eff454eed9a7 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -952,7 +952,7 @@  config GPIO_PCA953X
 
 config GPIO_PCA953X_IRQ
 	bool "Interrupt controller support for PCA953x"
-	depends on GPIO_PCA953X=y
+	depends on GPIO_PCA953X
 	select GPIOLIB_IRQCHIP
 	help
 	  Say yes here to enable the pca953x to be used as an interrupt