| Message ID | 20200521200439.1076672-1-kw@linux.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI/switchtec: Correct bool variable type assignment | expand |
On 2020-05-21 2:04 p.m., Krzysztof Wilczynski wrote: > Use true instead of 1 in the assignment as the variable use_dma_mrpc is > of a bool type. Also, resolve the following Coccinelle warning: > > drivers/pci/switch/switchtec.c:28:12-24: WARNING: Assignment of 0/1 to > bool variable > > Signed-off-by: Krzysztof Wilczynski <kw@linux.com> Sure, Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > --- > drivers/pci/switch/switchtec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c > index e69cac84b605..850cfeb74608 100644 > --- a/drivers/pci/switch/switchtec.c > +++ b/drivers/pci/switch/switchtec.c > @@ -25,7 +25,7 @@ static int max_devices = 16; > module_param(max_devices, int, 0644); > MODULE_PARM_DESC(max_devices, "max number of switchtec device instances"); > > -static bool use_dma_mrpc = 1; > +static bool use_dma_mrpc = true; > module_param(use_dma_mrpc, bool, 0644); > MODULE_PARM_DESC(use_dma_mrpc, > "Enable the use of the DMA MRPC feature"); >
On Thu, May 21, 2020 at 08:04:39PM +0000, Krzysztof Wilczynski wrote: > Use true instead of 1 in the assignment as the variable use_dma_mrpc is > of a bool type. Also, resolve the following Coccinelle warning: > > drivers/pci/switch/switchtec.c:28:12-24: WARNING: Assignment of 0/1 to > bool variable > > Signed-off-by: Krzysztof Wilczynski <kw@linux.com> Applied to pci/switchtec for v5.8, thanks! > --- > drivers/pci/switch/switchtec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c > index e69cac84b605..850cfeb74608 100644 > --- a/drivers/pci/switch/switchtec.c > +++ b/drivers/pci/switch/switchtec.c > @@ -25,7 +25,7 @@ static int max_devices = 16; > module_param(max_devices, int, 0644); > MODULE_PARM_DESC(max_devices, "max number of switchtec device instances"); > > -static bool use_dma_mrpc = 1; > +static bool use_dma_mrpc = true; > module_param(use_dma_mrpc, bool, 0644); > MODULE_PARM_DESC(use_dma_mrpc, > "Enable the use of the DMA MRPC feature"); > -- > 2.26.2 >
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c index e69cac84b605..850cfeb74608 100644 --- a/drivers/pci/switch/switchtec.c +++ b/drivers/pci/switch/switchtec.c @@ -25,7 +25,7 @@ static int max_devices = 16; module_param(max_devices, int, 0644); MODULE_PARM_DESC(max_devices, "max number of switchtec device instances"); -static bool use_dma_mrpc = 1; +static bool use_dma_mrpc = true; module_param(use_dma_mrpc, bool, 0644); MODULE_PARM_DESC(use_dma_mrpc, "Enable the use of the DMA MRPC feature");
Use true instead of 1 in the assignment as the variable use_dma_mrpc is of a bool type. Also, resolve the following Coccinelle warning: drivers/pci/switch/switchtec.c:28:12-24: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Krzysztof Wilczynski <kw@linux.com> --- drivers/pci/switch/switchtec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)