| Message ID | 1589518105-18368-6-git-send-email-hayashi.kunihiko@socionext.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: uniphier: Add features for UniPhier PCIe host controller | expand |
On 2020/05/15 15:51, kbuild test robot wrote: > Hi Kunihiko, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on pci/next] > [also build test WARNING on robh/for-next v5.7-rc5 next-20200514] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Kunihiko-Hayashi/PCI-uniphier-Add-features-for-UniPhier-PCIe-host-controller/20200515-125031 > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > config: i386-allyesconfig (attached as .config) > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>, old ones prefixed by <<): > > In file included from include/linux/device.h:15:0, > from include/linux/pci.h:37, > from drivers/pci/controller/dwc/pcie-uniphier.c:18: > drivers/pci/controller/dwc/pcie-uniphier.c: In function 'uniphier_pcie_probe': >>> drivers/pci/controller/dwc/pcie-uniphier.c:470:16: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=] > dev_err(dev, "Failed to get phy (%d)n", PTR_ERR(priv->phy)); > ^ > include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' > #define dev_fmt(fmt) fmt > ^~~ >>> drivers/pci/controller/dwc/pcie-uniphier.c:470:3: note: in expansion of macro 'dev_err' > dev_err(dev, "Failed to get phy (%d)n", PTR_ERR(priv->phy)); > ^~~~~~~ This should be fixed. I'll fix it in v2. Thanks, --- Best Regards Kunihiko Hayashi
diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c index 6180d50..2bcf394 100644 --- a/drivers/pci/controller/dwc/pcie-uniphier.c +++ b/drivers/pci/controller/dwc/pcie-uniphier.c @@ -480,8 +480,10 @@ static int uniphier_pcie_probe(struct platform_device *pdev) return PTR_ERR(priv->rst); priv->phy = devm_phy_optional_get(dev, "pcie-phy"); - if (IS_ERR(priv->phy)) + if (IS_ERR(priv->phy)) { + dev_err(dev, "Failed to get phy (%d)\n", PTR_ERR(priv->phy)); return PTR_ERR(priv->phy); + } platform_set_drvdata(pdev, priv);
Even if phy driver doesn't probe, the error message can't be distinguished from other errors. This displays error message caused by the phy driver explicitly. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- drivers/pci/controller/dwc/pcie-uniphier.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)