| Message ID | 20200428054352.110007-1-james.hilliard1@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/1] support/dependencies: set cmake version min to 3.15.3 | expand |
On Mon, 27 Apr 2020 23:43:52 -0600 James Hilliard <james.hilliard1@gmail.com> wrote: > This is required by uvw. > > Fixes: > http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.log > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> The CMake version required by uvw was suddenly bumped from 3.2 to 3.15.3 in upstream commit 55d7782af5654cde8bba89071e13d240fd27ff3b. From a quick look of it, I don't really see why it was bumped "so high". Could you instead try to revert to a minimum CMake version of 3.10 in uvw, and see if it builds ? Thanks, Thomas
Hello, On Tue, Apr 28, 2020 at 9:04 AM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Mon, 27 Apr 2020 23:43:52 -0600 > James Hilliard <james.hilliard1@gmail.com> wrote: > > > This is required by uvw. > > > > Fixes: > > http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.log > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > The CMake version required by uvw was suddenly bumped from 3.2 to > 3.15.3 in upstream commit 55d7782af5654cde8bba89071e13d240fd27ff3b. > > From a quick look of it, I don't really see why it was bumped "so > high". Could you instead try to revert to a minimum CMake version of > 3.10 in uvw, and see if it builds ? I tried to build the package with CMake 3.10 and it failed with: CMake Error at CMakeLists.txt:22 (project): No CMAKE_HOMEPAGE_URL_COMPILER could be found. Tell CMake where to find the compiler by setting the CMake cache entry CMAKE_HOMEPAGE_URL_COMPILER to the full path to the compiler, or to the compiler name if it is in the PATH. The minimum version I managed to compile with is 3.12 > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot Regards, Asaf.
On Sat, May 2, 2020 at 2:27 AM Asaf Kahlon <asafka7@gmail.com> wrote: > > Hello, > > On Tue, Apr 28, 2020 at 9:04 AM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: > > > > On Mon, 27 Apr 2020 23:43:52 -0600 > > James Hilliard <james.hilliard1@gmail.com> wrote: > > > > > This is required by uvw. > > > > > > Fixes: > > > http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.log > > > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > > > The CMake version required by uvw was suddenly bumped from 3.2 to > > 3.15.3 in upstream commit 55d7782af5654cde8bba89071e13d240fd27ff3b. > > > > From a quick look of it, I don't really see why it was bumped "so > > high". Could you instead try to revert to a minimum CMake version of > > 3.10 in uvw, and see if it builds ? > > I tried to build the package with CMake 3.10 and it failed with: > CMake Error at CMakeLists.txt:22 (project): > No CMAKE_HOMEPAGE_URL_COMPILER could be found. > > Tell CMake where to find the compiler by setting the CMake cache entry > CMAKE_HOMEPAGE_URL_COMPILER to the full path to the compiler, or to the > compiler name if it is in the PATH. > > > The minimum version I managed to compile with is 3.12 Upstream seems to think the minimum is 3.13 see discussion here: https://github.com/skypjack/uvw/issues/194 > > > > Thanks, > > > > Thomas > > -- > > Thomas Petazzoni, CTO, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > Regards, > Asaf.
Hello, On Mon, May 4, 2020 at 1:10 AM James Hilliard <james.hilliard1@gmail.com> wrote: > > On Sat, May 2, 2020 at 2:27 AM Asaf Kahlon <asafka7@gmail.com> wrote: > > > > Hello, > > > > On Tue, Apr 28, 2020 at 9:04 AM Thomas Petazzoni > > <thomas.petazzoni@bootlin.com> wrote: > > > > > > On Mon, 27 Apr 2020 23:43:52 -0600 > > > James Hilliard <james.hilliard1@gmail.com> wrote: > > > > > > > This is required by uvw. > > > > > > > > Fixes: > > > > http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.log > > > > > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > > > > > The CMake version required by uvw was suddenly bumped from 3.2 to > > > 3.15.3 in upstream commit 55d7782af5654cde8bba89071e13d240fd27ff3b. > > > > > > From a quick look of it, I don't really see why it was bumped "so > > > high". Could you instead try to revert to a minimum CMake version of > > > 3.10 in uvw, and see if it builds ? > > > > I tried to build the package with CMake 3.10 and it failed with: > > CMake Error at CMakeLists.txt:22 (project): > > No CMAKE_HOMEPAGE_URL_COMPILER could be found. > > > > Tell CMake where to find the compiler by setting the CMake cache entry > > CMAKE_HOMEPAGE_URL_COMPILER to the full path to the compiler, or to the > > compiler name if it is in the PATH. > > > > > > The minimum version I managed to compile with is 3.12 > Upstream seems to think the minimum is 3.13 see discussion here: > https://github.com/skypjack/uvw/issues/194 According to this issue, uvw needs at least 3.12 and for some features even 3.13. Anyway, it seems like we have to bump our minimal required version in order to make sure uvw builds correctly. > > > > > > Thanks, > > > > > > Thomas > > > -- > > > Thomas Petazzoni, CTO, Bootlin > > > Embedded Linux and Kernel engineering > > > https://bootlin.com > > > _______________________________________________ > > > buildroot mailing list > > > buildroot@busybox.net > > > http://lists.busybox.net/mailman/listinfo/buildroot > > > > Regards, > > Asaf. Regards, Asaf.
James, All, Sorry to come back to that one so late... On 2020-04-27 23:43 -0600, James Hilliard spake thusly: > This is required by uvw. > > Fixes: > http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.log > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> Following the discussion on this thread back at the time, it turned out that the real minimum version was in fact 3.13, not 3.15, and it still is, but I can't see a v2 of that patch changing to just 3.13. Furthermore, I've now applied another, nore recent, patch by Fabrice, who provided a better commit log at explaining another good reason to bump to 3.15. Thanks! Regards, Yann E. MORIN. > --- > support/dependencies/check-host-cmake.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/support/dependencies/check-host-cmake.mk b/support/dependencies/check-host-cmake.mk > index 01f38da376..b0a704c0f2 100644 > --- a/support/dependencies/check-host-cmake.mk > +++ b/support/dependencies/check-host-cmake.mk > @@ -3,7 +3,7 @@ > # package is bumped or a new one added, and it requires a higher > # version, our cmake infra will catch it and build its own. > # > -BR2_CMAKE_VERSION_MIN = 3.10 > +BR2_CMAKE_VERSION_MIN = 3.15.3 > > BR2_CMAKE_CANDIDATES ?= cmake cmake3 > BR2_CMAKE ?= $(call suitable-host-package,cmake,\ > -- > 2.20.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/support/dependencies/check-host-cmake.mk b/support/dependencies/check-host-cmake.mk index 01f38da376..b0a704c0f2 100644 --- a/support/dependencies/check-host-cmake.mk +++ b/support/dependencies/check-host-cmake.mk @@ -3,7 +3,7 @@ # package is bumped or a new one added, and it requires a higher # version, our cmake infra will catch it and build its own. # -BR2_CMAKE_VERSION_MIN = 3.10 +BR2_CMAKE_VERSION_MIN = 3.15.3 BR2_CMAKE_CANDIDATES ?= cmake cmake3 BR2_CMAKE ?= $(call suitable-host-package,cmake,\
This is required by uvw. Fixes: http://autobuild.buildroot.net/results/ab6/ab6954a65fd6d43c0674cb7a38a941102cb0dfe3/build-end.log Signed-off-by: James Hilliard <james.hilliard1@gmail.com> --- support/dependencies/check-host-cmake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)