| Message ID | 20200417124046.26400-1-jonathanh@nvidia.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | soc/tegra: fuse: Update the SoC revision attribute to display a name | expand |
On Fri, Apr 17, 2020 at 01:40:46PM +0100, Jon Hunter wrote: > Currently the SoC revision attribute for Tegra devices displays the > value of the enum associated with a particular revision. This is not > very useful because to obtain the actual revision you need to > use the tegra_revision enumeration to translate the value. > > It is more meaningful to display a name for the revision, such as > 'A01', than the enumarated value and therefore, update the revision > attribute to display a name. This change does alter the ABI, which > is unfortunate, but this is more meaningful and maintable. > > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. Thierry
diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c index db65ddb6a5d2..d1f8dd0289e6 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra.c +++ b/drivers/soc/tegra/fuse/fuse-tegra.c @@ -363,7 +363,8 @@ struct device * __init tegra_soc_device_register(void) return NULL; attr->family = kasprintf(GFP_KERNEL, "Tegra"); - attr->revision = kasprintf(GFP_KERNEL, "%d", tegra_sku_info.revision); + attr->revision = kasprintf(GFP_KERNEL, "%s", + tegra_revision_name[tegra_sku_info.revision]); attr->soc_id = kasprintf(GFP_KERNEL, "%u", tegra_get_chip_id()); attr->custom_attr_group = fuse->soc->soc_attr_group;
Currently the SoC revision attribute for Tegra devices displays the value of the enum associated with a particular revision. This is not very useful because to obtain the actual revision you need to use the tegra_revision enumeration to translate the value. It is more meaningful to display a name for the revision, such as 'A01', than the enumarated value and therefore, update the revision attribute to display a name. This change does alter the ABI, which is unfortunate, but this is more meaningful and maintable. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)