| Message ID | 1587387114-38475-1-git-send-email-ani@anisinha.ca |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: pciehp: remove unused EMI() macro | expand |
On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote: > EMI() macro seems to be unused. So removing it. Thanks > Mika Westerberg <mika.westerberg@linux.intel.com> for > pointing it out. > > Signed-off-by: Ani Sinha <ani@anisinha.ca> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Hi Ani, On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote: > EMI() macro seems to be unused. So removing it. Thanks > Mika Westerberg <mika.westerberg@linux.intel.com> for > pointing it out. > > Signed-off-by: Ani Sinha <ani@anisinha.ca> > --- > drivers/pci/hotplug/pciehp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h > index 5747967..4fd200d 100644 > --- a/drivers/pci/hotplug/pciehp.h > +++ b/drivers/pci/hotplug/pciehp.h > @@ -148,7 +148,6 @@ struct controller { > #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP) > #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP) > #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP) > -#define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP) Thanks for the patch! Can you squash it together with the HP_SUPR_RM removal (and also check for any other unused ones at the same time)? For trivial things like this, I'd rather merge one patch that removes several unused things at once instead of several patches. I like the subject of this one ("Removed unused ..."), but please capitalize it as you did for the HP_SUPR_RM one so it matches previous history. Bjorn > #define NO_CMD_CMPL(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS) > #define PSN(ctrl) (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19) > > -- > 2.7.4 >
On Mon, Apr 20, 2020 at 11:27 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > Hi Ani, > > On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote: > > EMI() macro seems to be unused. So removing it. Thanks > > Mika Westerberg <mika.westerberg@linux.intel.com> for > > pointing it out. > > > > Signed-off-by: Ani Sinha <ani@anisinha.ca> > > --- > > drivers/pci/hotplug/pciehp.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h > > index 5747967..4fd200d 100644 > > --- a/drivers/pci/hotplug/pciehp.h > > +++ b/drivers/pci/hotplug/pciehp.h > > @@ -148,7 +148,6 @@ struct controller { > > #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP) > > #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP) > > #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP) > > -#define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP) > > Thanks for the patch! Can you squash it together with the HP_SUPR_RM > removal (and also check for any other unused ones at the same time)? > For trivial things like this, I'd rather merge one patch that removes > several unused things at once instead of several patches. > > I like the subject of this one ("Removed unused ..."), but please > capitalize it as you did for the HP_SUPR_RM one so it matches previous > history. I have sent an updated patch few days back. ani
diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index 5747967..4fd200d 100644 --- a/drivers/pci/hotplug/pciehp.h +++ b/drivers/pci/hotplug/pciehp.h @@ -148,7 +148,6 @@ struct controller { #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP) #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP) #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP) -#define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP) #define NO_CMD_CMPL(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS) #define PSN(ctrl) (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
EMI() macro seems to be unused. So removing it. Thanks Mika Westerberg <mika.westerberg@linux.intel.com> for pointing it out. Signed-off-by: Ani Sinha <ani@anisinha.ca> --- drivers/pci/hotplug/pciehp.h | 1 - 1 file changed, 1 deletion(-)