Message ID | 4E0C5B1F.3080608@aribaud.net |
---|---|
State | Superseded |
Headers | show |
Dear all, Am 30.06.2011 um 13:16 schrieb Albert ARIBAUD: <snip> > Andreas Bießmann (1): > atstk100x: switch to common cfi driver <snip> > andreas.devel@googlemail.com (8): > at91rm9200.h: fix ATMEL_PMX_AA_TXD2 > arm920t/at91: add clock.c > arm920t/at91: use new clock.c features > arm920t/at91: add at91rm9200_devices.c > at91rm9200ek: use atmel_usart > eb_cpux9k2: use atmel_usart > cpuat91: use atmel_usart > driver/serial: delete at91rm9200_usart why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? regards Andreas Bießmann
Le 01/07/2011 08:22, Andreas Bießmann a écrit : > Dear all, > > Am 30.06.2011 um 13:16 schrieb Albert ARIBAUD: > > <snip> > >> Andreas Bießmann (1): >> atstk100x: switch to common cfi driver > > <snip> > >> andreas.devel@googlemail.com (8): >> at91rm9200.h: fix ATMEL_PMX_AA_TXD2 >> arm920t/at91: add clock.c >> arm920t/at91: use new clock.c features >> arm920t/at91: add at91rm9200_devices.c >> at91rm9200ek: use atmel_usart >> eb_cpux9k2: use atmel_usart >> cpuat91: use atmel_usart >> driver/serial: delete at91rm9200_usart > > why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? Hmm... Sorry for not having noticed this. Apparently, it is already so in u-boot-atmel/. I have just created a branch out of the current u-boot/master, run 'pwclient get 100074' and 'git am', and your name appears as normal. Reinhard, what commands did you use to applie these patches? Wolfgang, please hold the pulling until we sort this out. Sorry for the repeated inconvenience. :( > regards > > Andreas Bießmann Amicalement,
Dear All, > Le 01/07/2011 08:22, Andreas Bießmann a écrit : >> Dear all, >> >> Am 30.06.2011 um 13:16 schrieb Albert ARIBAUD: >> >> <snip> >> >>> Andreas Bießmann (1): >>> atstk100x: switch to common cfi driver Patchwork says: Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com> Saved mbix file starts like: From patchwork Tue Jun 28 14:15:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [U-Boot] atstk100x: switch to common cfi driver Date: Tue, 28 Jun 2011 04:15:58 -0000 From: =?utf-8?q?Andreas_Bie=C3=9Fmann_=3Cbiessmann=40corscience=2Ede=3E?= X-Patchwork-Id: 102387 Message-Id: <1309270558-25351-1-git-send-email-biessmann@corscience.de> To: u-boot@lists.denx.de Cc: =?UTF-8?q?Andreas=20Bie=C3=9Fmann?= <biessmann@corscience.de> This patch removes the board implemenatation for flash driver which can now safely switched to the common cfi driver. Compile tested for all atstk100x boards, runtime tested on atstk1002. Signed-off-by: Andreas Bießmann <biessmann@corscience.de> >> >> <snip> >> >>> andreas.devel@googlemail.com (8): >>> at91rm9200.h: fix ATMEL_PMX_AA_TXD2 >>> arm920t/at91: add clock.c >>> arm920t/at91: use new clock.c features >>> arm920t/at91: add at91rm9200_devices.c >>> at91rm9200ek: use atmel_usart >>> eb_cpux9k2: use atmel_usart >>> cpuat91: use atmel_usart >>> driver/serial: delete at91rm9200_usart Patchworks says: Signed-off-by: Andreas Bießmann <biessmann@corscience.de> Saved mbox file starts like: From patchwork Sun Jun 12 11:49:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [U-Boot,atmel/next,3/7] arm920t/at91: add at91rm9200_devices.c Date: Sun, 12 Jun 2011 01:49:13 -0000 From: =?utf-8?q?Andreas_Bie=C3=9Fmann_=3Candreas=2Edevel=40googlemail=2Ecom?= =?utf-8?q?=3E?= X-Patchwork-Id: 100078 Message-Id: <1307879357-97986-4-git-send-email-andreas.devel@googlemail.com> To: u-boot@lists.denx.de, Reinhard Meyer <u-boot@emk-elektronik.de> This is a copy of arm926ejs/at91 api for perpherial initialisation. At the moment we just need the usart part of the api. Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com> >> >> why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? > > Hmm... Sorry for not having noticed this. Apparently, it is already so in u-boot-atmel/. I have just created a branch out of the current u-boot/master, run 'pwclient get 100074' and 'git am', and your name appears as normal. > > Reinhard, what commands did you use to applie these patches? ALWAYS using patchworks: Download mbox, git-am <the downloaded file>. Apparently it makes a difference where the mail originated from. Reinhard
Am 01.07.2011 12:05, schrieb Reinhard Meyer: ... >>> why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? >> >> Hmm... Sorry for not having noticed this. Apparently, it is already so in u-boot-atmel/. I have just created a branch out of the current u-boot/master, run 'pwclient get 100074' and 'git am', and your name appears as normal. >> >> Reinhard, what commands did you use to applie these patches? > > ALWAYS using patchworks: Download mbox, git-am <the downloaded file>. > > Apparently it makes a difference where the mail originated from. I downloaded pwclient, used 'pwclient get' and 'git-am' and get the same different results, depending on where the patch mail originated from. I used patches 100071 and 102387 to test. git is version 1.5.6.5 Reinhard
Dear Reinhard Meyer, Am 01.07.2011 12:05, schrieb Reinhard Meyer: > Dear All, >> Le 01/07/2011 08:22, Andreas Bießmann a écrit : >>> Dear all, >>> >>> Am 30.06.2011 um 13:16 schrieb Albert ARIBAUD: >>> >>> <snip> >>> >>>> Andreas Bießmann (1): >>>> atstk100x: switch to common cfi driver > > Patchwork says: Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com> > > Saved mbix file starts like: > > From patchwork Tue Jun 28 14:15:58 2011 > Content-Type: text/plain; charset="utf-8" <snip> > Signed-off-by: Andreas Bießmann <biessmann@corscience.de> <snip> > > Patchworks says: Signed-off-by: Andreas Bießmann <biessmann@corscience.de> > > Saved mbox file starts like: > > From patchwork Sun Jun 12 11:49:13 2011 > Content-Type: text/plain; charset="utf-8" <snip> > Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com> >> Reinhard, what commands did you use to applie these patches? > > ALWAYS using patchworks: Download mbox, git-am <the downloaded file>. > > Apparently it makes a difference where the mail originated from. Well, if I load the two patchwork ID's 100078 and 102387 both patches are correctly UTF-8 coded. In your mail the 'ß' is due to wrong conversion on your box -> (charset=windows-1252 == ISO-8859-1 but the mail contains the correctly UTF-8 coded char 'ß') try the following: ---8<--- echo -e '\xc3\x9f\x0a' | iconv -f ISO-8859-1 -t UTF-8 echo ß | iconv -f ISO-8859-1 -t UTF-8 --->8--- It should show the same two chars 'ß' (if your shell environment is set to UTF-8) ... I guess it has something to do with wrong shell environment settings/misconfigured git/ ... but indeed it is something on your side Reinhard. I do not insist on modified commits, therefore it could be pulled in mainline. But for the future, Reinhard please check your environment. regards Andreas Bießmann
Le 01/07/2011 12:05, Reinhard Meyer a écrit : >>> why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? >> >> Hmm... Sorry for not having noticed this. Apparently, it is already so in u-boot-atmel/. I have just created a branch out of the current u-boot/master, run 'pwclient get 100074' and 'git am', and your name appears as normal. >> >> Reinhard, what commands did you use to applie these patches? > > ALWAYS using patchworks: Download mbox, git-am<the downloaded file>. > > Apparently it makes a difference where the mail originated from. If you mean it makes a difference whether you download the mbox or use pwclient, I just tried both and got exactly the same .patch file (except for an added "From patchwork" line at the top, due to the mbox format, and a git am of either file results in Andreas' full name and address being shown as author, as expected. Seems like either "your" and "my" .patch files differ in some way, or our setups (system, locale, git configuration). > Reinhard Amicalement,
Dear Reinhard Meyer, Am 01.07.2011 12:47, schrieb Reinhard Meyer: > Am 01.07.2011 12:05, schrieb Reinhard Meyer: <snip> > git is version 1.5.6.5 can you please try a more recent version? (squeeze is out since February the 6th this year ;) regards Andreas Bießmann
Am 01.07.2011 12:59, schrieb Albert ARIBAUD: > Le 01/07/2011 12:05, Reinhard Meyer a écrit : > >>>> why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? >>> >>> Hmm... Sorry for not having noticed this. Apparently, it is already so in u-boot-atmel/. I have just created a branch out of the current u-boot/master, run 'pwclient get 100074' and 'git am', and your name appears as normal. >>> >>> Reinhard, what commands did you use to applie these patches? >> >> ALWAYS using patchworks: Download mbox, git-am<the downloaded file>. >> >> Apparently it makes a difference where the mail originated from. > > > If you mean it makes a difference whether you download the mbox or use pwclient, I just tried both and got exactly the same .patch file (except for an added "From patchwork" line at the top, due to the mbox format, and a git am of either file results in Andreas' full name and address being shown as author, as expected. > > Seems like either "your" and "my" .patch files differ in some way, or our setups (system, locale, git configuration). > >> Reinhard > > Amicalement, I mean that it makes no difference whether I get the .patch files by "mbox" or by "pwclient". What makes a difference is whether the patch was sent via googlemail or not. Apparently the subtle differences lead to different interpretation by git-am. If that is a configuration issue, I do now know where to look at. Reinhard
Hi all, Le 01/07/2011 12:55, Andreas Bießmann a écrit : > I do not insist on modified commits, therefore it could be pulled in > mainline. But for the future, Reinhard please check your environment. We are right at the beginning of the merge window, so the pull is not urgent, and I prefer that we have proper patch author attribution, name included. If Reinhard can identify the issue and wishes to re-issue a pull request (based on the same u-boot-arm commit as the original one), that's fine with me, I'll wait. > regards > > Andreas Bießmann Amicalement,
Dear Andreas Bießmann, > Dear Reinhard Meyer, > > Am 01.07.2011 12:47, schrieb Reinhard Meyer: >> Am 01.07.2011 12:05, schrieb Reinhard Meyer: > > <snip> > >> git is version 1.5.6.5 > > can you please try a more recent version? > > (squeeze is out since February the 6th this year ;) my time is *very* limited right now, and I honestly am not up to updating git every few months... Best Regards, Reinhard
Dear Reinhard Meyer, Am 01.07.2011 13:07, schrieb Reinhard Meyer: > Dear Andreas Bießmann, >> Dear Reinhard Meyer, >> >> Am 01.07.2011 12:47, schrieb Reinhard Meyer: >>> Am 01.07.2011 12:05, schrieb Reinhard Meyer: >> >> <snip> >> >>> git is version 1.5.6.5 >> >> can you please try a more recent version? >> >> (squeeze is out since February the 6th this year ;) > > my time is *very* limited right now, like most of us ... > and I honestly am not up to > updating git every few months... But 1.5.6.5 is really old version. I do have an old virtual machine running lenny and give it a try. I will check, if git version is the root cause of this problem (what I think it is). You could - if you really have lenny installed - give lenny-backports repository a try: http://packages.debian.org/lenny-backports/git regards Andreas Bießmann
Dear Reinhard Meyer, Am 01.07.2011 13:14, schrieb Andreas Bießmann: > Dear Reinhard Meyer, > > Am 01.07.2011 13:07, schrieb Reinhard Meyer: >> Dear Andreas Bießmann, >>> Dear Reinhard Meyer, >>> >>> Am 01.07.2011 12:47, schrieb Reinhard Meyer: >>>> Am 01.07.2011 12:05, schrieb Reinhard Meyer: >>> >>> <snip> >>> >>>> git is version 1.5.6.5 >>> >>> can you please try a more recent version? >>> >>> (squeeze is out since February the 6th this year ;) >> >> my time is *very* limited right now, > > like most of us ... > >> and I honestly am not up to >> updating git every few months... > > But 1.5.6.5 is really old version. I do have an old virtual machine > running lenny and give it a try. I will check, if git version is the > root cause of this problem (what I think it is). You could - if you > really have lenny installed - give lenny-backports repository a try: > http://packages.debian.org/lenny-backports/git I can reproduce this behaviour with my lenny vm. I strongly suggest you update your git to a more recent version. You will get similar problems in future. If you really have debian lenny running and fear the move to current stable you could give lenny-backports a try, there is git 1.7.2.3 with some debian changes available and will _not_ pull a lot of libc changes in. regards Andreas Bießmann
Dear Andreas Bießmann, > Dear Reinhard Meyer, > > Am 01.07.2011 13:07, schrieb Reinhard Meyer: >> Dear Andreas Bießmann, >>> Dear Reinhard Meyer, >>> >>> Am 01.07.2011 12:47, schrieb Reinhard Meyer: >>>> Am 01.07.2011 12:05, schrieb Reinhard Meyer: >>> >>> <snip> >>> >>>> git is version 1.5.6.5 >>> >>> can you please try a more recent version? >>> >>> (squeeze is out since February the 6th this year ;) >> >> my time is *very* limited right now, > > like most of us ... > >> and I honestly am not up to >> updating git every few months... > > But 1.5.6.5 is really old version. I do have an old virtual machine > running lenny and give it a try. I will check, if git version is the > root cause of this problem (what I think it is). You could - if you > really have lenny installed - give lenny-backports repository a try: > http://packages.debian.org/lenny-backports/git If I remember correctly, I installed that version not even a year ago. On another thought, I long wanted to move from a "real" machine to a virtual one, therefore I already have ubuntu-10.10 running in a VM and the git there is 1.7.1. I *just* have to move all other relevant files there ;) I think getting it *all* up would take a good afternoon ;) I'll see what I can do. Best Regards, Reinhard
Am 01.07.2011 13:47, schrieb Reinhard Meyer: > Dear Andreas Bießmann, >> Dear Reinhard Meyer, >> >> Am 01.07.2011 13:07, schrieb Reinhard Meyer: <snip> > If I remember correctly, I installed that version not even a year ago. Well ... git is moving fast ;) > On another thought, I long wanted to move from a "real" machine to > a virtual one, therefore I already have ubuntu-10.10 running in a VM > and the git there is 1.7.1. That sounds really good. > I *just* have to move all other relevant files there ;) > I think getting it *all* up would take a good afternoon ;) > > I'll see what I can do. good luck. regards Andreas Bießmann
Hi Reinhard, Le 01/07/2011 13:47, Reinhard Meyer a écrit : > I *just* have to move all other relevant files there ;) > I think getting it *all* up would take a good afternoon ;) > I'll see what I can do. Are you going to fix the author names in your pull request? If not, I'll fix that locally in u-boot-arm and re-issue a pull request -- unless wolfgang NAKs me doing it. > Best Regards, > Reinhard Amicalement,
Hallo Andreas, Le 01/07/2011 08:22, Andreas Bießmann a écrit : > Dear all, > > Am 30.06.2011 um 13:16 schrieb Albert ARIBAUD: > > <snip> > >> Andreas Bießmann (1): >> atstk100x: switch to common cfi driver > > <snip> > >> andreas.devel@googlemail.com (8): >> at91rm9200.h: fix ATMEL_PMX_AA_TXD2 >> arm920t/at91: add clock.c >> arm920t/at91: use new clock.c features >> arm920t/at91: add at91rm9200_devices.c >> at91rm9200ek: use atmel_usart >> eb_cpux9k2: use atmel_usart >> cpuat91: use atmel_usart >> driver/serial: delete at91rm9200_usart > > why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? I was starting to fix the commits in the second block but I notice that they mention a different e-mail address for you than the first, isolated commit, which has "Andreas Bießmann <biessmann@corscience.de>". Do you confirm that this is normal? And if not, which address is the correct one? > regards > > Andreas Bießmann Amicalement,
Dear Albert Aribaud, Am 03.07.2011 um 22:04 schrieb Albert ARIBAUD: > Hallo Andreas, > > Le 01/07/2011 08:22, Andreas Bießmann a écrit : >> Dear all, >> >> Am 30.06.2011 um 13:16 schrieb Albert ARIBAUD: >> >> <snip> >> >>> Andreas Bießmann (1): >>> atstk100x: switch to common cfi driver >> >> <snip> >> >>> andreas.devel@googlemail.com (8): >>> at91rm9200.h: fix ATMEL_PMX_AA_TXD2 >>> arm920t/at91: add clock.c >>> arm920t/at91: use new clock.c features >>> arm920t/at91: add at91rm9200_devices.c >>> at91rm9200ek: use atmel_usart >>> eb_cpux9k2: use atmel_usart >>> cpuat91: use atmel_usart >>> driver/serial: delete at91rm9200_usart >> >> why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? > > I was starting to fix the commits in the second block but I notice that they mention a different e-mail address for you than the first, isolated commit, which has "Andreas Bießmann <biessmann@corscience.de>". the first one (corscience.de) is also correct. I get paid for some of my u-boot contribution (especially the avr32 stuff) and like to separate the stuff I do at work and the stuff I do for my own (gmail address). regards Andreas Bießmann
Le 03/07/2011 22:23, Andreas Bießmann a écrit : > Dear Albert Aribaud, > > Am 03.07.2011 um 22:04 schrieb Albert ARIBAUD: > >> Hallo Andreas, >> >> Le 01/07/2011 08:22, Andreas Bießmann a écrit : >>> Dear all, >>> >>> Am 30.06.2011 um 13:16 schrieb Albert ARIBAUD: >>> >>> <snip> >>> >>>> Andreas Bießmann (1): >>>> atstk100x: switch to common cfi driver >>> >>> <snip> >>> >>>> andreas.devel@googlemail.com (8): >>>> at91rm9200.h: fix ATMEL_PMX_AA_TXD2 >>>> arm920t/at91: add clock.c >>>> arm920t/at91: use new clock.c features >>>> arm920t/at91: add at91rm9200_devices.c >>>> at91rm9200ek: use atmel_usart >>>> eb_cpux9k2: use atmel_usart >>>> cpuat91: use atmel_usart >>>> driver/serial: delete at91rm9200_usart >>> >>> why is in the second block my clear name replaced by email address (as in the commits in atmel/master) but the mails have correct (UTF8-formattet) clear name in 'From:'? >> >> I was starting to fix the commits in the second block but I notice that they mention a different e-mail address for you than the first, isolated commit, which has "Andreas Bießmann<biessmann@corscience.de>". > > the first one (corscience.de) is also correct. I get paid for some of my u-boot contribution (especially the avr32 stuff) and like to separate the stuff I do at work and the stuff I do for my own (gmail address). Ok, then, I'll keep the addresses as-is, and just add "Andreas Bießman" where it is missing before the address. > regards > > Andreas Bießmann Amicalement,